Re: [RFC] powerpc: use ticket spin lock for !CONFIG_PPC_SPLPAR

2015-03-15 Thread Sam Bobroff
On 13/03/15 18:14, Benjamin Herrenschmidt wrote: > On Fri, 2015-03-13 at 18:09 +1100, Michael Ellerman wrote: >> On Thu, 2015-03-12 at 22:13 +1100, Benjamin Herrenschmidt wrote: >>> On Thu, 2015-03-12 at 18:55 +0800, Kevin Hao wrote: I know Torsten Duwe has tried to add the ticket spinlock for

Re: [RFC] powerpc: use ticket spin lock for !CONFIG_PPC_SPLPAR

2015-03-13 Thread Benjamin Herrenschmidt
On Fri, 2015-03-13 at 18:09 +1100, Michael Ellerman wrote: > On Thu, 2015-03-12 at 22:13 +1100, Benjamin Herrenschmidt wrote: > > On Thu, 2015-03-12 at 18:55 +0800, Kevin Hao wrote: > > > I know Torsten Duwe has tried to add the ticket spinlock for powerpc > > > one year ago [1]. But it make no pro

Re: [RFC] powerpc: use ticket spin lock for !CONFIG_PPC_SPLPAR

2015-03-13 Thread Michael Ellerman
On Thu, 2015-03-12 at 22:13 +1100, Benjamin Herrenschmidt wrote: > On Thu, 2015-03-12 at 18:55 +0800, Kevin Hao wrote: > > I know Torsten Duwe has tried to add the ticket spinlock for powerpc > > one year ago [1]. But it make no progress due to the conflict between > > PPC_SPLPAR and lockref. We st

Re: [RFC] powerpc: use ticket spin lock for !CONFIG_PPC_SPLPAR

2015-03-13 Thread Benjamin Herrenschmidt
On Fri, 2015-03-13 at 14:09 +0800, Kevin Hao wrote: > On Thu, Mar 12, 2015 at 04:24:10PM +0100, Torsten Duwe wrote: > > But generally, which platforms would benefit most from this change? > > In theory, the more cpus the platform has, the more serious the thundering > herd problem is. So the lates

Re: [RFC] powerpc: use ticket spin lock for !CONFIG_PPC_SPLPAR

2015-03-12 Thread Kevin Hao
On Thu, Mar 12, 2015 at 04:24:10PM +0100, Torsten Duwe wrote: > But generally, which platforms would benefit most from this change? In theory, the more cpus the platform has, the more serious the thundering herd problem is. So the latest platforms which has more cpus would benefit most. Thanks, K

Re: [RFC] powerpc: use ticket spin lock for !CONFIG_PPC_SPLPAR

2015-03-12 Thread Kevin Hao
On Thu, Mar 12, 2015 at 10:13:27PM +1100, Benjamin Herrenschmidt wrote: > I would do the ifdef'ing differently, something like > > CONFIG_PPC_HAS_LOCK_OWNER > > CONFIG_PPC_TICKET_LOCKS depends on !PPC_HAS_LOCK_OWNER > > and use these two in the code... with SPLPAR select'ing HAS_LOCK_OWNER OK,

Re: [RFC] powerpc: use ticket spin lock for !CONFIG_PPC_SPLPAR

2015-03-12 Thread Torsten Duwe
On Thu, Mar 12, 2015 at 10:13:27PM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2015-03-12 at 18:55 +0800, Kevin Hao wrote: > > I know Torsten Duwe has tried to add the ticket spinlock for powerpc > > one year ago [1]. But it make no progress due to the conflict between OMG, time flies. > > PPC

Re: [RFC] powerpc: use ticket spin lock for !CONFIG_PPC_SPLPAR

2015-03-12 Thread Benjamin Herrenschmidt
On Thu, 2015-03-12 at 18:55 +0800, Kevin Hao wrote: > I know Torsten Duwe has tried to add the ticket spinlock for powerpc > one year ago [1]. But it make no progress due to the conflict between > PPC_SPLPAR and lockref. We still don't find a better way to handle > this. But instead of waiting fore

[RFC] powerpc: use ticket spin lock for !CONFIG_PPC_SPLPAR

2015-03-12 Thread Kevin Hao
I know Torsten Duwe has tried to add the ticket spinlock for powerpc one year ago [1]. But it make no progress due to the conflict between PPC_SPLPAR and lockref. We still don't find a better way to handle this. But instead of waiting forever for a perfect solution, can't we just use the ticket spi