Re: [RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-06-01 Thread Diana Madalina Craciun
On 6/1/2018 1:40 PM, Michael Ellerman wrote: > Scott Wood writes: > >> On Thu, 2018-05-31 at 14:35 +, Diana Madalina Craciun wrote: >>> On 5/31/2018 5:21 PM, Michael Ellerman wrote: We can add a nospectre_v1 command line option if necessary. >>> What about nobarrier_nospec (or similar)

Re: [RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-06-01 Thread Michael Ellerman
Scott Wood writes: > On Thu, 2018-05-31 at 14:35 +, Diana Madalina Craciun wrote: >> On 5/31/2018 5:21 PM, Michael Ellerman wrote: >> > >> > We can add a nospectre_v1 command line option if necessary. >> >> What about nobarrier_nospec (or similar) instead of nospectre_v1 command >> line?

Re: [RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-05-31 Thread Scott Wood
On Thu, 2018-05-31 at 14:35 +, Diana Madalina Craciun wrote: > On 5/31/2018 5:21 PM, Michael Ellerman wrote: > > > > We can add a nospectre_v1 command line option if necessary. > > What about nobarrier_nospec (or similar) instead of nospectre_v1 command > line? We are not disabling all the

Re: [RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-05-31 Thread Diana Madalina Craciun
On 5/31/2018 5:21 PM, Michael Ellerman wrote: > Scott Wood writes: >> On Tue, 2018-05-29 at 15:22 +, Diana Madalina Craciun wrote: >>> On 05/22/2018 11:31 PM, Scott Wood wrote: Should there be a way for the user to choose not to enable this (editing the device tree doesn't

Re: [RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-05-31 Thread Michael Ellerman
Scott Wood writes: > On Tue, 2018-05-29 at 15:22 +, Diana Madalina Craciun wrote: >> On 05/22/2018 11:31 PM, Scott Wood wrote: > >> > Should there be a way for the user to choose not to enable this (editing >> > the >> > device tree doesn't count), for a use case that is not sufficiently >> >

Re: [RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-05-30 Thread Diana Madalina Craciun
On 05/29/2018 10:16 PM, Scott Wood wrote: > On Tue, 2018-05-29 at 15:22 +, Diana Madalina Craciun wrote: >> Hi Scott, >> >> Thanks for the review. >> >> On 05/22/2018 11:31 PM, Scott Wood wrote: >>> On Tue, 2018-05-22 at 10:10 +0300, Diana Craciun wrote: Implement the barrier_nospec as a

Re: [RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-05-29 Thread Scott Wood
On Tue, 2018-05-29 at 15:22 +, Diana Madalina Craciun wrote: > Hi Scott, > > Thanks for the review. > > On 05/22/2018 11:31 PM, Scott Wood wrote: > > On Tue, 2018-05-22 at 10:10 +0300, Diana Craciun wrote: > > > Implement the barrier_nospec as a isync;sync instruction sequence. > > > The

Re: [RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-05-29 Thread Diana Madalina Craciun
Hi Scott, Thanks for the review. On 05/22/2018 11:31 PM, Scott Wood wrote: > On Tue, 2018-05-22 at 10:10 +0300, Diana Craciun wrote: >> Implement the barrier_nospec as a isync;sync instruction sequence. >> The implementation uses the infrastructure built for BOOK3S 64 >> with the difference that

[RESEND RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-05-23 Thread Diana Craciun
Implement the barrier_nospec as a isync;sync instruction sequence. The implementation uses the infrastructure built for BOOK3S 64 with the difference that for NXP platforms there is no firmware involved and the need for a speculation barrier is read from the device tree. I have used the same name

Re: [RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-05-22 Thread Scott Wood
On Tue, 2018-05-22 at 10:10 +0300, Diana Craciun wrote: > Implement the barrier_nospec as a isync;sync instruction sequence. > The implementation uses the infrastructure built for BOOK3S 64 > with the difference that for NXP platforms there is no firmware involved > and the need for a speculation