Re: [RFC PATCH 1/2] powerpc/powernv: Add support for CXL mode switch that need PHB reset

2019-01-28 Thread Vaibhav Jain
Frederic Barrat writes: >> +opal_poll_events(NULL); > > Why is a call to opal_poll_events() needed? Trying to make sure that opal pollers are run on the current CPU and any opal timer are executed. -- Vaibhav Jain Linux Technology Center, IBM India Pvt. Ltd.

Re: [RFC PATCH 1/2] powerpc/powernv: Add support for CXL mode switch that need PHB reset

2019-01-28 Thread Vaibhav Jain
Thanks for reviewing this patch Christophe, christophe lombard writes: >> >> pe = pnv_ioda_get_pe(dev); >> if (!pe) >> -return -ENODEV; >> +return -ENOENT; > > The return code of pnv_phb_to_cxl_mode() is also returned by an api in > the cxllib librarie. So,

Re: [RFC PATCH 1/2] powerpc/powernv: Add support for CXL mode switch that need PHB reset

2019-01-28 Thread christophe lombard
On 25/01/2019 06:11, Vaibhav Jain wrote: Recent updates to OPAL [1] have provided support for new CXL modes on PHB that need to force a cold reset on the bridge (CRESET). However PHB CRESET is a multi step process and cannot be completed synchronously as expected by current kernel implementation

Re: [RFC PATCH 1/2] powerpc/powernv: Add support for CXL mode switch that need PHB reset

2019-01-28 Thread Frederic Barrat
Le 25/01/2019 à 06:11, Vaibhav Jain a écrit : Recent updates to OPAL [1] have provided support for new CXL modes on PHB that need to force a cold reset on the bridge (CRESET). However PHB CRESET is a multi step process and cannot be completed synchronously as expected by current kernel

[RFC PATCH 1/2] powerpc/powernv: Add support for CXL mode switch that need PHB reset

2019-01-24 Thread Vaibhav Jain
Recent updates to OPAL [1] have provided support for new CXL modes on PHB that need to force a cold reset on the bridge (CRESET). However PHB CRESET is a multi step process and cannot be completed synchronously as expected by current kernel implementation that issues opal call