[RFC PATCH v2 3/3] kasan: add interceptors for all string functions

2019-03-28 Thread Christophe Leroy
In the same spirit as commit 393f203f5fd5 ("x86_64: kasan: add interceptors for memset/memmove/memcpy functions"), this patch adds interceptors for string manipulation functions so that we can compile lib/string.o without kasan support hence allow the string functions to also be used from places wh

Re: [RFC PATCH v2 3/3] kasan: add interceptors for all string functions

2019-04-02 Thread Christophe Leroy
Hi Dmitry, Andrey and others, Do you have any comments to this series ? I'd like to know if this approach is ok or if it is better to keep doing as in https://patchwork.ozlabs.org/patch/1055788/ Thanks Christophe Le 28/03/2019 à 16:00, Christophe Leroy a écrit : In the same spirit as commit

Re: [RFC PATCH v2 3/3] kasan: add interceptors for all string functions

2019-04-02 Thread Christophe Leroy
Le 02/04/2019 à 14:58, Dmitry Vyukov a écrit : On Tue, Apr 2, 2019 at 11:43 AM Christophe Leroy wrote: Hi Dmitry, Andrey and others, Do you have any comments to this series ? I'd like to know if this approach is ok or if it is better to keep doing as in https://patchwork.ozlabs.org/patch/

Re: [RFC PATCH v2 3/3] kasan: add interceptors for all string functions

2019-04-02 Thread Andrey Ryabinin
On 4/2/19 12:43 PM, Christophe Leroy wrote: > Hi Dmitry, Andrey and others, > > Do you have any comments to this series ? > I don't see justification for adding all these non-instrumented functions. We need only some subset of these functions and only on powerpc so far. Arches that don't use

Re: [RFC PATCH v2 3/3] kasan: add interceptors for all string functions

2019-04-02 Thread Christophe Leroy
Le 02/04/2019 à 18:14, Andrey Ryabinin a écrit : On 4/2/19 12:43 PM, Christophe Leroy wrote: Hi Dmitry, Andrey and others, Do you have any comments to this series ? I don't see justification for adding all these non-instrumented functions. We need only some subset of these functions an