Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

2009-12-02 Thread Segher Boessenkool
you may want to rename the ug_ prefix, it took me a while looking back and forth through the patch to convince myself it wasn't a typo. What's wrong with ug_ ? (ug = (u)sb(g)ecko) At first look I thought it was a typo of udbg_early_remap. I prefer the longer names although we could use gec

Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

2009-11-30 Thread Richard Holden
On Nov 30, 2009, at 10:23 PM, Albert Herranz wrote: > Richard Holden wrote: >> Albert Herranz wrote: > The first patch is generic, and uses PPC_EARLY_DEBUG. > This is the first patch where PPC_EARLY_DEBUG_USBGECKO is referenced. Sorry, you are correct. >>> diff --git a/arch/powerpc/platforms/em

Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

2009-11-30 Thread Albert Herranz
Michael Ellerman wrote: >>> you may want to rename the ug_ prefix, it took me a while looking back >>> and forth through the patch to convince myself it wasn't a typo. >>> >> What's wrong with ug_ ? (ug = (u)sb(g)ecko) > > What's wrong with usb_gecko_early_remap() :) > Nothing, except that names

Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

2009-11-30 Thread Michael Ellerman
On Tue, 2009-12-01 at 06:23 +0100, Albert Herranz wrote: > Richard Holden wrote: > >> diff --git a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c > >> b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c > >> index ba4c7cc..3f125b6 100644 > >> --- a/arch/powerpc/platforms/embedded6xx/usbgecko_

Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

2009-11-30 Thread Albert Herranz
Richard Holden wrote: > Albert Herranz wrote: >> Add support for using the USB Gecko adapter as an early debugging >> console on the Nintendo GameCube and Wii video game consoles. >> The USB Gecko is a 3rd party memory card interface adapter that provides >> a EXI (External Interface) to USB serial

Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

2009-11-30 Thread Richard Holden
Albert Herranz wrote: > Add support for using the USB Gecko adapter as an early debugging > console on the Nintendo GameCube and Wii video game consoles. > The USB Gecko is a 3rd party memory card interface adapter that provides > a EXI (External Interface) to USB serial converter. > > Signed-off-

[RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

2009-11-30 Thread Albert Herranz
Add support for using the USB Gecko adapter as an early debugging console on the Nintendo GameCube and Wii video game consoles. The USB Gecko is a 3rd party memory card interface adapter that provides a EXI (External Interface) to USB serial converter. Signed-off-by: Albert Herranz --- arch/powe