Re: [bug report] cxl: Add guest-specific code

2016-07-15 Thread Andrew Donnellan
On 15/07/16 07:53, Dan Carpenter wrote: 919 if (afu->crs_len < 0) { Remove this test. Unsigned is never less than zero. Is there another lower bound that we should be checking against here? -- Andrew Donnellan OzLabs, ADL Canberra

[bug report] cxl: Add guest-specific code

2016-07-14 Thread Dan Carpenter
Hello Christophe Lombard, The patch 14baf4d9c739: "cxl: Add guest-specific code" from Mar 4, 2016, leads to the following static checker warning: drivers/misc/cxl/guest.c:1115 cxl_guest_init_adapter() error: we previously assumed 'adapter->guest' could be null (see line 1114) dr