Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-29 Thread David Brownell
On Sunday 29 June 2008, Jean Delvare wrote: > > > After the i2c adapter registers itself, of_register_i2c_devices() is called > > which walks through the child nodes of the i2c adapter node in the device > > tree.  Each child node is an i2c device, and it immediately get > > registered with the ad

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-29 Thread Jean Delvare
On Sun, 29 Jun 2008 12:24:39 -0400, Sean MacLennan wrote: > On Sun, 29 Jun 2008 09:17:25 +0200 > "Jean Delvare" <[EMAIL PROTECTED]> wrote: > > > Ah, OK. If you use i2c_new_device() then it's alright. > > Correct. > > I have done the same thing for the i2c-ibm_iic.c driver. Jean, I think > you wi

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-29 Thread Sean MacLennan
On Sun, 29 Jun 2008 09:17:25 +0200 "Jean Delvare" <[EMAIL PROTECTED]> wrote: > Ah, OK. If you use i2c_new_device() then it's alright. Correct. I have done the same thing for the i2c-ibm_iic.c driver. Jean, I think you will like this. It gets rid of the index and the numbered drivers. And the wal

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-29 Thread Jean Delvare
On Sun, 29 Jun 2008 00:58:12 -0600, Grant Likely wrote: > On Sun, Jun 29, 2008 at 08:31:43AM +0200, Jean Delvare wrote: > > Hi Jon, Grant, > > > > On Sat, 28 Jun 2008 22:49:40 -0600, Grant Likely wrote: > > > On Sat, Jun 28, 2008 at 10:05:28PM -0400, Jon Smirl wrote: > > > > > > > > > > The driver

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-28 Thread Grant Likely
On Sun, Jun 29, 2008 at 08:31:43AM +0200, Jean Delvare wrote: > Hi Jon, Grant, > > On Sat, 28 Jun 2008 22:49:40 -0600, Grant Likely wrote: > > On Sat, Jun 28, 2008 at 10:05:28PM -0400, Jon Smirl wrote: > > > > > > > > The driver was previously using i2c_add_numbered_adapter(), giving MPC > > > >

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-28 Thread Jean Delvare
Hi Jon, Grant, On Sat, 28 Jun 2008 22:49:40 -0600, Grant Likely wrote: > On Sat, Jun 28, 2008 at 10:05:28PM -0400, Jon Smirl wrote: > > On 6/25/08, Jean Delvare <[EMAIL PROTECTED]> wrote: > > > > > > > > i2c->adap = mpc_ops; > > > > - i2c->adap.nr = pdev->id; > > > > i2c_set_ad

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-28 Thread Grant Likely
On Sat, Jun 28, 2008 at 10:05:28PM -0400, Jon Smirl wrote: > On 6/25/08, Jean Delvare <[EMAIL PROTECTED]> wrote: > > > > > > i2c->adap = mpc_ops; > > > - i2c->adap.nr = pdev->id; > > > i2c_set_adapdata(&i2c->adap, i2c); > > > - i2c->adap.dev.parent = &pdev->dev; > > > -

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-28 Thread Jon Smirl
On 6/25/08, Jean Delvare <[EMAIL PROTECTED]> wrote: > > > > i2c->adap = mpc_ops; > > - i2c->adap.nr = pdev->id; > > i2c_set_adapdata(&i2c->adap, i2c); > > - i2c->adap.dev.parent = &pdev->dev; > > - if ((result = i2c_add_numbered_adapter(&i2c->adap)) < 0) { > > + i

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-25 Thread Jean Delvare
Hi Jon, > Convert i2c-mpc from a platform driver into an of_platform driver. > This patch is much smaller since Jochen already added > of_find_i2c_driver(). Versions of this have been posted before. > > Signed-ff-by: Jon Smirl <[EMAIL PROTECTED]> > > -- This separator is supposed to be 3 dashe

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-25 Thread Jean Delvare
Hi Jon, On Wed, 11 Jun 2008 12:14:08 -0400, Jon Smirl wrote: > On 6/11/08, Wolfram Sang <[EMAIL PROTECTED]> wrote: > > On Tue, Jun 10, 2008 at 10:40:45PM -0400, Jon Smirl wrote: > > > Convert i2c-mpc from a platform driver into an of_platform driver. > > > This patch is much smaller since Jochen

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-11 Thread Jon Smirl
On 6/11/08, Wolfram Sang <[EMAIL PROTECTED]> wrote: > On Tue, Jun 10, 2008 at 10:40:45PM -0400, Jon Smirl wrote: > > Convert i2c-mpc from a platform driver into an of_platform driver. > > This patch is much smaller since Jochen already added > > of_find_i2c_driver(). Versions of this have been p

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-11 Thread Wolfram Sang
On Tue, Jun 10, 2008 at 10:40:45PM -0400, Jon Smirl wrote: > Convert i2c-mpc from a platform driver into an of_platform driver. > This patch is much smaller since Jochen already added > of_find_i2c_driver(). Versions of this have been posted before. > > Signed-ff-by: Jon Smirl <[EMAIL PROTECTED]>