Any final objections to this patch? When these were changed to 0
instead of NO_IRQ it should have broken polling mode on ppc. ppc would
treat polling mode, NO_IRQ=-1, as an error.
On powerpc this change is a NOP since NO_IRQ=0.
On 1/21/08, Jon Smirl <[EMAIL PROTECTED]> wrote:
> Alter the mpc i2c
On 1/24/08, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> On Thu, 2008-01-24 at 17:32 -0500, Jon Smirl wrote:
> > Ben, do you approve of this? How should error be checked for, is
> > > because of these checks, the ppc build is wrong and powerpc polled
> > mode doesn't work.
>
> == 0 shoul
On Thu, 2008-01-24 at 17:32 -0500, Jon Smirl wrote:
> Ben, do you approve of this? How should error be checked for, is
> because of these checks, the ppc build is wrong and powerpc polled
> mode doesn't work.
== 0 should work on powerpc since NO_IRQ is defined to be 0 there no ?
Anyway, using
Ben, do you approve of this? How should error be checked for, is
wrote:
> Alter the mpc i2c driver to use the NO_IRQ symbol instead of the constant
> zero when checking for valid interrupts. NO_IRQ=-1 on ppc and NO_IRQ=0 on
> powerpc so the checks against zero are not correct.
>
> Signed-off-by:
