Re: [kvm-ppc-devel] [PATCH] Add idle power save for ppc 4xx

2008-04-01 Thread Josh Boyer
On Tue, 2008-04-01 at 08:01 -0400, Jimi Xenidis wrote: On Mar 31, 2008, at 11:15 PM, Josh Boyer wrote: On Tue, 2008-04-01 at 12:04 +1100, Michael Ellerman wrote: I'm assuming you pass a dtb to the virtual guest when you start it up. Could you define a property in the CPU node there

Re: [kvm-ppc-devel] [PATCH] Add idle power save for ppc 4xx

2008-04-01 Thread Arnd Bergmann
On Monday 31 March 2008, Jerone Young wrote: +{ +   unsigned long msr_save; + +   /* set wait state MSR */ +   local_irq_enable(); +   msr_save = mfmsr(); +   mtmsr(msr_save|MSR_WE); Why don't you |MSR_WE|MSR_EE at the same time? You technically can do this. But the

Re: [kvm-ppc-devel] [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Hollis Blanchard
On Mon, 2008-03-31 at 08:12 -0500, Jerone Young wrote: # HG changeset patch # User Jerone Young [EMAIL PROTECTED] # Date 1206969060 18000 # Node ID 10aea37177130bbe5de7bee6ec06d9010bc5da1f # Parent 1506aa38ddabb0bf73fff3ac3f3db5f9ef6458cc Add idle power save for ppc 4xx This patch sets

Re: [kvm-ppc-devel] [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Jerone Young
On Mon, 2008-03-31 at 11:27 -0500, Hollis Blanchard wrote: On Mon, 2008-03-31 at 08:12 -0500, Jerone Young wrote: # HG changeset patch # User Jerone Young [EMAIL PROTECTED] # Date 1206969060 18000 # Node ID 10aea37177130bbe5de7bee6ec06d9010bc5da1f # Parent

Re: [kvm-ppc-devel] [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Josh Boyer
On Mon, 31 Mar 2008 11:52:02 -0500 Jerone Young [EMAIL PROTECTED] wrote: void ppc4xx_idle(void) +{ + unsigned long msr_save; + + /* set wait state MSR */ + local_irq_enable(); + msr_save = mfmsr(); + mtmsr(msr_save|MSR_WE); Why don't you |MSR_WE|MSR_EE at the same