Re: [v1 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-02 Thread Ben Hutchings
On Thu, 2010-09-02 at 08:50 +0800, Liang Li wrote: On Wed, Sep 01, 2010 at 02:42:30PM +0100, Ben Hutchings wrote: On Wed, 2010-09-01 at 09:43 +0800, Liang Li wrote: It's common sense that when we should do change to driver ring desc/buffer etc only after 'stop/shutdown' the device. When

Re: [v1 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-02 Thread Liang Li
On Thu, Sep 02, 2010 at 12:11:47PM +0100, Ben Hutchings wrote: On Thu, 2010-09-02 at 08:50 +0800, Liang Li wrote: On Wed, Sep 01, 2010 at 02:42:30PM +0100, Ben Hutchings wrote: On Wed, 2010-09-01 at 09:43 +0800, Liang Li wrote: It's common sense that when we should do change to driver

Re: [v1 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-02 Thread Ben Hutchings
On Thu, 2010-09-02 at 23:48 +0800, Liang Li wrote: On Thu, Sep 02, 2010 at 12:11:47PM +0100, Ben Hutchings wrote: On Thu, 2010-09-02 at 08:50 +0800, Liang Li wrote: On Wed, Sep 01, 2010 at 02:42:30PM +0100, Ben Hutchings wrote: On Wed, 2010-09-01 at 09:43 +0800, Liang Li wrote: It's

Re: [v1 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-01 Thread Ben Hutchings
On Wed, 2010-09-01 at 09:43 +0800, Liang Li wrote: It's common sense that when we should do change to driver ring desc/buffer etc only after 'stop/shutdown' the device. When we do change while devices/driver is running, kernel oops occur: [...] - ug_info-bdRingLenRx[queue] =

Re: [v1 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-01 Thread Liang Li
On Wed, Sep 01, 2010 at 02:42:30PM +0100, Ben Hutchings wrote: On Wed, 2010-09-01 at 09:43 +0800, Liang Li wrote: It's common sense that when we should do change to driver ring desc/buffer etc only after 'stop/shutdown' the device. When we do change while devices/driver is running, kernel

[v1 PATCH] ucc_geth: fix ethtool set ring param bug

2010-08-31 Thread Liang Li
It's common sense that when we should do change to driver ring desc/buffer etc only after 'stop/shutdown' the device. When we do change while devices/driver is running, kernel oops occur: [ r...@fsl_8569mds:/root ethtool -G eth0 tx 256 r...@fsl_8569mds:/root Oops: Kernel access of bad area, sig: