Re: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-08-31 Thread tiejun.chen
Benjamin Herrenschmidt wrote: As I understand it, the problem comes from the fact that stwu combines the creation of a stack frame with storing into that stack frame. If they were Yes. separate instructions you'd have a new exception frame at a lower address by the time you actually store

Re: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-08-31 Thread Benjamin Herrenschmidt
On Wed, 2011-08-31 at 17:17 +0800, tiejun.chen wrote: It sounds hackish but it makes it easier to fix everybody at once, there are issues with changing stacks especially on ppc64 and it would definitely be affected as well if the stack frame created is larger than our gap. If we

Re: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-08-29 Thread Benjamin Herrenschmidt
As I understand it, the problem comes from the fact that stwu combines the creation of a stack frame with storing into that stack frame. If they were Yes. separate instructions you'd have a new exception frame at a lower address by the time you actually store to the non-exception

Re: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-07-21 Thread tiejun.chen
tiejun.chen wrote: Kumar Gala wrote: On Jul 11, 2011, at 6:31 AM, Tiejun Chen wrote: When kprobe these operations such as store-and-update-word for SP(r1), stwu r1, -A(r1) The program exception is triggered, and PPC always allocate an exception frame as shown as the follows: old r1

Re: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-07-19 Thread tiejun.chen
PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack On Fri, 15 Jul 2011 13:28:15 +0800 tiejun.chen tiejun.c...@windriver.com wrote: Kumar Gala wrote: I'm still very confused why we need a unique stack frame for kprobe/program exceptions on book-e devices

Re: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-07-18 Thread Scott Wood
] booke/kprobe: make program exception to use one dedicated exception stack On Fri, 15 Jul 2011 13:28:15 +0800 tiejun.chen tiejun.c...@windriver.com wrote: Kumar Gala wrote: I'm still very confused why we need a unique stack frame for kprobe/program exceptions on book-e devices

Re: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-07-15 Thread Scott Wood
On Fri, 15 Jul 2011 13:28:15 +0800 tiejun.chen tiejun.c...@windriver.com wrote: Kumar Gala wrote: I'm still very confused why we need a unique stack frame for kprobe/program exceptions on book-e devices. Its a bug at least for Book-E. But why only booke? There's nothing booke-specific

RE: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-07-15 Thread Chen, Tiejun
-Original Message- From: Scott Wood [mailto:scottw...@freescale.com] Sent: Saturday, July 16, 2011 2:43 AM To: Chen, Tiejun Cc: Kumar Gala; linuxppc-...@ozlabs.org Subject: Re: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack On Fri, 15

Re: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-07-14 Thread Kumar Gala
On Jul 11, 2011, at 6:31 AM, Tiejun Chen wrote: When kprobe these operations such as store-and-update-word for SP(r1), stwu r1, -A(r1) The program exception is triggered, and PPC always allocate an exception frame as shown as the follows: old r1 -- ... nip

Re: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-07-14 Thread Scott Wood
On Thu, 14 Jul 2011 08:27:44 -0500 Kumar Gala ga...@kernel.crashing.org wrote: On Jul 11, 2011, at 6:31 AM, Tiejun Chen wrote: When kprobe these operations such as store-and-update-word for SP(r1), stwu r1, -A(r1) The program exception is triggered, and PPC always allocate an

Re: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-07-14 Thread tiejun.chen
Kumar Gala wrote: On Jul 11, 2011, at 6:31 AM, Tiejun Chen wrote: When kprobe these operations such as store-and-update-word for SP(r1), stwu r1, -A(r1) The program exception is triggered, and PPC always allocate an exception frame as shown as the follows: old r1 --

[v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-07-11 Thread Tiejun Chen
When kprobe these operations such as store-and-update-word for SP(r1), stwu r1, -A(r1) The program exception is triggered, and PPC always allocate an exception frame as shown as the follows: old r1 -- ... nip gpr[2] ~ gpr[31] gpr[1] - old r1

Re: [v3 PATCH 1/1] booke/kprobe: make program exception to use one dedicated exception stack

2011-07-11 Thread tiejun.chen
Tiejun Chen wrote: When kprobe these operations such as store-and-update-word for SP(r1), stwu r1, -A(r1) The program exception is triggered, and PPC always allocate an exception frame as shown as the follows: old r1 -- ... nip gpr[2] ~ gpr[31]