[v4] clk: qoriq: Add support for the FMan clock

2015-04-16 Thread Igal . Liberman
From: Igal Liberman This patch depends on the following patches: https://patchwork.ozlabs.org/patch/461151/ https://patchwork.ozlabs.org/patch/461155/ This patche is described by the following binding document update: https://patchwork.ozlabs.org/patch/461166/ v4: -

Re: [v4] clk: qoriq: Add support for the FMan clock

2015-05-06 Thread Stephen Boyd
On 04/16, Igal.Liberman wrote: > From: Igal Liberman > > This patch depends on the following patches: > https://patchwork.ozlabs.org/patch/461151/ > https://patchwork.ozlabs.org/patch/461155/ > > This patche is described by the following binding document update: > https://patch

Re: [v4] clk: qoriq: Add support for the FMan clock

2015-05-06 Thread Scott Wood
On Wed, 2015-05-06 at 00:02 -0700, Stephen Boyd wrote: > On 04/16, Igal.Liberman wrote: > > +static int get_fm_clk_idx(int fm_id, int *fm_clk_idx) > > +{ > > + struct ccsr_guts __iomem *guts_regs = NULL; > > Unnecessary initialization to NULL. Also, marking a structure as > __iomem is odd. Why d

Re: [v4] clk: qoriq: Add support for the FMan clock

2015-05-06 Thread Stephen Boyd
On 05/06, Scott Wood wrote: > On Wed, 2015-05-06 at 00:02 -0700, Stephen Boyd wrote: > > On 04/16, Igal.Liberman wrote: > > > +static int get_fm_clk_idx(int fm_id, int *fm_clk_idx) > > > +{ > > > + struct ccsr_guts __iomem *guts_regs = NULL; > > > > Unnecessary initialization to NULL. Also, markin

Re: [v4] clk: qoriq: Add support for the FMan clock

2015-05-06 Thread Scott Wood
On Wed, 2015-05-06 at 15:25 -0700, Stephen Boyd wrote: > On 05/06, Scott Wood wrote: > > On Wed, 2015-05-06 at 00:02 -0700, Stephen Boyd wrote: > > > On 04/16, Igal.Liberman wrote: > > > > +static int get_fm_clk_idx(int fm_id, int *fm_clk_idx) > > > > +{ > > > > + struct ccsr_guts __iomem *gu