On Tuesday 01 December 2009 09:00:34 Tejun Heo wrote:
(cc'ing Holger Macht, please read the comment below pata_macio_mb_event())
Hello,
On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks
On Tue, 2009-12-01 at 21:43 +0100, Andreas Schwab wrote:
Benjamin Herrenschmidt b...@kernel.crashing.org writes:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
Tried it on my iBook G4
On Tue, 2009-12-01 at 21:43 +0100, Andreas Schwab wrote:
Benjamin Herrenschmidt b...@kernel.crashing.org writes:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
Tried it on my iBook G4
On Tue, 2009-12-01 at 17:00 +0900, Tejun Heo wrote:
+#define IDE_WAKEUP_DELAY (1*HZ)
nitpick: In libata, it's common to use msecs for timing values so that
might be a better option.
Yeah, that's cruft lifted from the old driver, I'll fix it.
+static const struct pata_macio_timing
Hello,
On 12/02/2009 08:19 AM, Benjamin Herrenschmidt wrote:
I think you'll need an ata_port_freeze() or abort() here because at
this point the drive is already gone and all in-flight commands need
to be failed right away. Holger, do you remember why
ata_acpi_detach_device() is using
On Wed, 2009-12-02 at 08:27 +0900, Tejun Heo wrote:
Conceptually freeze would be more approriate but the side effect is
that the port is frozen and EH will try to thaw it by resetting it.
So, abort would work better.
BTW. For a plug event, what should I do ? freeze is fine ? Or just
schedule
On 12/02/2009 08:35 AM, Benjamin Herrenschmidt wrote:
On Wed, 2009-12-02 at 08:27 +0900, Tejun Heo wrote:
Conceptually freeze would be more approriate but the side effect is
that the port is frozen and EH will try to thaw it by resetting it.
So, abort would work better.
BTW. For a plug
On Wed, 2009-12-02 at 08:44 +0900, Tejun Heo wrote:
BTW. For a plug event, what should I do ? freeze is fine ? Or just
schedule eh ? Right now, when plugging I see an exception Emask 0x10
etc... message in the log when plugging which isn't totally nice :-)
freeze() and please don't fight
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
It supports all the features of its predecessor, including mediabay hotplug
and suspend/resume. It should also support module load/unload
On 12/02/2009 09:36 AM, Benjamin Herrenschmidt wrote:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
It supports all the features of its predecessor, including mediabay hotplug
and suspend
On Wed, 2009-12-02 at 10:07 +0900, Tejun Heo wrote:
On 12/02/2009 09:36 AM, Benjamin Herrenschmidt wrote:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
It supports all the features
Hello,
On 12/02/2009 10:51 AM, Benjamin Herrenschmidt wrote:
I'm not sure what media bay locking problem you mentioned tho...
The way the driver does the locking now is that I block the media-bay
thread (lock/unlock_media_bay calls) around initial registration and
driver removal which
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
It supports all the features of its predecessor, including mediabay hotplug
and suspend/resume. It should also support module load/unload
a whole lot of help from the list, since that kernel is pretty ancient.
I can only acknowledge that, but we're stuck to that kernel for now...
kernel configuration, we triggered an oops when probing for IDE devices (to
read out the first 512 bytes of the CF). I can see that the ioremap64 call
On Tue, 2009-09-15 at 10:57 +0200, Ludo Van Put wrote:
Thnx for the suggestion, but the ide_insw is in fact of copy of the
_insw assembly routine, and it gets passed
the effective address, without the _IO_BASE offset.
I was thinking about TLB stuff. I'm not a u-boot expert, but could it
be
triggered an oops when probing for IDE devices (to
read out the first 512 bytes of the CF). I can see that the ioremap64 call
in the driver code for our CF returns a different address (compared to PCI
disabled in strapping), but using this address later on for accessing the CF
goes wrong.
Does someone
in the strapping and in the (patched 2.6.10)
2.6.10? Really? If that is truly the case, you probably aren't going to get
a whole lot of help from the list, since that kernel is pretty ancient.
kernel configuration, we triggered an oops when probing for IDE devices (to
read out the first 512 bytes of the CF
for now...
kernel configuration, we triggered an oops when probing for IDE devices (to
read out the first 512 bytes of the CF). I can see that the ioremap64 call
in the driver code for our CF returns a different address (compared to PCI
disabled in strapping), but using this address later
ancient.
I can only acknowledge that, but we're stuck to that kernel for now...
kernel configuration, we triggered an oops when probing for IDE devices (to
read out the first 512 bytes of the CF). I can see that the ioremap64 call
in the driver code for our CF returns a different address
On Wed, 08 Jul 2009 11:12:42 +1000
Benjamin Herrenschmidt b...@kernel.crashing.org wrote:
On Wed, 2009-07-08 at 01:18 +0400, Andrey Gusev wrote:
I tried this drive on ide1 and ide2, there are same issue. This
drive worked on P-III before (as separate on channel, with another
hard drive
to virtual irq 21
[1.589335] irq: irq 7 on host
/p...@f200/mac...@17/interrupt-control...@4 mapped to virtual irq 24
[1.589370] irq: irq 8 on host
/p...@f200/mac...@17/interrupt-control...@4 mapped to virtual irq 29
[1.591439] Uniform Multi-Platform E-IDE driver
On Wed, 2009-07-08 at 01:18 +0400, Andrey Gusev wrote:
I tried this drive on ide1 and ide2, there are same issue. This drive worked
on P-III before (as separate on channel, with another hard drive and with
cdrom)
and I didn't have any problem with it. There are chunks of dmesg.
Wow... It
[1.599264] irq: irq 7 on host
/p...@f200/mac...@17/interrupt-control...@4 mapped to virtual irq 24
[1.599300] irq: irq 8 on host
/p...@f200/mac...@17/interrupt-control...@4 mapped to virtual irq 29
[1.601336] Uniform Multi-Platform E-IDE driver
[1.602201] ide
...@4 mapped to virtual irq 24
[1.599300] irq: irq 8 on host
/p...@f200/mac...@17/interrupt-control...@4 mapped to virtual irq 29
[1.601336] Uniform Multi-Platform E-IDE driver
[1.602201] ide-pmac 0002:20:0d.0: enabling device ( - 0002)
[2.630651] ide-pmac: Found Apple
Hello,
I am running on an MPC8360 board with u-boot-2009.06 and linux-2.6.26-13.
The board is booting from nor flash and then u-boot configures UPM-A for
compact flash in true-IDE mode
(based on the design of the MPC8349ITX eval board). The IRQ used is IRQ6.
I got this setup going fine
=y
#
# Please see Documentation/ide/ide.txt for help/info on IDE drives
#
CONFIG_IDE_XFER_MODE=y
CONFIG_IDE_TIMINGS=y
CONFIG_IDE_ATAPI=y
# CONFIG_BLK_DEV_IDE_SATA is not set
CONFIG_IDE_GD=y
CONFIG_IDE_GD_ATA=y
# CONFIG_IDE_GD_ATAPI is not set
CONFIG_BLK_DEV_IDECD=m
On Tuesday 09 June 2009 01:26:27 Benjamin Herrenschmidt wrote:
On Mon, 2009-06-08 at 22:20 +0200, Bartlomiej Zolnierkiewicz wrote:
[ 70.584122] hdb:3ide-pmac lost interrupt, dma status: 8480
DMA status indicates that DMA transfer is still active according to
the controller. This
of fixes helped.. :/
[ 70.287747] sysfs: cannot create duplicate filename
'/class/ide_port/ide1' [ 70.287841] [ cut
here ] [ 70.287879] Badness at fs/sysfs/dir.c:487
This is caused by small mistake in one of fixes, follow-up fixup:
diff -u b/drivers/ide/ide
On Thu, 2009-06-11 at 00:38 +0400, Andrey Gusev wrote:
I try this small fix, traces in disappeared, but lost interrupts on the
place:)
Some interesting thing from dmesg:
[0.435806] irq: irq 251 on host
/p...@f200/mac...@17/interrupt-control...@4 mapped to virtual irq 251
[
On Thu, 11 Jun 2009 07:46:17 +1000
Benjamin Herrenschmidt b...@kernel.crashing.org wrote:
On Thu, 2009-06-11 at 00:38 +0400, Andrey Gusev wrote:
I try this small fix, traces in disappeared, but lost interrupts on
the place:) Some interesting thing from dmesg:
[0.435806] irq: irq
On Thu, 2009-06-11 at 01:57 +0400, Andrey Gusev wrote:
I wrote about time, why it have such values on second CPU? Sorry, if this
message is silly.
Oh that's just because it hasn't synchronized the timebases yet when
it prints those messages.
Cheers,
Ben.
I found configuration, where
:
Hello!
I have tested linux-2.6.30-rc3 on my system and find
some problems. One of them is delaying on
initialization IDE subsystem. I don't have this
problem on 2.6.29.1. The difference is looked on
log of dmesg
On Mon, 2009-06-08 at 22:20 +0200, Bartlomiej Zolnierkiewicz wrote:
[ 70.584122] hdb:3ide-pmac lost interrupt, dma status: 8480
DMA status indicates that DMA transfer is still active according to
the controller. This one is really a platform/hardware specific issue.
I've partially
system and find
some problems. One of them is delaying on
initialization IDE subsystem. I don't have this
problem on 2.6.29.1. The difference is looked on
log of dmesg.
Unfortunately this doesn't give us any hint about the
root
...@gmail.com wrote:
Hi,
On Saturday 25 April 2009 15:02:03 Andrey Gusev wrote:
Hello!
I have tested linux-2.6.30-rc3 on my system and find
some problems. One of them is delaying on
initialization IDE subsystem. I
-rc3 on my system and find some
problems. One of them is delaying on initialization IDE
subsystem. I don't have this problem on 2.6.29.1. The
difference is looked on log of dmesg.
Unfortunately this doesn't give us any hint about the root
cause of the bug so
On Tuesday 14 April 2009 20:29:19 Subrata Modak wrote:
Observed the following build error:
---
CC [M] drivers/ide/pmac.o
drivers/ide/pmac.c: In function ‘pmac_ide_init_dev’:
drivers/ide/pmac.c:955: error: implicit declaration of function
‘check_media_bay_by_base’
drivers/ide/pmac.c
Observed the following build error:
---
CC [M] drivers/ide/pmac.o
drivers/ide/pmac.c: In function ‘pmac_ide_init_dev’:
drivers/ide/pmac.c:955: error: implicit declaration of function
‘check_media_bay_by_base’
drivers/ide/pmac.c: In function ‘pmac_ide_setup_device’:
drivers/ide/pmac.c:1090: error
On Tue, Apr 14, 2009 at 11:59:19PM +0530, Subrata Modak wrote:
Observed the following build error:
snip
I have no objection on being cc:ed on errors that have something to do
with stuff I maintain, but on areas I don't maintain, it just ends up as
noise in my already-overflowing inbox...
On Tuesday 31 March 2009, KOBAYASHI Yoshitake wrote:
2009/03/31 16:51, Geert Uytterhoeven wrote:
On Mon, 30 Mar 2009, Grant Grundler wrote:
Followup to [PATCH 03/10] ide: destroy DMA mappings after ending DMA
email on March 14th:
http://lkml.org/lkml/2009/3/14/17
No maintainer
On Mon, 30 Mar 2009, Grant Grundler wrote:
Followup to [PATCH 03/10] ide: destroy DMA mappings after ending DMA
email on March 14th:
http://lkml.org/lkml/2009/3/14/17
No maintainer is listed for Toshiba CELL Reference Set IDE (BLK_DEV_CELLEB)
or tx4939ide.c in MAINTAINERS. I've CC'd
2009/03/31 16:51, Geert Uytterhoeven wrote:
On Mon, 30 Mar 2009, Grant Grundler wrote:
Followup to [PATCH 03/10] ide: destroy DMA mappings after ending DMA
email on March 14th:
http://lkml.org/lkml/2009/3/14/17
No maintainer is listed for Toshiba CELL Reference Set IDE (BLK_DEV_CELLEB
On Tue, 31 Mar 2009 09:51:53 +0200 (CEST), Geert Uytterhoeven
geert.uytterhoe...@sonycom.com wrote:
Followup to [PATCH 03/10] ide: destroy DMA mappings after ending DMA
email on March 14th:
http://lkml.org/lkml/2009/3/14/17
No maintainer is listed for Toshiba CELL Reference Set IDE
Followup to [PATCH 03/10] ide: destroy DMA mappings after ending DMA
email on March 14th:
http://lkml.org/lkml/2009/3/14/17
No maintainer is listed for Toshiba CELL Reference Set IDE (BLK_DEV_CELLEB)
or tx4939ide.c in MAINTAINERS. I've CC'd Ishizaki Kou @Toshiba (Maintainer for
Spidernet
On Thu, 2009-03-19 at 22:30 +0900, TOMARI Hisanobu wrote:
Thanks for helpful advices.
This patch adds an option to drivers/ide/Kconfig and adds
some lines to drivers/ide/pmac.c . Now the driver checks
if the model is prefixed with PowerBook and the entire hack
can be toggled in the Kconfig
case it should be a generic kernel parameter, i.e.
ide_core.ignore_cables and iff the current ide_core.ignore_cable=
is not enough. TOMARI, could please look into it?
Thanks,
Bart
It works!
As the internal IDE controller is detected as ide0, I passed
ide_core.ignore_cable=0 to the kernel
wrote:
Hello,
I'm using an OCZ PATA SSD on Apple PowerBook5,4 computer.
The IDE drive fails to recognize 80-conductor cable that
connects the drive to motherboard to fall back to UDMA33.
This patch fixes this behavior by assuming that the cable is
short-40pin when the model
an OCZ PATA SSD on Apple PowerBook5,4 computer.
The IDE drive fails to recognize 80-conductor cable that
connects the drive to motherboard to fall back to UDMA33.
This patch fixes this behavior by assuming that the cable is
short-40pin when the model string matches PowerBook5
Thanks for helpful advices.
This patch adds an option to drivers/ide/Kconfig and adds
some lines to drivers/ide/pmac.c . Now the driver checks
if the model is prefixed with PowerBook and the entire hack
can be toggled in the Kconfig.
Again, the patch is against linux 2.6.28.8.
Best regards
On Thu, Mar 19, 2009 at 10:30:01PM +0900, TOMARI Hisanobu wrote:
Thanks for helpful advices.
This patch adds an option to drivers/ide/Kconfig and adds
some lines to drivers/ide/pmac.c .
I think it would be better to make it a kernel command line option
instead of Kconfig knob.
The reason
is, and in fact, It used to work, I think the test in
the IDE code is new there, and MacOS X solely relies on the firmware
data.
Ben.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
On Wed, 2009-03-18 at 14:06 +0900, TOMARI Hisanobu wrote:
Hello,
I'm using an OCZ PATA SSD on Apple PowerBook5,4 computer.
The IDE drive fails to recognize 80-conductor cable that
connects the drive to motherboard to fall back to UDMA33.
This patch fixes this behavior by assuming
...@kernel.crashing.org wrote:
On Wed, 2009-03-18 at 14:06 +0900, TOMARI Hisanobu wrote:
Hello,
I'm using an OCZ PATA SSD on Apple PowerBook5,4 computer.
The IDE drive fails to recognize 80-conductor cable that
connects the drive to motherboard to fall back to UDMA33.
This patch fixes
Hello,
I'm using an OCZ PATA SSD on Apple PowerBook5,4 computer.
The IDE drive fails to recognize 80-conductor cable that
connects the drive to motherboard to fall back to UDMA33.
This patch fixes this behavior by assuming that the cable is
short-40pin when the model string matches PowerBook5
...@secretlab.ca
Betreff: Re: [PATCH 5/5] ide: Force VIA IDE legacy interrupts for AmigaOne
boards
The following patchset fixes core IDE PCI code to always use
pci_get_legacy_ide_irq() and ide_pci_is_in_compatibility_mode():
http://lkml.org/lkml/2009/1/19/163
so via82cxxx specific solution
...@secretlab.ca, linuxppc-dev@ozlabs.org,
linux-...@vger.kernel.org
Betreff: Re: [PATCH 5/5] ide: Force VIA IDE legacy interrupts for AmigaOne
boards
Yes, it can wait.
Although I would like to know from the powerpc maintainer, if my
platform patches could still go in 2.6.29, if I
,
linux-...@vger.kernel.org
Betreff: Re: [PATCH 5/5] ide: Force VIA IDE legacy interrupts for AmigaOne
boards
On Wednesday 07 January 2009, Gerhard Pircher wrote:
Original-Nachricht
Datum: Wed, 7 Jan 2009 08:13:06 -0700
Von: Grant Likely grant.lik
Original-Nachricht
Datum: Mon, 12 Jan 2009 18:55:55 +0100
Von: Bartlomiej Zolnierkiewicz bzoln...@gmail.com
An: Gerhard Pircher gerhard_pirc...@gmx.net
CC: linux-...@vger.kernel.org, linuxppc-dev@ozlabs.org,
grant.lik...@secretlab.ca
Betreff: Re: [PATCH 5/5] ide: Force
Yes, it can wait.
Although I would like to know from the powerpc maintainer, if my platform
patches could still go in 2.6.29, if I resend them in the next days? I guess
it's
too late, right?
Yes it is. I'll put them in -next after -rc2 or later, when we are happy
with them. That gives us a
/5] ide: Force VIA IDE legacy interrupts for AmigaOne
boards
On Wed, Jan 7, 2009 at 7:12 AM, Gerhard Pircher gerhard_pirc...@gmx.net
wrote:
The AmigaOne uses the onboard VIA IDE controller in legacy mode (like
the
Pegasos).
Signed-off-by: Gerhard Pircher gerhard_pirc
] ide: Force VIA IDE legacy interrupts for AmigaOne
boards
On Wednesday 07 January 2009, Gerhard Pircher wrote:
Original-Nachricht
Datum: Wed, 7 Jan 2009 08:13:06 -0700
Von: Grant Likely grant.lik...@secretlab.ca
An: Gerhard Pircher gerhard_pirc...@gmx.net
CC
On Wed, Jan 7, 2009 at 7:12 AM, Gerhard Pircher gerhard_pirc...@gmx.net wrote:
The AmigaOne uses the onboard VIA IDE controller in legacy mode (like the
Pegasos).
Signed-off-by: Gerhard Pircher gerhard_pirc...@gmx.net
---
drivers/ide/via82cxxx.c |5 +
1 files changed, 5 insertions
Original-Nachricht
Datum: Wed, 7 Jan 2009 08:13:06 -0700
Von: Grant Likely grant.lik...@secretlab.ca
An: Gerhard Pircher gerhard_pirc...@gmx.net
CC: linuxppc-dev@ozlabs.org, bzoln...@gmail.com
Betreff: Re: [PATCH 5/5] ide: Force VIA IDE legacy interrupts for AmigaOne
On Dec 4, 2008, at 3:34 PM, Kumar Gala wrote:
From: Jason Jin jason@freescale.com
The general pci resume code can only restore part of the
configuration registers. We need to reconfigure those
registers in the FIXUP_RESUME.
Signed-off-by: Jason Jin jason@freescale.com
Signed-off-by:
From: Jason Jin [EMAIL PROTECTED]
The general pci resume code can only restore part of the
configuration registers. We need to reconfigure those
registers in the FIXUP_RESUME.
Signed-off-by: Jason Jin [EMAIL PROTECTED]
Signed-off-by: Kumar Gala [EMAIL PROTECTED]
---
Where can I find a pata_of_platform node example ?
Sergei Shtylyov a écrit :
Arnd Bergmann wrote:
Most probably you can use the existing platform drivers:
drivers/ide/egacy/ide_platform.c or drivers/ata/pata_platform.c.
Create/register a platform device named pata_platform with 2
memory
/ide/egacy/ide_platform.c or drivers/ata/pata_platform.c.
Create/register a platform device named pata_platform with 2 memory
and 1 IRQ resource, and enable one of those drivers.
For new boards using a flattened device tree, it should be enough
to add a device node for the pata_of_platform
Hello.
Sébastien Chrétien wrote:
I saw pata_of_platform source. And when is called pata_of_platform_probe ?
Look at the very end of arch/powerpc/boot/dts/mpc8349emitx.dts;
probably there are more examples in that directory...
MBR, Sergei
___
Hello
I would like to setup my IDE controller. It uses a generic mapping. And he
is located at the adress 0x20003000.
How can I specifie this adress to the ide driver ?
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman
Hello.
Sébastien Chrétien wrote:
I would like to setup my IDE controller. It uses a generic mapping.
And he is located at the adress 0x20003000.
What kin of controller, and what do you mean by generic mapping?
How can I specifie this adress to the ide driver ?
The usual ways is via
Have I to rewrite a IDE driver ?
2008/9/10, Sergei Shtylyov [EMAIL PROTECTED]:
Hello.
Sébastien Chrétien wrote:
I would like to setup my IDE controller. It uses a generic mapping. And he
is located at the adress 0x20003000.
What kin of controller, and what do you mean by generic
It is a common ide controller :
offset 0x0 Data
offset 0x1 error
offset 0x2 Sector count
offset 0x3 sector No
offset 0x4 Cylinder low
offset 0x5 Cylinder High
offset 0x6 Head
offset 0x7 status
2008/9/10, Sergei Shtylyov [EMAIL PROTECTED]:
Hello.
Sébastien Chrétien wrote:
I would like
Hello.
Sébastien Chrétien wrote:
Have I to rewrite a IDE driver ?
Most probably you can use the existing platform drivers:
drivers/ide/egacy/ide_platform.c or drivers/ata/pata_platform.c.
Create/register a platform device named pata_platform with 2 memory
and 1 IRQ resource, and enable
On Wednesday 10 September 2008, Sergei Shtylyov wrote:
Most probably you can use the existing platform drivers:
drivers/ide/egacy/ide_platform.c or drivers/ata/pata_platform.c.
Create/register a platform device named pata_platform with 2 memory
and 1 IRQ resource, and enable one of those
I looked falconide.c, it uses hw_regs_t hw; and ide_hwif_t *hwif.
Is it a good way ?
2008/9/10, Arnd Bergmann [EMAIL PROTECTED]:
On Wednesday 10 September 2008, Sergei Shtylyov wrote:
Most probably you can use the existing platform drivers:
drivers/ide/egacy/ide_platform.c or drivers
On Wednesday 10 September 2008, Sébastien Chrétien wrote:
I looked falconide.c, it uses hw_regs_t hw; and ide_hwif_t *hwif.
Is it a good way ?
No, that uses the legacy IDE drivers, not the current ATA drivers,
and it is not based on the device tree information.
Just use drivers/ata
Arnd Bergmann wrote:
Most probably you can use the existing platform drivers:
drivers/ide/egacy/ide_platform.c or drivers/ata/pata_platform.c.
Create/register a platform device named pata_platform with 2 memory
and 1 IRQ resource, and enable one of those drivers.
For new boards using
ok I will use the flat device tree.
Do you utils in order to use ata and check ata link ?
For example, to read some information of my compact flash
2008/9/10, Sergei Shtylyov [EMAIL PROTECTED]:
Arnd Bergmann wrote:
Most probably you can use the existing platform drivers:
drivers/ide/egacy
\
*/ \
{ \
{ _IRQ1, _IRQ1, _IRQ1, _IRQ1 }, /* IDSEL 11 = IDE disk
*/ \
{ 0, 0, 0, 0 }, /* IDSEL 12
*/ \
{ _IRQ2, _IRQ2, _IRQ2, _IRQ2 }, /* IDSEL 13 = USB controller
On Thursday 31 July 2008, Bartlomiej Zolnierkiewicz wrote:
[...]
Sorry if my mails were a bit harsh but nobody likes to be pushed around.
[ It is not like I don't want to add proper hot-plugging support or do test
on more hardware but my time schedule is already tight enough and there are
it together with my previous patch for
ide_device_{get,put}()?
Please test it when you have some time.
The problem in that case is access to the HW :-) I have plenty ide-pmac
based machines but only one or two old laptop (ie. Paul has one too)
with a media-bay and those are in the office. So I'll
There seems to be some confusion between warm-plugging of IDE devices
and hot-plugging of IDE devices.
not a single piece of HW to exercise those code path ? I don't ask you
to get a powermac with a media-bay, but ide_cs seems to be a pretty
important one that's part of what the ide
On Thu, 2008-07-31 at 09:49 +0100, Alan Cox wrote:
There seems to be some confusion between warm-plugging of IDE devices
and hot-plugging of IDE devices.
not a single piece of HW to exercise those code path ? I don't ask you
to get a powermac with a media-bay, but ide_cs seems
I could make the media-bay look like a controller hotplug if it was
going to make things easier...
I'm not sure it will. It may do nowdays, but the older IDE code
historically was fairly broken for both cases except in 2.4. Also faking
it as controller hotplug is the wrong path for libata which
On Thu, 2008-07-31 at 10:13 +0100, Alan Cox wrote:
I could make the media-bay look like a controller hotplug if it was
going to make things easier...
I'm not sure it will. It may do nowdays, but the older IDE code
historically was fairly broken for both cases except in 2.4. Also faking
different from
ide-pmac here vs. something like pcmcia IDE cards... do you have one of
these to test with ?
Nope and I really don't intend to have one. I count on other people
to take some care of support for host drivers that they maintain/use. ;)
Reverting the patch below does the job
On Tue, 2008-07-29 at 21:26 +0200, Bartlomiej Zolnierkiewicz wrote:
I WON!!!
Only half...
It goes further and then blows up again. First problem is, this
unregister interface doesn't quite convey the fact that the HW is gone
and the IDE code seems to take it's sweet time figuring it out after
problem is, this
unregister interface doesn't quite convey the fact that the HW is gone
and the IDE code seems to take it's sweet time figuring it out after
trying some requests. Maybe something smarter can be done here ? ie,
ide_set_interface_dead() :-)
Sure, it would be great to have
On Wed, 2008-07-30 at 21:11 +0200, Bartlomiej Zolnierkiewicz wrote:
Note that there shouldn't be anything fundamentally different from
ide-pmac here vs. something like pcmcia IDE cards... do you have one
of
these to test with ?
Nope and I really don't intend to have one. I count
On Thursday 31 July 2008, Benjamin Herrenschmidt wrote:
On Wed, 2008-07-30 at 21:11 +0200, Bartlomiej Zolnierkiewicz wrote:
Note that there shouldn't be anything fundamentally different from
ide-pmac here vs. something like pcmcia IDE cards... do you have one
of
these to test
On Thu, 2008-07-31 at 02:48 +0200, Bartlomiej Zolnierkiewicz wrote:
There seems to be some confusion between warm-plugging of IDE devices
and hot-plugging of IDE devices.
not a single piece of HW to exercise those code path ? I don't ask you
to get a powermac with a media-bay, but ide_cs
On Thursday 31 July 2008, Benjamin Herrenschmidt wrote:
On Thu, 2008-07-31 at 02:48 +0200, Bartlomiej Zolnierkiewicz wrote:
There seems to be some confusion between warm-plugging of IDE devices
and hot-plugging of IDE devices.
not a single piece of HW to exercise those code path ? I
Is it actually caused by additional reference counting on drive-gendev?
IOW if you reverse the patch below instead of applying the previous fix
do things work OK again?
Note that there shouldn't be anything fundamentally different from
ide-pmac here vs. something like pcmcia IDE cards
devices ...
The switch to these helpers happened _before_ 2.6.26 and it shouldn't bring
such behavior change (ditto for new IDE host addition/removal helpers)...
Please try to git-bisect it when you have some time.
Thanks,
Bart
___
Linuxppc-dev mailing list
On Tue, 2008-07-29 at 13:41 +0200, Bartlomiej Zolnierkiewicz wrote:
Well, all I do is call into Bart's new helpers to scan for or
unregister
devices ...
The switch to these helpers happened _before_ 2.6.26 and it shouldn't
bring
such behavior change (ditto for new IDE host addition
bring
such behavior change (ditto for new IDE host addition/removal
helpers)...
Please try to git-bisect it when you have some time.
Ok, I will. I worked fine when I last tried your patches. I'll see if I
can track it down too. Been a bit too busy lately as you can imagine.
Do you have
I WON!!!
Heh, great :-)
I'll give you patch a try, thanks !
Cheers,
Ben.
From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Subject: [PATCH] ide: fix regression caused by ide_device_{get,put}() addition
On Monday 28 July 2008, Benjamin Herrenschmidt wrote:
[...]
Vector: 300 (Data
+0200, Bartlomiej Zolnierkiewicz wrote:
Well, all I do is call into Bart's new helpers to scan for or
unregister
devices ...
The switch to these helpers happened _before_ 2.6.26 and it shouldn't
bring
such behavior change (ditto for new IDE host addition/removal
On Monday 28 July 2008, Benjamin Herrenschmidt wrote:
On Mon, 2008-07-28 at 11:29 +1000, Benjamin Herrenschmidt wrote:
The current ide-pmac upstream is broken. It calls
media_bay_set_ide_infos() with an uninitialized hwif argument.
It's not a trivial mistake, there's a chicken-and-egg
On Tue, 2008-07-29 at 14:17 +0900, FUJITA Tomonori wrote:
If q-elevator is NULL, the media-bay code might mess up the ref
counting of the request queue...
Well, all I do is call into Bart's new helpers to scan for or unregister
devices ...
Ben.
___
101 - 200 of 311 matches
Mail list logo
