Re: ide pmac breakage

2008-07-28 Thread FUJITA Tomonori
this path by removing ide-cd module, and it's fine. If q-elevator is NULL, the media-bay code might mess up the ref counting of the request queue... Here's a backtrace: Vector: 300 (Data Access) at [c58b7b80] pc: c014f264: elv_may_queue+0x10/0x44 lr: c0152750: get_request+0x2c

ide pmac breakage

2008-07-27 Thread Benjamin Herrenschmidt
The current ide-pmac upstream is broken. It calls media_bay_set_ide_infos() with an uninitialized hwif argument. It's not a trivial mistake, there's a chicken-and-egg problem in the init code in there. I've locally fixed it with this patch that i'll merge via the powerpc tree unless you have

Re: ide pmac breakage

2008-07-27 Thread Benjamin Herrenschmidt
On Mon, 2008-07-28 at 11:29 +1000, Benjamin Herrenschmidt wrote: The current ide-pmac upstream is broken. It calls media_bay_set_ide_infos() with an uninitialized hwif argument. It's not a trivial mistake, there's a chicken-and-egg problem in the init code in there. I've locally fixed

Re: [PATCH] powerpc/86xx: mpc8610_hpcd: fix interrupt trigger type for ULi IDE

2008-07-02 Thread Kumar Gala
On Jul 1, 2008, at 8:04 AM, Anton Vorontsov wrote: i8259 PIC is disabled on MPC8610HPCD, and ULi IDE is configured to use PCI sideband interrupt that is specified in the device tree. Current HPCD's device tree specify that IDE interrupt is low to high sensitive, but in practice ULi IDE throws

[PATCH] powerpc/86xx: mpc8610_hpcd: fix interrupt trigger type for ULi IDE

2008-07-01 Thread Anton Vorontsov
i8259 PIC is disabled on MPC8610HPCD, and ULi IDE is configured to use PCI sideband interrupt that is specified in the device tree. Current HPCD's device tree specify that IDE interrupt is low to high sensitive, but in practice ULi IDE throws active-high interrupts (not active-low as all normal

Re: [PATCH 1/5] powerpc: remove mpc8xx-ide driver

2008-06-12 Thread Kumar Gala
] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] --- drivers/ide/Kconfig | 10 - drivers/ide/ppc/Makefile |1 - drivers/ide/ppc/mpc8xx.c | 847 -- 3 files changed, 0 insertions(+), 858 deletions(-) delete mode 100644 drivers/ide/ppc/mpc8xx.c

Re: [PATCH 1/5] powerpc: remove mpc8xx-ide driver

2008-06-12 Thread Arnd Bergmann
|4 - arch/powerpc/Kconfig.debug|2 +- drivers/ide/pci/sl82c105.c|4 - drivers/input/serio/i8042-ppcio.h | 75 drivers/net/Kconfig |3 +- drivers/net/fec.c | 35 +- drivers/net/smc91x.h

[PATCH 1/7] ide-pmac: bugfix for media-bay support rework

2008-06-12 Thread Bartlomiej Zolnierkiewicz
Fix bug introduced by: commit 2dde7861afa23cd59db83515cb0b810b92b220aa Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Date: Fri Apr 18 00:46:23 2008 +0200 ide: rework PowerMac media-bay support (take 2) ... [ Yeah, I suck. ] bay-cd_index shouldn't be changed if IDE devices

[PATCH 2/7] ide-pmac: add -cable_detect method

2008-06-12 Thread Bartlomiej Zolnierkiewicz
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c | 55 +++-- 1 file changed, 31 insertions(+), 24 deletions(-) Index: b/drivers/ide/ppc/pmac.c === --- a/drivers

[PATCH 3/7] ide-pmac: remove bogus comment about pmac_ide_setup_device()

2008-06-12 Thread Bartlomiej Zolnierkiewicz
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) Index: b/drivers/ide/ppc/pmac.c

[PATCH 5/7] ide-pmac: store pmif instead of hwif in -driver_data

2008-06-12 Thread Bartlomiej Zolnierkiewicz
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c | 93 - 1 file changed, 55 insertions(+), 38 deletions(-) Index: b/drivers/ide/ppc/pmac.c === --- a/drivers/ide/ppc

[PATCH 6/7] ide-pmac: add -init_dev method

2008-06-12 Thread Bartlomiej Zolnierkiewicz
There should be no functional changes caused by this patch. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) Index: b/drivers

[PATCH 7/7] ide-pmac: move ide_find_port() call to pmac_ide_setup_device()

2008-06-12 Thread Bartlomiej Zolnierkiewicz
care of it) - drop IDE interface number from driver banner message (but include bus type) Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c | 42 -- 1 file changed, 16

[PATCH 1/5] powerpc: remove mpc8xx-ide driver

2008-06-10 Thread arnd
This driver was only used by arch/ppc code and is obsolete now with the move to common arch/powerpc code. Cc: [EMAIL PROTECTED] Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] --- drivers/ide/Kconfig | 10 - drivers/ide/ppc/Makefile |1

[PATCH] [IDE] alim15x3: disable init_hwif_ali15x3 for PowerPC

2008-04-29 Thread Anton Vorontsov
We don't need init_hwif_ali15x3() on the PowerPC systems either. Before: ALI15X3: IDE controller (0x10b9:0x5229 rev 0xc8) at PCI slot 0001:03:1f.0 ALI15X3: 100% native mode on irq 19 ide0: BM-DMA at 0x1120-0x1127 ide1: BM-DMA at 0x1128-0x112f hda: SONY DVD RW AW-Q170A, ATAPI CD/DVD-ROM

Re: [PATCH] ide: make ide_pci_check_iomem() actually work

2008-04-15 Thread Bartlomiej Zolnierkiewicz
at BAR0..BAR3. As for scc_pata, the control should not even get there because BAR0..BAR3 are *not* IDE command/control block bases on this chip (BAR0/1 are control/DMA bases if you look into setup_mmio_scc()) but they are treated as such by the code immediately following

Re: [PATCH 15/18] ide: remove broken/dangerous HDIO_[UNREGISTER, SCAN]_HWIF ioctls

2008-03-29 Thread Bartlomiej Zolnierkiewicz
On Thursday 27 March 2008, Sergei Shtylyov wrote: [...] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Thanks for reviewing it. Index: b/drivers/ide/ide-pnp.c

Re: [PATCH 15/18] ide: remove broken/dangerous HDIO_[UNREGISTER, SCAN]_HWIF ioctls

2008-03-29 Thread Bartlomiej Zolnierkiewicz
On Friday 28 March 2008, Mark Lord wrote: Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: hdparm explicitely marks HDIO_[UNREGISTER,SCAN]_HWIF ioctls as DANGEROUS and given the number of bugs we can assume that there are no real users: .. There is the odd user of these,

Re: [PATCH 15/18] ide: remove broken/dangerous HDIO_[UNREGISTER, SCAN]_HWIF ioctls

2008-03-28 Thread Mark Lord
Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: hdparm explicitely marks HDIO_[UNREGISTER,SCAN]_HWIF ioctls as DANGEROUS and given the number of bugs we can assume that there are no real users: .. There is the odd user of these, actually. But the most recent to email me (a few weeks

Re: [PATCH 15/18] ide: remove broken/dangerous HDIO_[UNREGISTER, SCAN]_HWIF ioctls

2008-03-27 Thread Sergei Shtylyov
allocated again. * Since ide_init_hwif_ports() is used for -io_ports[] setup the ioctls don't work for almost all hosts with non-standard (== non ISA-like) layout of IDE taskfile registers (there is a lot of such host drivers). * ide_port_init_devices() is not called when probing IDE devices so

linux-next: ide pmac.c fix

2008-02-18 Thread Stephen Rothwell
Hi Bart, the current linux-next produces this error for a pmac32 powerpc build: drivers/ide/ppc/pmac.c:1094: error: conversion to non-scalar type requested drivers/ide/ppc/pmac.c:1232: error: conversion to non-scalar type requested -- Cheers, Stephen Rothwell[EMAIL

Re: [BUID_FAILURE] next-20080215 Build failure caused by ide: rework PowerMac media-bay support

2008-02-16 Thread Bartlomiej Zolnierkiewicz
by the ide: rework PowerMac media-bay support patch.This problem was reported and solution suggested according to http://lkml.org/lkml/2008/2/13/195 including the #include linux/ide.h after #ifdef CONFIG_BLK_DEV_IDE_PMAC helps in fixing the build failure. Thanks, I fixed the original patch

[BUID_FAILURE] next-20080215 Build failure caused by ide: rework PowerMac media-bay support

2008-02-15 Thread Kamalesh Babulal
: function declaration isn't a prototype make[2]: *** [arch/powerpc/platforms/powermac/setup.o] Error 1 make[1]: *** [arch/powerpc/platforms/powermac] Error 2 make: *** [arch/powerpc/platforms] Error 2 This build failure is caused by the ide: rework PowerMac media-bay support patch.This problem

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-13 Thread Gabriel Paubert
of fixes and preparatory patches - rework of PowerMac media-bay support ([un]register IDE devices instead of [un]registering IDE interface) [ it is the main reason for spamming PPC ML ] Interesting... I was thinking about doing a full remove of the device at a higher

Re: [PATCH 09/18] ide: rework PowerMac media-bay support

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 13 February 2008, Michael Ellerman wrote: On Fri, 2008-02-08 at 01:45 +0100, Bartlomiej Zolnierkiewicz wrote: Rework PowerMac media-bay support in such way that instead of un/registering the IDE interface we un/register IDE devices: * Add ide_port_scan() helper

[PATCH 01/11] ide-pmac: remove dead code

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Remove unused pmac_ide_{check_base,get_irq}() and pmac_find_ide_boot(), then remove no longer needed ide_majors[] and pmac_ide_count. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c | 47

[PATCH 11/11] ppc/pmac: remove no longer needed IDE quirk

2008-02-13 Thread Bartlomiej Zolnierkiewicz
IDE PMAC host driver and all IDE PCI host drivers use pci_enable_device() nowadays so the following quirk in pmac_pcibios_after_init() can be removed. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/powerpc/platforms/powermac/pci.c

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Alan Cox
media-bay support ([un]register IDE devices instead of [un]registering IDE interface) [ it is the main reason for spamming PPC ML ] Interesting... I was thinking about doing a full remove of the device at a higher level instead but I suppose what you propose is easier. I'll

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Bartlomiej Zolnierkiewicz
]register IDE devices instead of [un]registering IDE interface) [ it is the main reason for spamming PPC ML ] Interesting... I was thinking about doing a full remove of the device at a higher level instead but I suppose what you propose is easier. I'll have a look test next week

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Benjamin Herrenschmidt
of fixes and preparatory patches - rework of PowerMac media-bay support ([un]register IDE devices instead of [un]registering IDE interface) [ it is the main reason for spamming PPC ML ] Interesting... I was thinking about doing a full remove of the device at a higher

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Benjamin Herrenschmidt
On Fri, 2008-02-08 at 19:40 +1100, Benjamin Herrenschmidt wrote: On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: - couple of fixes and preparatory patches - rework of PowerMac media-bay support ([un]register IDE devices instead of [un]registering IDE interface

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Benjamin Herrenschmidt
([un]register IDE devices instead of [un]registering IDE interface) [ it is the main reason for spamming PPC ML ] Interesting... I was thinking about doing a full remove of the device at a higher level instead but I suppose what you propose is easier. Well, I have serious

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Gabriel Paubert
On Fri, Feb 08, 2008 at 07:40:43PM +1100, Benjamin Herrenschmidt wrote: On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: - couple of fixes and preparatory patches - rework of PowerMac media-bay support ([un]register IDE devices instead of [un]registering IDE

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Gabriel Paubert
support ([un]register IDE devices instead of [un]registering IDE interface) [ it is the main reason for spamming PPC ML ] Interesting... I was thinking about doing a full remove of the device at a higher level instead but I suppose what you propose is easier. Well, I have serious

Re: [PATCH 09/18] ide: rework PowerMac media-bay support

2008-02-12 Thread Michael Ellerman
On Fri, 2008-02-08 at 01:45 +0100, Bartlomiej Zolnierkiewicz wrote: Rework PowerMac media-bay support in such way that instead of un/registering the IDE interface we un/register IDE devices: * Add ide_port_scan() helper for probing+registerering devices on a port. * Rename

Re: [PATCH 06/18] ide: factor out code unregistering devices from ide_unregister()

2008-02-09 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Factor out code unregistering devices from ide_unregister() to ide_port_unregister_devices(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei ___

Re: [PATCH 07/18] ide: factor out devices init from ide_init_port_data()

2008-02-09 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Factor out devices init from ide_init_port_data() to ide_port_init_devices_data(). While at it: * Add explicit clearing of IDE device structure. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-08 Thread Benjamin Herrenschmidt
On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: - couple of fixes and preparatory patches - rework of PowerMac media-bay support ([un]register IDE devices instead of [un]registering IDE interface) [ it is the main reason for spamming PPC ML ] Interesting... I

Re: [PATCH 05/18] ide: factor out cable detection from ide_init_port()

2008-02-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Factor out cable detection from ide_init_port() to ide_port_cable_detect(). * Move ide_port_cable_detect() call to ide_device_add_all(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 08/18] ide: move ide_port_setup_devices() call to ide_device_add_all()

2008-02-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Add ide_cfg_mtx lock/unlock to ide_port_setup_devices() and then move ide_port_setup_devices() call from init_irq() to ide_device_add_all(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

[PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-07 Thread Bartlomiej Zolnierkiewicz
- couple of fixes and preparatory patches - rework of PowerMac media-bay support ([un]register IDE devices instead of [un]registering IDE interface) [ it is the main reason for spamming PPC ML ] - IDE warm-plug support (though it is still experimental it should work fine, unlike the older

[PATCH 01/18] ide-generic: set hwif-chipset

2008-02-07 Thread Bartlomiej Zolnierkiewicz
This hwif-chipset fixup is already present in ide_device_add_all() but for warm-plug support we also need to reserve not currently present interfaces. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-generic.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH 02/18] ide: fix ide_find_port()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
* Instead of checking for '-io_ports[IDE_DATA_OFFSET] == 0' check for '-chipset == ide_unknown' when looking for an empty ide_hwifs[] slot. * Do ide-pnp initialization after ide-generic when IDE is built-in (ide-pnp is the only user of ide_find_port() which needs such fixup). Signed-off

[PATCH 03/18] ide: use ide_find_port() instead of ide_deprecated_find_port()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
* Use ide_find_port() instead of ide_deprecated_find_port() in bast-ide/ palm_bk3710/ide-cs/delkin_cb host drivers and in ide_register_hw(). * Remove no longer needed ide_deprecated_find_port(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/bast-ide.c

[PATCH 04/18] ide-acpi: add missing drive-acpidata zeroing

2008-02-07 Thread Bartlomiej Zolnierkiewicz
There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-acpi.c |2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/ide/ide-acpi.c

[PATCH 05/18] ide: factor out cable detection from ide_init_port()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
* Factor out cable detection from ide_init_port() to ide_port_cable_detect(). * Move ide_port_cable_detect() call to ide_device_add_all(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |4 1 file changed, 4 insertions(+) Index: b/drivers/ide

[PATCH 06/18] ide: factor out code unregistering devices from ide_unregister()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
Factor out code unregistering devices from ide_unregister() to ide_port_unregister_devices(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) Index: b/drivers/ide/ide.c

[PATCH 07/18] ide: factor out devices init from ide_init_port_data()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
* Factor out devices init from ide_init_port_data() to ide_port_init_devices_data(). While at it: * Add explicit clearing of IDE device structure. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c

[PATCH 08/18] ide: move ide_port_setup_devices() call to ide_device_add_all()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
Add ide_cfg_mtx lock/unlock to ide_port_setup_devices() and then move ide_port_setup_devices() call from init_irq() to ide_device_add_all(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |6 -- 1 file changed, 4 insertions(+), 2 deletions

[PATCH 09/18] ide: rework PowerMac media-bay support

2008-02-07 Thread Bartlomiej Zolnierkiewicz
Rework PowerMac media-bay support in such way that instead of un/registering the IDE interface we un/register IDE devices: * Add ide_port_scan() helper for probing+registerering devices on a port. * Rename ide_port_unregister_devices() to __ide_port_unregister_devices(). * Add

[PATCH 11/18] ide-generic: add ide_generic class and attribute for adding new interfaces

2008-02-07 Thread Bartlomiej Zolnierkiewicz
for obsoleted idex=base[,ctl[,irq]] kernel parameters). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +391 bytes (x86-32) I also tried interface based on kernel parameters but it sucked (more complex, bigger source code + resulting binary). drivers/ide/ide-generic.c | 78

[PATCH 13/18] ide: remove CONFIG_BLK_DEV_HD_IDE config option

2008-02-07 Thread Bartlomiej Zolnierkiewicz
* Remove CONFIG_BLK_DEV_HD hack from init_hwif_default() (ide0=noprobe kernel parameter should be used instead if somebody wishes to use the old hd driver). * Make CONFIG_BLK_DEV_HD_ONLY config option available also when IDE subsystem is used and update help entry. * Remove no longer

[PATCH 14/18] ide: remove obsoleted idex=base[, ctl[, irq]] kernel parameters

2008-02-07 Thread Bartlomiej Zolnierkiewicz
--- drivers/ide/ide-generic.c |3 +-- drivers/ide/ide-probe.c |3 +-- drivers/ide/ide-proc.c|3 --- drivers/ide/ide.c | 22 +- drivers/ide/pci/cmd640.c |2 +- drivers/ide/setup-pci.c | 11 --- include/linux/ide.h |2 +- 8 files

[PATCH 16/18] ide: remove -hold field from ide_hwif_t

2008-02-07 Thread Bartlomiej Zolnierkiewicz
-hold is write-only now, remove it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/mips/au1xxx-ide.c |3 --- drivers/ide/ppc/pmac.c|1 - include/linux/ide.h |1 - 3 files changed, 5 deletions(-) Index: b/drivers/ide/mips/au1xxx-ide.c

[PATCH 17/18] ide: remove init_hwif_default()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
init_hwif_default() is only used by init_ide_data() now, inline it there. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) Index: b/drivers/ide/ide.c

[PATCH 18/18] ide: remove ide_init_hwif_ports()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
ide_init_hwif_ports() is only used by init_ide_data() now, inline it there. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 11 +-- include/linux/ide.h | 32 2 files changed, 9 insertions(+), 34 deletions(-) Index

[PATCH] [POWERPC] pasemi: Move electra-ide to pata_of_platform

2008-01-15 Thread Olof Johansson
Move electra-ide glue over to the new pata_of_platform framework, and add the quirks needed to that driver. --- Applied with the rest of the patches to pasemi.git for-2.6.25 arch/powerpc/platforms/pasemi/electra_ide.c | 96 b/arch/powerpc/configs

Re: [PATCH] pata_of_platform: Move electra-ide support over to new framework

2007-12-20 Thread Paul Mackerras
Olof Johansson writes: FWIW I'm presuming this work will go via a powerpc tree not libata... Generally that's not the case, but here it's largely an arch-specific work. Ok, that works. I was thinking of letting this patch go through libata, and do the removal through the powerpc merge

Re: [PATCH] pata_of_platform: Move electra-ide support over to new framework

2007-12-20 Thread Olof Johansson
On Thu, Dec 20, 2007 at 02:53:46PM +1100, Paul Mackerras wrote: Olof Johansson writes: FWIW I'm presuming this work will go via a powerpc tree not libata... Generally that's not the case, but here it's largely an arch-specific work. Ok, that works. I was thinking of letting this

Re: [PATCH] Fix build break caused by ide: remove ideprobe_init()

2007-12-17 Thread Bartlomiej Zolnierkiewicz
but includes linux/ide.h: ^ ...could you also fix the root source of the problem so the similar issue won't re-appear in the future? linux/ide.h is IDE subsystem specific in the same way that linux/libata.h is libata specific, linux/ata.h

Re: [PATCH] Fix build break caused by ide: remove ideprobe_init()

2007-12-17 Thread Olof Johansson
builds of powerpc holly_defconfig in -mm. It has CONFIG_EMBEDDED=y, CONFIG_IDE=n but includes linux/ide.h: ^ ...could you also fix the root source of the problem so the similar issue won't re-appear in the future? linux/ide.h is IDE

[PATCH] Fix build break caused by ide: remove ideprobe_init()

2007-12-14 Thread Olof Johansson
be no functionality changes caused by this patch. This patch broke builds of powerpc holly_defconfig in -mm. It has CONFIG_EMBEDDED=y, CONFIG_IDE=n but includes linux/ide.h: Index: mm/drivers/ide/ide-probe.c === --- mm.orig/drivers/ide/ide

[PATCH] pata_of_platform: Move electra-ide support over to new framework

2007-12-04 Thread Olof Johansson
[POWERPC] Move electra-ide support over to new pata_of_platform framework Move electra-ide glue over to the new pata_of_platform framework, and add the quirks needed to that driver. Signed-off-by: Olof Johansson [EMAIL PROTECTED] --- I'll remove the electra-ide stuff from arch/powerpc

Re: [PATCH] pata_of_platform: Move electra-ide support over to new framework

2007-12-04 Thread Jeff Garzik
Olof Johansson wrote: [POWERPC] Move electra-ide support over to new pata_of_platform framework Move electra-ide glue over to the new pata_of_platform framework, and add the quirks needed to that driver. Signed-off-by: Olof Johansson [EMAIL PROTECTED] --- I'll remove the electra

Re: [PATCH] pata_of_platform: Move electra-ide support over to new framework

2007-12-04 Thread Olof Johansson
On Tue, Dec 04, 2007 at 03:50:03PM -0500, Jeff Garzik wrote: Olof Johansson wrote: [POWERPC] Move electra-ide support over to new pata_of_platform framework Move electra-ide glue over to the new pata_of_platform framework, and add the quirks needed to that driver. Signed-off-by: Olof

Re: [PATCH 4/21] ide/Kconfig: fix mpc8xx host driver dependencies

2007-11-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Only LWMON, IVMS8, IVML24 and TQM8xxL platforms have the needed defines (IDE0_BASE_OFFSET and friends) in the platform header file. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

[PATCH] Fix non-terminated PCI match table in PowerMac IDE

2007-10-06 Thread Benjamin Herrenschmidt
The PCI device table in the powermac IDE driver isn't properly terminated. Depending on how your kernel is linked and other random factors, you can end up with this driver matched against any other PCI device in your system, possibly crashing at boot. Thanks to Heikki for tracking this down

[PATCH] [POWERPC] Remove unused variabls from drivers/ide/ppc/pmac.c

2007-09-16 Thread Stephen Rothwell
Removes these warnings: /home/sfr/kernels/linus/drivers/ide/ppc/pmac.c: In function 'pmac_ide_dma_check': /home/sfr/kernels/linus/drivers/ide/ppc/pmac.c:1807: warning: unused variable 'map' /home/sfr/kernels/linus/drivers/ide/ppc/pmac.c:1805: warning: unused variable 'pmif' Signed-off

[PATCH] Remove unused variables in driver/ide/ppc/pmac.c

2007-08-30 Thread Tony Breeds
Fixes: CC [M] drivers/ide/ppc/pmac.o /scratch/tony/tmp/drivers/ide/ppc/pmac.c: In function 'pmac_ide_dma_check': /scratch/tony/tmp/drivers/ide/ppc/pmac.c:1815: warning: unused variable 'map' /scratch/tony/tmp/drivers/ide/ppc/pmac.c:1813: warning: unused variable 'pmif' Signed-off-by: Tony

ide/libata and powerpc arch/device tree

2007-08-28 Thread Gerhard Pircher
Hi, I'm currently/still trying to describe legacy ports and interrupts for a VIA southbridge PCI IDE controller in a device tree. While the legacy ports can be described in the PCI device node (as suggested to me by some developers here in a previous discussion thread - by imitating the Pegasos

[PATCH] advertise correct IDE mode on Pegasos2

2007-08-17 Thread Olaf Hering
The built-in IDE controller is configured in legacy mode, but the PCI registers advertise native mode. Force the PCI class into legacy mode. This allows pata_via to access two drives. The Pegasos specific irq enforcement in the via82cxxx driver can be removed. Tested on Pegasos2 with firmware

Re: [PATCH] advertise correct IDE mode on Pegasos2

2007-08-17 Thread Olaf Hering
On Fri, Aug 17, Olaf Hering wrote: Still not 100% perfect. + prom_printf(Fixing up IDE class-code on Pegasos...\n); + rc = prom_getprop(ph, class-code, prop, sizeof(u32)); + if (rc == sizeof(u32)) { + prop[0] = ~0x5

[PATCH] advertise correct IDE mode on Pegasos2

2007-08-17 Thread Olaf Hering
The built-in IDE controller is configured in legacy mode, but the PCI registers advertise native mode. Force the PCI class into legacy mode. This allows pata_via to access two drives. The Pegasos specific irq enforcement in the via82cxxx driver must stay because there is aparently no generic way

Re: adding Pegasus IDE quirk for pata_via

2007-08-16 Thread Olaf Hering
On Mon, Apr 09, Matt Sealey wrote: + if (bridge) { + u8 iir, irqlist[4] = { 14, 15, 10, 11 }; + + pci_read_config_byte(bridge, VIA_IDE_STEERING, iir); What value has VIA_IDE_STEERING?

Re: [PATCH 1/2] [IDE] Platform IDE driver

2007-08-06 Thread Segher Boessenkool
More importantly, reg-shift doesn't say what part of the bigger words to access. A common example is byte-wide registers on a 32-bit-only bus; it's about 50%-50% between connecting the registers to the low byte vs. connecting it to the byte with the lowest address. We already have

Re: [PATCH 1/2] [IDE] Platform IDE driver

2007-08-01 Thread Sergei Shtylyov
property is needed; the device driver can look at your compatible property, instead. Why the heck should we care about the UART code taling about IDE?! Consistency? We're not obliged to be consistent with every piece of the kernel code. It would be nice to not name similar

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-08-01 Thread Sergei Shtylyov
Hello. Segher Boessenkool wrote: +[EMAIL PROTECTED] { +compatible = mmio-ide; +device_type = ide; Why not ata? The hardware is called (E)IDE, the protocol is called ATA. Sorry for not denouncing this earlier. :-) ATA is the name of ANSI standard describing

[PATCH] ide/ppc/pmac: Remove a few unused variables

2007-08-01 Thread Segher Boessenkool
Signed-off-by: Segher Boessenkool [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c index 33630ad..0f5a6b4 100644 --- a/drivers/ide/ppc/pmac.c +++ b/drivers/ide/ppc/pmac.c

Re: [PATCH 1/2] [IDE] Platform IDE driver

2007-07-31 Thread Segher Boessenkool
taling about IDE?! Consistency? We're not obliged to be consistent with every piece of the kernel code. It would be nice to not name similar properties in the device tree dissimilarly. Kernel code doesn't come into the picture here. Segher

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-31 Thread Segher Boessenkool
+ [EMAIL PROTECTED] { + compatible = mmio-ide; + device_type = ide; Why not ata? The hardware is called (E)IDE, the protocol is called ATA. Or that's what I was told -- I think there's some historic revisionism involved, too. Also, what mmio-ide in the compat

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-31 Thread Segher Boessenkool
with it? reg-shift alone isn't enough to know how to access the device registers. In the case of UARTs, they typically are internal to some SoC, so the device driver can just look up what SoC it is and will then know what to do. For IDE though, as far as I understand it typically is board-specific, done

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-31 Thread Alan Cox
The hardware is called (E)IDE, the protocol is called ATA. Or that's what I was told -- I think there's some historic revisionism involved, too. ATA is the interface and standards for the ANSI standards based disk attachment. IDE Integrated Drive Electronics is a marketing name used to cover

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Bartlomiej Zolnierkiewicz
On Wednesday 25 July 2007, Alan Cox wrote: pata_platform and ide_platform are carrying same driver names, to easily switch between these drivers, without need to touch platform code. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] Signed-off-by: Vitaly Bordug [EMAIL PROTECTED]

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 25 July 2007, Vitaly Bordug wrote: This is now very similar to pata_platform.c, they both use same platform data structure and same resources. To achieve that, byte_lanes_swapping platform data variable and platform specified iops removed from that driver. It's fine,

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 26 July 2007, Guennadi Liakhovetski wrote: On Wed, 25 Jul 2007, Alan Cox wrote: driver to using platform-device. I got a reply, that it's not worth it now that IDE is slowly becoming obsolete, and the pata_platform serves the perpose perfectly well. I found

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Vitaly Bordug
On Wed, 25 Jul 2007 13:46:57 -0500 Scott Wood wrote: Sergei Shtylyov wrote: I acn undertand your complaint in the context of an OF driver (which we don't have yet) but mmio-ide just means nothing to the current driver, and it doesn't convery enough info on the programming interface

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Vitaly Bordug
/mpc8349emitx.dts +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts @@ -37,6 +37,15 @@ reg = 1000; }; + [EMAIL PROTECTED] { + compatible = mmio-ide; + device_type = ide; Why not ata? we already argued around this iirc. I have

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Kumar Gala
is this something that could exist in pata land? I haven't really been following legacy/ide vs pata lately. - k ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Sergei Shtylyov
Hello. Scott Wood wrote: Also, what mmio-ide in the compat properly means in the context of ide_platform which is able to handle both port and memory mapped IDE. I/O-space is only valid in the context of PCI, ISA, or similar buses, and the bus-specific reg format indicates whether it's

Re: [PATCH 1/2] [IDE] Platform IDE driver

2007-07-25 Thread Scott Wood
Sergei Shtylyov wrote: It doesn't buy us anything in here, but it's conceivable that someone may want to write a driver that uses a shift in the I/O accessor rather than an array of port offsets, It wouldn't be IDE driver then, and neither it would be libata which also does

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Guennadi Liakhovetski
On Thu, 26 Jul 2007, Sergei Shtylyov wrote: Guennadi Liakhovetski wrote: Wrong list to submit sych stuff, post to linux-ide. Not entirely. The patch (or other patches in the series) would also touch ARM platforms in the mainline, currently using that driver. As I didn't

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Guennadi Liakhovetski
from that driver. It's fine, since those were never used anyway. pata_platform and ide_platform are carrying same driver names, to easily switch between these drivers, without need to touch platform code. Why? There's a drivers/ide/arm/ide_arm.c IDe driver that some platforms

Re: [PATCH 1/2] [IDE] Platform IDE driver

2007-07-25 Thread Sergei Shtylyov
Scott Wood wrote: It doesn't buy us anything in here, but it's conceivable that someone may want to write a driver that uses a shift in the I/O accessor rather than an array of port offsets, It wouldn't be IDE driver then, and neither it would be libata which also does this another

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Sergei Shtylyov
? It doesn't buy us anything in here, but it's conceivable that someone may want to write a driver that uses a shift in the I/O accessor rather than an array of port offsets, It wouldn't be IDE driver then, and neither it would be libata which also does this another way this (despite

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Sergei Shtylyov
. Hopefully, PPC will never need them. pata_platform and ide_platform are carrying same driver names, to easily switch between these drivers, without need to touch platform code. diff --git a/drivers/ide/legacy/ide_platform.c b/drivers/ide/legacy/ide_platform.c new file mode 100644 index

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Scott Wood
Sergei Shtylyov wrote: I acn undertand your complaint in the context of an OF driver (which we don't have yet) but mmio-ide just means nothing to the current driver, and it doesn't convery enough info on the programming interface for the conceivable OF driver, it also does need to know

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Scott Wood
On Wed, Jul 25, 2007 at 09:54:07PM +0400, Sergei Shtylyov wrote: Also, what mmio-ide in the compat properly means in the context of ide_platform which is able to handle both port and memory mapped IDE. I/O-space is only valid in the context of PCI, ISA, or similar buses, and the bus

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Scott Wood
Sergei Shtylyov wrote: Hello. Scott Wood wrote: Also, what mmio-ide in the compat properly means in the context of ide_platform which is able to handle both port and memory mapped IDE. I/O-space is only valid in the context of PCI, ISA, or similar buses, and the bus-specific reg

Re: [PATCH 1/2] [ide] mmio ide support

2007-07-11 Thread Vitaly Bordug
On Sat, 7 Jul 2007 10:01:47 -0500 Olof Johansson wrote: On Sat, Jul 07, 2007 at 01:48:52PM +0400, Vitaly Bordug wrote: This adds support for MMIO IDE device like CompactFlash in TrueIDE mode. Doesn't this duplicate most of pata_platform, but as the no-longer-preferred legacy IDE

Re: [PATCH 1/2] [ide] mmio ide support

2007-07-11 Thread Vitaly Bordug
On Sat, 7 Jul 2007 21:13:06 +0100 Alan Cox wrote: On Sat, 07 Jul 2007 13:48:52 +0400 Vitaly Bordug [EMAIL PROTECTED] wrote: This adds support for MMIO IDE device like CompactFlash in TrueIDE mode. Really we should be working towards libata support for all new devices. This looks

<    1   2   3   4   >