Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)

2009-05-03 Thread Benjamin Herrenschmidt
On Sun, 2009-05-03 at 00:26 -0400, Kyle Moffett wrote: Ok, I've dug through the docs on the 460EPx (the CPU I'm using), and I'd like some confirmation of the following: * The EMAC hardware itself internally has its own dedicated MDIO/MDClk lines, driven by the STACR register. Yes, though

Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)

2009-05-02 Thread Kyle Moffett
On Thu, Apr 30, 2009 at 6:21 PM, Kyle Moffett k...@moffetthome.net wrote: I'm also curious about the intent of the mdio_instance pointer (IE: the mdio-device property).  Is that used when all the PHY devices are attached to the MDIO bus of only one of the (multiple) emac devices? It's common

Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)

2009-04-30 Thread Kyle Moffett
On Wed, Apr 22, 2009 at 4:21 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2009-04-20 at 20:10 -0400, Kyle Moffett wrote: IIRC, Ben had some issues with how phylib and the EMAC would need to interact.  Not sure if he has those written down somewhere or not. (CC'd).

Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)

2009-04-30 Thread Grant Likely
On Thu, Apr 30, 2009 at 9:04 AM, Kyle Moffett k...@moffetthome.net wrote: On Wed, Apr 22, 2009 at 4:21 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2009-04-20 at 20:10 -0400, Kyle Moffett wrote: IIRC, Ben had some issues with how phylib and the EMAC would need to

Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)

2009-04-30 Thread Kyle Moffett
On Thu, Apr 30, 2009 at 11:11 AM, Grant Likely grant.lik...@secretlab.ca wrote: Just a heads up Kyle; there are changes queued in the netdev tree which add OF helpers for MDIO bus drivers and MAC drivers.  See here:

Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)

2009-04-30 Thread Benjamin Herrenschmidt
Ok, I've made some progress in the port, but right now I'm trying to puzzle out what the gpcs bits in the code are. From the few publicly available docs and some mailing list posts, the gpcs address appears to be some kind of integrated virtual PHY used when 460GT-ish chips are

Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)

2009-04-30 Thread Kyle Moffett
On Thu, Apr 30, 2009 at 5:18 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: Well... GPCS is indeed some kind of internal PHY if you like but it's not MDIO controlled and I don't really see a need to move it to the phylib as it's so specific to the NIC itself. But if you think it

Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)

2009-04-26 Thread Benjamin Herrenschmidt
On Mon, 2009-04-20 at 20:10 -0400, Kyle Moffett wrote: IIRC, Ben had some issues with how phylib and the EMAC would need to interact. Not sure if he has those written down somewhere or not. (CC'd). Hmm, yeah, I'd be interested to see those. There's enough similar between phylib and the

Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)

2009-04-20 Thread Josh Boyer
On Fri, Apr 17, 2009 at 8:32 PM, Kyle Moffett k...@moffetthome.net wrote: Hello, I'm currently fiddling with a custom embedded prototype board using the ibm_newemac driver with some currently-unsupported PHYs.  Those PHYs *are* supported by phylib, but the emac driver seems to have its own

Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)

2009-04-20 Thread Kyle Moffett
On Mon, Apr 20, 2009 at 8:29 AM, Josh Boyer jwbo...@linux.vnet.ibm.com wrote: On Fri, Apr 17, 2009 at 8:32 PM, Kyle Moffett k...@moffetthome.net wrote: Hello, I'm currently fiddling with a custom embedded prototype board using the ibm_newemac driver with some currently-unsupported PHYs.