RE: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Stephen Neuendorffer
> + - reg-shift : registers offset shift (standard uart_port field). > + Property is optional if regshift is zero. I was hoping to get an idea of what is required here, or when I might use it? It looks like the ARCH=ppc code instantiates this with a reg-shift of 2... Is this the e

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Pavel Kiryukhin
Stephen Neuendorffer wrote: >> + - reg-shift : registers offset shift (standard uart_port > field). >> + Property is optional if regshift is zero. > > I was hoping to get an idea of what is required here, or when I might > use it? > > It looks like the ARCH=ppc code instantiates thi

RE: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Stephen Neuendorffer
> -Original Message- > From: Pavel Kiryukhin [mailto:[EMAIL PROTECTED] > Sent: Friday, February 15, 2008 9:41 AM > To: Stephen Neuendorffer > Cc: linuxppc-dev@ozlabs.org > Subject: Re: [PATCH] booting-without-of: add Xilinx uart 16550. > > Stephen Neuendorffer w

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Milton Miller
On Sat Feb 16 00:40:01 EST 2008, Pavel Kiryukhin pkiryukhin wrote: > Add uart 16550 properties description to Xilinx portion of > booting-without-of.txt This patch description is a bit weak. How about adding what properties are being added. Also, as described below, it's going to become more

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Sergei Shtylyov
Grant Likely wrote: >>Add uart 16550 properties description to Xilinx portion of >>booting-without-of.txt >> Signed-off-by: Pavel Kiryukhin <[EMAIL PROTECTED]> >> --- >> Documentation/powerpc/booting-without-of.txt | 16 ++-- >> 1 files changed, 14 insertions(+), 2 deletions(-) >>

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Grant Likely
On Fri, Feb 15, 2008 at 11:56 AM, Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > Grant Likely wrote: > > >> + Xilinx uart 16550 device registers are compatible with all > standard 16540 > >> + and 16550 UARTs. > > > > Not strictly true; the xilinx uart is *almost* compatible with the >

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Grant Likely
On Fri, Feb 15, 2008 at 6:40 AM, Pavel Kiryukhin <[EMAIL PROTECTED]> wrote: > Add uart 16550 properties description to Xilinx portion of > booting-without-of.txt > > Signed-off-by: Pavel Kiryukhin <[EMAIL PROTECTED]> > --- > Documentation/powerpc/booting-without-of.txt | 16 ++--

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Sergei Shtylyov
Grant Likely wrote: >> >> + Xilinx uart 16550 device registers are compatible with all >> >> standard 16540 >> >> + and 16550 UARTs. >> > Not strictly true; the xilinx uart is *almost* compatible with the >> > ns16550. The same driver can be made to work, but it is not register >> > l

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Grant Likely
On Fri, Feb 15, 2008 at 12:14 PM, Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > Grant Likely wrote: > > The registers are not at the same location, therefore it is not compatible. > > > However, the *driver* can be easily made compatible with the devices. > > We just teach the driver to bind agai

RE: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Stephen Neuendorffer
> > Instead of attempting to come up with a generic description > > of this, I recommend just naming it after the actual device instance; > > something like compatible="xlnx,opb-uart16550"; > > Well, that means that we'll need a to add a code which "glues" the chip to > 8250.c driver... well,

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-18 Thread Sergei Shtylyov
Hello. Stephen Neuendorffer wrote: >>>Instead of attempting to come up with a generic description >>>of this, I recommend just naming it after the actual device instance; >>>something like compatible="xlnx,opb-uart16550"; >>Well, that means that we'll need a to add a code which "glues" the