Re: [PATCH] powerpc/xive: Fix/improve verbose debug output

2017-04-27 Thread Michael Ellerman
Benjamin Herrenschmidt writes: > The existing verbose debug code doesn't build when enabled. So why don't we convert all the DBG_VERBOSE() to pr_devel()? If there's non-verbose debug that we think would be useful to differentiate from verbose then those could be pr_debug() - which means they'l

Re: [PATCH] powerpc/xive: Fix/improve verbose debug output

2017-04-27 Thread Benjamin Herrenschmidt
On Fri, 2017-04-28 at 13:07 +1000, Michael Ellerman wrote: > Benjamin Herrenschmidt writes: > > > The existing verbose debug code doesn't build when enabled. > > So why don't we convert all the DBG_VERBOSE() to pr_devel()? pr_devel provides a bunch of debug at init/setup/mask/unmask etc... but

Re: [PATCH] powerpc/xive: Fix/improve verbose debug output

2017-04-27 Thread Michael Ellerman
Benjamin Herrenschmidt writes: > On Fri, 2017-04-28 at 13:07 +1000, Michael Ellerman wrote: >> Benjamin Herrenschmidt writes: >> >> > The existing verbose debug code doesn't build when enabled. >> >> So why don't we convert all the DBG_VERBOSE() to pr_devel()? > > pr_devel provides a bunch of

Re: [PATCH] powerpc/xive: Fix/improve verbose debug output

2017-04-27 Thread Benjamin Herrenschmidt
On Fri, 2017-04-28 at 16:34 +1000, Michael Ellerman wrote: > > > If there's non-verbose debug that we think would be useful to > > > differentiate from verbose then those could be pr_debug() - which means > > > they'll be jump labelled off in most production kernels, but still able > > > to be enab

RE: [PATCH] powerpc/xive: Fix/improve verbose debug output

2017-04-28 Thread David Laight
From: Michael Ellerman > Sent: 28 April 2017 07:34 ... > Not sure what you mean. You can enable pr_debug()s individually, by > function, by module, by file, or for the whole kernel. It is sort of a shame that you can't turn pr_info() off in the same way. David