Re: [PATCH] pte_fsl_booke: fix instruction TLB error permission check

2010-05-13 Thread Kumar Gala
On May 7, 2010, at 3:38 AM, Li Yang wrote: > Check the user/supervisor execution permission base on the code address. > This fixes the following oops on module loading or removing. > > Unable to handle kernel paging request for instruction fetch > Faulting instruction address: 0xf938d040 > Oops:

Re: [PATCH] pte_fsl_booke: fix instruction TLB error permission check

2010-05-13 Thread Benjamin Herrenschmidt
On Thu, 2010-05-13 at 14:14 -0500, Kumar Gala wrote: > On May 7, 2010, at 3:38 AM, Li Yang wrote: > > > Check the user/supervisor execution permission base on the code address. > > This fixes the following oops on module loading or removing. > > > > Unable to handle kernel paging request for inst

RE: [PATCH] pte_fsl_booke: fix instruction TLB error permission check

2010-05-13 Thread Liu Dave-R63238
> I've updated the commit message to be a bit more clear on why > we need to do this. I'm curious why the _PAGE_EXEC have different definition in pte-book3e.h and pte-fsl-booke.h? It is UX permission in pte-book3e, but is SX permission in pte-fsl-booke.h. Thanks, Dave __

RE: [PATCH] pte_fsl_booke: fix instruction TLB error permission check

2010-05-13 Thread Liu Dave-R63238
> Not looking at the code right now ... but do we have the same > issue on 64e ? Aaron pointed the issue on FSL BookE. http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-January/079738.html ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org ht

Re: [PATCH] pte_fsl_booke: fix instruction TLB error permission check

2010-05-13 Thread Benjamin Herrenschmidt
On Thu, 2010-05-13 at 14:14 -0500, Kumar Gala wrote: > On May 7, 2010, at 3:38 AM, Li Yang wrote: > > > Check the user/supervisor execution permission base on the code address. > > This fixes the following oops on module loading or removing. > > > > Unable to handle kernel paging request for inst

RE: [PATCH] pte_fsl_booke: fix instruction TLB error permission check

2010-05-13 Thread Benjamin Herrenschmidt
On Fri, 2010-05-14 at 08:53 +0800, Liu Dave-R63238 wrote: > > I've updated the commit message to be a bit more clear on why > > we need to do this. > > I'm curious why the _PAGE_EXEC have different definition in pte-book3e.h > and pte-fsl-booke.h? > > It is UX permission in pte-book3e, but is SX

Re: [PATCH] pte_fsl_booke: fix instruction TLB error permission check

2010-05-13 Thread Kumar Gala
On May 13, 2010, at 10:36 PM, Benjamin Herrenschmidt wrote: > On Thu, 2010-05-13 at 14:14 -0500, Kumar Gala wrote: >> On May 7, 2010, at 3:38 AM, Li Yang wrote: >> >>> Check the user/supervisor execution permission base on the code address. >>> This fixes the following oops on module loading or

RE: [PATCH] pte_fsl_booke: fix instruction TLB error permission check

2010-05-14 Thread Benjamin Herrenschmidt
On Fri, 2010-05-14 at 10:16 +0800, Liu Dave-R63238 wrote: > > Not looking at the code right now ... but do we have the same > > issue on 64e ? > > Aaron pointed the issue on FSL BookE. > http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-January/079738.html Right, but I think 64-bit BookE has t

RE: [PATCH] pte_fsl_booke: fix instruction TLB error permission check

2010-05-14 Thread Liu Dave-R63238
> > Aaron pointed the issue on FSL BookE. > > > http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-January/079738.htm > > l > > Right, but I think 64-bit BookE has the same issue. We can > fix that later tho. Ben, We also find the _PAGE_USER is different between pte-book3e and old fsl-booke I

RE: [PATCH] pte_fsl_booke: fix instruction TLB error permission check

2010-05-14 Thread Benjamin Herrenschmidt
On Fri, 2010-05-14 at 17:14 +0800, Liu Dave-R63238 wrote: > > > Aaron pointed the issue on FSL BookE. > > > > > http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-January/079738.htm > > > l > > > > Right, but I think 64-bit BookE has the same issue. We can > > fix that later tho. > > Ben, > >