Re: [PATCH] tty: Fix TIOCGPTPEER ioctl definition

2017-07-11 Thread Aleksa Sarai
Sent: 11 July 2017 01:12 This ioctl does nothing to justify an _IOC_READ or _IOC_WRITE flag because it doesn't copy anything from/to userspace to access the argument. Fixes: 54ebbfb1 ("tty: add TIOCGPTPEER ioctl") ... -#define TIOCGPTPEER_IOR('T', 0x41, int) /* Safely open the slave */

RE: [PATCH] tty: Fix TIOCGPTPEER ioctl definition

2017-07-11 Thread David Laight
From: Linuxppc-dev Gleb Fotengauer-Malinovskiy > Sent: 11 July 2017 01:12 > This ioctl does nothing to justify an _IOC_READ or _IOC_WRITE flag > because it doesn't copy anything from/to userspace to access the > argument. > > Fixes: 54ebbfb1 ("tty: add TIOCGPTPEER ioctl") ... > -#define

Re: [PATCH] tty: Fix TIOCGPTPEER ioctl definition

2017-07-11 Thread James Hogan
On Tue, Jul 11, 2017 at 03:12:17AM +0300, Gleb Fotengauer-Malinovskiy wrote: > This ioctl does nothing to justify an _IOC_READ or _IOC_WRITE flag > because it doesn't copy anything from/to userspace to access the > argument. > > Fixes: 54ebbfb1 ("tty: add TIOCGPTPEER ioctl") I think its

Re: [PATCH] tty: Fix TIOCGPTPEER ioctl definition

2017-07-11 Thread Arnd Bergmann
On Tue, Jul 11, 2017 at 2:12 AM, Gleb Fotengauer-Malinovskiy wrote: > This ioctl does nothing to justify an _IOC_READ or _IOC_WRITE flag > because it doesn't copy anything from/to userspace to access the > argument. > > Fixes: 54ebbfb1 ("tty: add TIOCGPTPEER ioctl") >

Re: [PATCH] tty: Fix TIOCGPTPEER ioctl definition

2017-07-10 Thread Aleksa Sarai
This ioctl does nothing to justify an _IOC_READ or _IOC_WRITE flag because it doesn't copy anything from/to userspace to access the argument. Acked-by: Aleksa Sarai Oops, I misunderstood what _IOR means semantically. TIL -- thanks! -- Aleksa Sarai Software Engineer