Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-02-09 Thread Yijing Wang
On 2014/2/6 4:40, Thomas Gleixner wrote: > Yijing, > > On Thu, 23 Jan 2014, David Laight wrote: > >> From: Linuxppc-dev Tony Prisk >>> On 23/01/14 20:12, Yijing Wang wrote: Currently, clocksource_register() and __clocksource_register_scale() functions always return 0, it's pointless, ma

RE: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-02-05 Thread Thomas Gleixner
Yijing, On Thu, 23 Jan 2014, David Laight wrote: > From: Linuxppc-dev Tony Prisk > > On 23/01/14 20:12, Yijing Wang wrote: > > > Currently, clocksource_register() and __clocksource_register_scale() > > > functions always return 0, it's pointless, make functions void. > > > And remove the dead cod

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-02-05 Thread Thomas Gleixner
On Thu, 23 Jan 2014, Daniel Lezcano wrote: > On 01/23/2014 08:12 AM, Yijing Wang wrote: > > Currently, clocksource_register() and __clocksource_register_scale() > > functions always return 0, it's pointless, make functions void. > > And remove the dead code that check the clocksource_register_hz()

RE: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread David Laight
From: Linuxppc-dev Tony Prisk > On 23/01/14 20:12, Yijing Wang wrote: > > Currently, clocksource_register() and __clocksource_register_scale() > > functions always return 0, it's pointless, make functions void. > > And remove the dead code that check the clocksource_register_hz() > > return value.

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Tony Prisk
On 23/01/14 20:12, Yijing Wang wrote: Currently, clocksource_register() and __clocksource_register_scale() functions always return 0, it's pointless, make functions void. And remove the dead code that check the clocksource_register_hz() return value. Signed-off-by: Yijing Wang .. diff --g

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Tony Prisk
On 23/01/14 20:58, Geert Uytterhoeven wrote: On Thu, Jan 23, 2014 at 8:45 AM, Tony Prisk wrote: -static inline int clocksource_register_hz(struct clocksource *cs, u32 hz) +static inline void clocksource_register_hz(struct clocksource *cs, u32 hz) { return __clocksource_register_s

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Yijing Wang
On 2014/1/23 16:40, Daniel Lezcano wrote: > On 01/23/2014 08:12 AM, Yijing Wang wrote: >> Currently, clocksource_register() and __clocksource_register_scale() >> functions always return 0, it's pointless, make functions void. >> And remove the dead code that check the clocksource_register_hz() >> r

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Daniel Lezcano
On 01/23/2014 08:12 AM, Yijing Wang wrote: Currently, clocksource_register() and __clocksource_register_scale() functions always return 0, it's pointless, make functions void. And remove the dead code that check the clocksource_register_hz() return value. Signed-off-by: Yijing Wang Well, do w

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Yijing Wang
On 2014/1/23 16:04, Tony Prisk wrote: > On 23/01/14 20:58, Geert Uytterhoeven wrote: >> On Thu, Jan 23, 2014 at 8:45 AM, Tony Prisk wrote: -static inline int clocksource_register_hz(struct clocksource *cs, u32 hz) +static inline void clocksource_register_hz(struct clocksource *cs

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Hans-Christian Egtvedt
Around Thu 23 Jan 2014 15:12:46 +0800 or thereabout, Yijing Wang wrote: > Currently, clocksource_register() and __clocksource_register_scale() > functions always return 0, it's pointless, make functions void. > And remove the dead code that check the clocksource_register_hz() > return value. > > S

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-22 Thread Geert Uytterhoeven
On Thu, Jan 23, 2014 at 8:45 AM, Tony Prisk wrote: >> -static inline int clocksource_register_hz(struct clocksource *cs, u32 >> hz) >> +static inline void clocksource_register_hz(struct clocksource *cs, u32 >> hz) >> { >> return __clocksource_register_scale(cs, 1, hz); >> } > > > Thi