Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32

2017-05-19 Thread Arnd Bergmann
On Fri, May 19, 2017 at 4:01 PM, David Laight wrote: > From: Arnd Bergmann >> Sent: 17 May 2017 22:40 >> >> On Wed, May 17, 2017 at 11:16 PM, Chris Packham >> wrote: >> > On 18/05/17 06:18, Borislav Petkov wrote: >> > One thing I would

RE: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32

2017-05-19 Thread David Laight
From: Arnd Bergmann > Sent: 17 May 2017 22:40 > > On Wed, May 17, 2017 at 11:16 PM, Chris Packham > wrote: > > On 18/05/17 06:18, Borislav Petkov wrote: > > One thing I would like confirmation on is is in_le32 -> ioread32 the > > correct change? I tossed up

Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32

2017-05-19 Thread Michael Ellerman
Arnd Bergmann writes: > On Thu, May 18, 2017 at 7:36 AM, Michael Ellerman wrote: >> Borislav Petkov writes: >> >>> Top-posting so that the PPC list can see the whole patch below. >>> >>> Since I don't know PPC, let me add PPC ML to CC for a

Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32

2017-05-18 Thread Arnd Bergmann
On Thu, May 18, 2017 at 7:36 AM, Michael Ellerman wrote: > Borislav Petkov writes: > >> Top-posting so that the PPC list can see the whole patch below. >> >> Since I don't know PPC, let me add PPC ML to CC for a confirmation this >> change is correct. >> >>

Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32

2017-05-18 Thread Borislav Petkov
On Wed, May 17, 2017 at 09:16:47PM +, Chris Packham wrote: > MV64x60 is pretty old. I considered gutting mv64x60_edac.c to make a > separate driver but that would just be more code to maintain. Well, one thing we did with layerscape and mpc85xx EDAC modules is share the FSL memory controller

Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32

2017-05-17 Thread Michael Ellerman
Borislav Petkov writes: > Top-posting so that the PPC list can see the whole patch below. > > Since I don't know PPC, let me add PPC ML to CC for a confirmation this > change is correct. > > Which brings me to the tangential: this driver is from 2006-ish and > is for some

Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32

2017-05-17 Thread Arnd Bergmann
On Wed, May 17, 2017 at 11:16 PM, Chris Packham wrote: > On 18/05/17 06:18, Borislav Petkov wrote: > One thing I would like confirmation on is is in_le32 -> ioread32 the > correct change? I tossed up between ioread32 and readl. Looking at > mv643xx_eth.c which

Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32

2017-05-17 Thread Chris Packham
On 18/05/17 06:18, Borislav Petkov wrote: > Top-posting so that the PPC list can see the whole patch below. > > Since I don't know PPC, let me add PPC ML to CC for a confirmation this > change is correct. > > Which brings me to the tangential: this driver is from 2006-ish and > is for some

Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32

2017-05-17 Thread Borislav Petkov
Top-posting so that the PPC list can see the whole patch below. Since I don't know PPC, let me add PPC ML to CC for a confirmation this change is correct. Which brings me to the tangential: this driver is from 2006-ish and is for some "Marvell MV64x60 Memory Controller kernel module for PPC