RE: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-22 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, August 21, 2012 6:04 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- > R58472; Bradley Hughes > Subject: Re: [PATCH V8] powerpc/fsl-pci: Unify pc

Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-21 Thread Scott Wood
> R58472; Bradley Hughes >> Subject: Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization >> code >> >> Another interesting case is stxssa8555.dts, which has an i8259 node but >> no ISA node (are there any other instances of this?). However, I can't >

Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-21 Thread Scott Wood
On 08/21/2012 01:09 PM, Li Yang-R58472 wrote: > > > On Aug 22, 2012, at 1:16, "Wood Scott-B07421" wrote: > >> On 08/21/2012 01:49 AM, Li Yang-R58472 wrote: >>> If there is i8259 node in the device tree, it should be suggesting >>> that there is a PCI to ISA bridge but not explicitly described i

Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-21 Thread Li Yang-R58472
On Aug 22, 2012, at 1:16, "Wood Scott-B07421" wrote: > On 08/21/2012 01:49 AM, Li Yang-R58472 wrote: >> If there is i8259 node in the device tree, it should be suggesting >> that there is a PCI to ISA bridge but not explicitly described in the >> device tree. Then we need to fix the device tre

Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-21 Thread Scott Wood
On 08/21/2012 01:49 AM, Li Yang-R58472 wrote: > If there is i8259 node in the device tree, it should be suggesting > that there is a PCI to ISA bridge but not explicitly described in the > device tree. Then we need to fix the device tree to add the ISA > nodes. No, we need to work with existing d

RE: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-20 Thread Li Yang-R58472
> -Original Message- > From: Jia Hongtao-B38951 > Sent: Tuesday, August 21, 2012 11:26 AM > To: Wood Scott-B07421 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- > R58472; Bradley Hughes > Subject: RE: [PATCH V8] powerpc/fsl-pci: Unify pc

RE: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-20 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, August 21, 2012 8:57 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Bradley Hughes > Subject: Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization > code > > On 08/2

RE: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-20 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, August 21, 2012 6:04 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- > R58472; Bradley Hughes > Subject: Re: [PATCH V8] powerpc/fsl-pci: Unify pc

Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-20 Thread Scott Wood
On 08/20/2012 05:04 PM, Scott Wood wrote: > On 08/20/2012 05:06 AM, Jia Hongtao wrote: >> @@ -842,38 +839,60 @@ void __devinit fsl_pci_init(void) >> node = fsl_pci_primary; >> >> if (of_match_node(pci_ids, node)) >> -break; >>

Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-20 Thread Scott Wood
On 08/20/2012 05:06 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function which