> The function above doesn't even use the 'rc' value.
Darn, you're right.
I'll fix that in a new version.
--
Regards,
Daniel
--
Regards,
Daniel
signature.asc
Description: This is a digitally signed message part
___
Linuxppc-dev mailing list
Linuxp
From: Cyril Bur
> Sent: 11 August 2015 07:01
...
> You have a dilema with the use of ugly if (rc = foo()). I don't like it but
> the
> file is littered with it.
>
> Looks like the majority of uses in this file the conditional block is only
> one line then it makes sense (or at least in terms of n
> Looks like the majority of uses in this file the conditional block is only
> one line then it makes sense (or at least in terms of numbers of lines... fair
> enough), however, if you have a conditional block spanning multiple lines, I
> don't like.
>
Much as this is a massive nit pick, I have sp
On Tue, 28 Jul 2015 15:28:38 +1000
Daniel Axtens wrote:
> Some aspects of initialisation are done only once in the lifetime of
> an adapter: for example, allocating memory for the adapter,
> allocating the adapter number, or setting up sysfs/debugfs files.
>
> However, we may want to be able to
