Re: [PATCH v2 net-next] af_unix: fix a fatal race with bit fields

2013-05-01 Thread David Miller
From: Eric Dumazet Date: Wed, 01 May 2013 08:24:03 -0700 > [PATCH v2] af_unix: fix a fatal race with bit fields > > Using bit fields is dangerous on ppc64/sparc64, as the compiler [1] > uses 64bit instructions to manipulate them. > If the 64bit word includes any atomic_t or spinlock_t, we can lo

RE: [PATCH v2 net-next] af_unix: fix a fatal race with bit fields

2013-05-01 Thread David Laight
> diff --git a/include/net/af_unix.h b/include/net/af_unix.h > index a8836e8..dbdfd2b 100644 > --- a/include/net/af_unix.h > +++ b/include/net/af_unix.h > @@ -57,9 +57,10 @@ struct unix_sock { > struct list_headlink; > atomic_long_t inflight; > spinlock_t

RE: [PATCH v2 net-next] af_unix: fix a fatal race with bit fields

2013-05-01 Thread Eric Dumazet
On Wed, 2013-05-01 at 16:53 +0100, David Laight wrote: > Why not just change gc_candidate and gc_maybe_cycle to > unsigned char? > It might reduce the number of pad bytes somewhat. You didn't quite follow the discussion. I used bytes on V1, and we are not 100% sure its safe on all arches. unsign