RE: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-29 Thread Xiubo Li-B47053
devicet...@vger.kernel.org; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; alsa- > de...@alsa-project.org; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface > driver. > > On Tue, Oct

Re: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-28 Thread Nicolin Chen
On Tue, Oct 29, 2013 at 12:00:57PM +0800, Xiubo Li-B47053 wrote: > > There's a patch in -next that lets the generic dmaengine code figure out > > some settings from the dmacontroller rather than requiring the driver to > > explicitly provide configuration - it's "ASoC: dmaengine-pcm: Provide > > de

RE: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-28 Thread Xiubo Li-B47053
> > +static struct snd_pcm_hardware snd_fsl_hardware = { > > + .info = SNDRV_PCM_INFO_INTERLEAVED | > > + SNDRV_PCM_INFO_BLOCK_TRANSFER | > > + SNDRV_PCM_INFO_MMAP | > > + SNDRV_PCM_INFO_MMAP_VALID | > > + SNDRV_PCM_INFO_PAUSE | > > + SNDRV_PCM_I

RE: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-28 Thread Xiubo Li-B47053
> > +static struct snd_pcm_hardware snd_fsl_hardware = { > > + .info = SNDRV_PCM_INFO_INTERLEAVED | > > + SNDRV_PCM_INFO_BLOCK_TRANSFER | > > + SNDRV_PCM_INFO_MMAP | > > + SNDRV_PCM_INFO_MMAP_VALID | > > + SNDRV_PCM_INFO_PAUSE | > > + SNDRV_PCM_I

Re: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-24 Thread Mark Brown
On Thu, Oct 17, 2013 at 05:01:10PM +0800, Xiubo Li wrote: > +static struct snd_pcm_hardware snd_fsl_hardware = { > + .info = SNDRV_PCM_INFO_INTERLEAVED | > + SNDRV_PCM_INFO_BLOCK_TRANSFER | > + SNDRV_PCM_INFO_MMAP | > + SNDRV_PCM_INFO_MMAP_VALID | > +

RE: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-18 Thread Xiubo Li-B47053
Hi, > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + sai->base = devm_ioremap_resource(&pdev->dev, res); > > + if (IS_ERR(sai->base)) { > > + ret = PTR_ERR(sai->base); > > + return ret; > > > could be: > return PTR_ERR(sai->base); > Yes,Thi

Re: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-17 Thread Timur Tabi
Xiubo Li wrote: + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + sai->base = devm_ioremap_resource(&pdev->dev, res); Why not use of_iomap()? ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/list

Re: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-17 Thread Lothar Waßmann
Hi, Xiubo Li wrote: [...] > diff --git a/sound/soc/fsl/fsl-pcm-dma.c b/sound/soc/fsl/fsl-pcm-dma.c > new file mode 100644 > index 000..c4d925e > --- /dev/null > +++ b/sound/soc/fsl/fsl-pcm-dma.c > @@ -0,0 +1,51 @@ [...] > + > +static int fsl_sai_probe(struct platform_device *pdev) > +{ > +