RE: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec.

2013-10-27 Thread Xiubo Li-B47053
> > @@ -883,14 +883,19 @@ static int ldo_regulator_register(struct > snd_soc_codec *codec, > > struct regulator_init_data *init_data, > > int voltage) > > { > > +#ifdef CONFIG_SND_SOC_FSL_SGTL5000 > > + return 0; > > +#else > > dev_err(

Re: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec.

2013-10-21 Thread Timur Tabi
Xiubo Li-B47053 wrote: The CONFIG_SND_SOC_FSL_SGTL5000 micro will be renamed to CONFIG_SND_SOC_FSL_SGTL5000_VF610. In VF610, there has not Power Manager Module, so whether the CONFIG_REGULATOR is enable or Disabled, there will always some errors booting... That's just not acceptable. You hav

Re: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec.

2013-10-21 Thread Lothar Waßmann
Hi, > > > diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c > > > index 1f4093f..4e2e4c9 100644 > > > --- a/sound/soc/codecs/sgtl5000.c > > > +++ b/sound/soc/codecs/sgtl5000.c > > > @@ -883,14 +883,19 @@ static int ldo_regulator_register(struct > > snd_soc_codec *codec, > > >

RE: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec.

2013-10-20 Thread Xiubo Li-B47053
> > diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c > > index 1f4093f..4e2e4c9 100644 > > --- a/sound/soc/codecs/sgtl5000.c > > +++ b/sound/soc/codecs/sgtl5000.c > > @@ -883,14 +883,19 @@ static int ldo_regulator_register(struct > snd_soc_codec *codec, > >

RE: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec.

2013-10-20 Thread Xiubo Li-B47053
> > When the CONFIG_REGULATOR is disabled there will be some warnings > > printed out. > > A little confused by the title. But after looking at the comments, is the > patch just gonna add some debug info for the case when the > CONFIG_REGULATOR's been un-selected? > > Well first, I think at leas

Re: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec.

2013-10-18 Thread Mark Brown
On Thu, Oct 17, 2013 at 05:01:14PM +0800, Xiubo Li wrote: > @@ -883,14 +883,19 @@ static int ldo_regulator_register(struct snd_soc_codec > *codec, > struct regulator_init_data *init_data, > int voltage) > { > +#ifdef CONFIG_SND_SOC_FSL_

Re: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec.

2013-10-17 Thread Lothar Waßmann
Hi, Xiubo Li wrote: > When the CONFIG_REGULATOR is disabled there will be some warnings > printed out. > > Signed-off-by: Xiubo Li > --- > sound/soc/codecs/sgtl5000.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc

Re: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec.

2013-10-17 Thread Nicolin Chen
Hi, On Thu, Oct 17, 2013 at 05:01:14PM +0800, Xiubo Li wrote: > When the CONFIG_REGULATOR is disabled there will be some warnings > printed out. A little confused by the title. But after looking at the comments, is the patch just gonna add some debug info for the case when the CONFIG_REGULATOR's