Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-20 Thread Barry Song
, 2010 9:32 PM >>To: Barry Song >>Cc: David Brownell; Artem Bityutskiy; >>linux-ker...@vger.kernel.org; linuxppc-...@ozlabs.org; >>linux-...@lists.infradead.org; >>uclinux-dist-de...@blackfin.uclinux.org; Andrew Morton >>Subject: Re: [Uclinux-dist-devel] [PATCH 1/2] mt

RE: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-20 Thread Song, Barry
x-ker...@vger.kernel.org; linuxppc-...@ozlabs.org; >linux-...@lists.infradead.org; >uclinux-dist-de...@blackfin.uclinux.org; Andrew Morton >Subject: Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: >Reworkprobing/JEDEC code > >On Sat, Jun 12, 2010 at 02:27:12PM +0800, Barry S

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-21 Thread Anton Vorontsov
On Mon, Jun 21, 2010 at 11:27:31AM +0800, Barry Song wrote: [...] > > How about we add a non_jedec flag in platform_data, if the flag is 1, we > > let the detection pass even though the ID is 0? Otherwise, we need a > > valid ID? > Here i mean: This will break at least OF-enabled platforms (e.g. P

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-21 Thread Barry Song
On Mon, Jun 21, 2010 at 3:15 PM, Anton Vorontsov wrote: > On Mon, Jun 21, 2010 at 11:27:31AM +0800, Barry Song wrote: > [...] >> > How about we add a non_jedec flag in platform_data, if the flag is 1, we >> > let the detection pass even though the ID is 0? Otherwise, we need a >> > valid ID? >> He

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-21 Thread Anton Vorontsov
On Mon, Jun 21, 2010 at 03:22:48PM +0800, Barry Song wrote: > On Mon, Jun 21, 2010 at 3:15 PM, Anton Vorontsov > wrote: > > On Mon, Jun 21, 2010 at 11:27:31AM +0800, Barry Song wrote: > > [...] > >> > How about we add a non_jedec flag in platform_data, if the flag is 1, we > >> > let the detectio

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-21 Thread Barry Song
On Mon, Jun 21, 2010 at 3:39 PM, Anton Vorontsov wrote: > On Mon, Jun 21, 2010 at 03:22:48PM +0800, Barry Song wrote: >> On Mon, Jun 21, 2010 at 3:15 PM, Anton Vorontsov >> wrote: >> > On Mon, Jun 21, 2010 at 11:27:31AM +0800, Barry Song wrote: >> > [...] >> >> > How about we add a non_jedec fla

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-21 Thread Anton Vorontsov
On Mon, Jun 21, 2010 at 06:31:44PM +0800, Barry Song wrote: > On Mon, Jun 21, 2010 at 3:39 PM, Anton Vorontsov > wrote: > > On Mon, Jun 21, 2010 at 03:22:48PM +0800, Barry Song wrote: > >> On Mon, Jun 21, 2010 at 3:15 PM, Anton Vorontsov > >> wrote: > >> > On Mon, Jun 21, 2010 at 11:27:31AM +08

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-21 Thread Mike Frysinger
On Mon, Jun 21, 2010 at 07:20, Anton Vorontsov wrote: > You can't easily change OF. It's like "let's change ACPI tables > or BIOS in these PCs". Doable, but involves things like reflashing. > And we usually have to support old BIOSes as well. > > OTOH, I see (git grep m25p arch/powerpc/boot/dts/) t

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-21 Thread Anton Vorontsov
On Mon, Jun 21, 2010 at 12:34:05PM -0400, Mike Frysinger wrote: > On Mon, Jun 21, 2010 at 07:20, Anton Vorontsov wrote: > > You can't easily change OF. It's like "let's change ACPI tables > > or BIOS in these PCs". Doable, but involves things like reflashing. > > And we usually have to support old

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-21 Thread Mike Frysinger
On Mon, Jun 21, 2010 at 12:47, Anton Vorontsov wrote: > On Mon, Jun 21, 2010 at 12:34:05PM -0400, Mike Frysinger wrote: >> On Mon, Jun 21, 2010 at 07:20, Anton Vorontsov wrote: >> > You can't easily change OF. It's like "let's change ACPI tables >> > or BIOS in these PCs". Doable, but involves thin

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-22 Thread Barry Song
On Mon, Jun 21, 2010 at 7:20 PM, Anton Vorontsov wrote: > On Mon, Jun 21, 2010 at 06:31:44PM +0800, Barry Song wrote: >> On Mon, Jun 21, 2010 at 3:39 PM, Anton Vorontsov >> wrote: >> > On Mon, Jun 21, 2010 at 03:22:48PM +0800, Barry Song wrote: >> >> On Mon, Jun 21, 2010 at 3:15 PM, Anton Voront

Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code

2010-06-22 Thread Anton Vorontsov
On Tue, Jun 22, 2010 at 02:37:52PM +0800, Barry Song wrote: [...] > >                jid = jedec_probe(spi); > >                if (!jid) { > > -                       dev_info(&spi->dev, "non-JEDEC variant of %s\n", > > -                                id->name); > > +                       return