Re: [PATCH] TTY: hvc_console, fix port reference count going to zero prematurely

2012-11-14 Thread Paul Mackerras
On Wed, Nov 14, 2012 at 12:54:07PM -0800, Greg KH wrote: > On Thu, Nov 15, 2012 at 07:48:17AM +1100, Benjamin Herrenschmidt wrote: > > On Wed, 2012-11-14 at 07:09 -0800, Greg KH wrote: > > > > So who's merging it ? > > > > > > Give me a chance to at least wake up please :) > > > > Sure ;-) Just a

Re: [PATCH] TTY: hvc_console, fix port reference count going to zero prematurely

2012-11-14 Thread Benjamin Herrenschmidt
On Wed, 2012-11-14 at 12:54 -0800, Greg KH wrote: > > Thanks ! It should go into stable 3.6 as well. > > Why? The offending patch didn't show up until 3.7-rc1. Ah, my bad, I though Paulus had observed the problem with 3.6 as well but it looks like you are right. So 3.7 then. Thanks. Cheers, Be

Re: [PATCH] TTY: hvc_console, fix port reference count going to zero prematurely

2012-11-14 Thread Greg KH
On Thu, Nov 15, 2012 at 07:48:17AM +1100, Benjamin Herrenschmidt wrote: > On Wed, 2012-11-14 at 07:09 -0800, Greg KH wrote: > > > So who's merging it ? > > > > Give me a chance to at least wake up please :) > > Sure ;-) Just asking since I'm about to cook up a powerpc batch :-) It's now in my tr

Re: [PATCH] TTY: hvc_console, fix port reference count going to zero prematurely

2012-11-14 Thread Benjamin Herrenschmidt
On Wed, 2012-11-14 at 07:09 -0800, Greg KH wrote: > > So who's merging it ? > > Give me a chance to at least wake up please :) Sure ;-) Just asking since I'm about to cook up a powerpc batch :-) > I will. Thanks ! It should go into stable 3.6 as well. Cheers, Ben. ___

Re: [PATCH] TTY: hvc_console, fix port reference count going to zero prematurely

2012-11-14 Thread Greg KH
On Wed, Nov 14, 2012 at 11:47:59PM +1100, Benjamin Herrenschmidt wrote: > On Wed, 2012-11-14 at 10:45 +0100, Jiri Slaby wrote: > > > > This fixes it by removing the extra kref_put() and tty_kref_put() calls. > > > > Oh yeah. Thanks. > > > > Acked-by: Jiri Slaby > > So who's merging it ? Give

Re: [PATCH] TTY: hvc_console, fix port reference count going to zero prematurely

2012-11-14 Thread Benjamin Herrenschmidt
On Wed, 2012-11-14 at 10:45 +0100, Jiri Slaby wrote: > > This fixes it by removing the extra kref_put() and tty_kref_put() calls. > > Oh yeah. Thanks. > > Acked-by: Jiri Slaby So who's merging it ? Cheers, Ben. > > Signed-off-by: Paul Mackerras > > Cc: sta...@vger.kernel.org > > --- > > dr

Re: [PATCH] TTY: hvc_console, fix port reference count going to zero prematurely

2012-11-14 Thread Jiri Slaby
On 11/14/2012 09:15 AM, Paul Mackerras wrote: > Commit bdb498c20040 "TTY: hvc_console, add tty install" took the port > refcounting out of hvc_open()/hvc_close(), but failed to remove the > kref_put() and tty_kref_put() calls in hvc_hangup() that were there to > remove the extra references that hvc