Re: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Grant Grundler
On Sun, Nov 15, 2009 at 10:19 PM, Vivek Mahajan wrote: > The following patch adds MSI support. Some platforms > may have broken MSI, so those are defaulted to use > legacy PCI interrupts. > > Signed-off-by: Vivek Mahajan > --- >  drivers/ata/sata_sil24.c |    9 + >  1 files changed, 9 ins

Re: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Jeff Garzik
On 11/16/2009 01:19 AM, Vivek Mahajan wrote: The following patch adds MSI support. Some platforms may have broken MSI, so those are defaulted to use legacy PCI interrupts. Signed-off-by: Vivek Mahajan --- drivers/ata/sata_sil24.c |9 + 1 files changed, 9 insertions(+), 0 deletions

RE: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Mahajan Vivek-B08308
> From: Grant Grundler [mailto:grund...@google.com] > Sent: Monday, November 16, 2009 11:08 PM > > +static int sata_sil24_msi;    /* Disable MSI */ > > +module_param_named(msi, sata_sil24_msi, bool, S_IRUGO); > > +MODULE_PARM_DESC(msi, "Enable MSI (Default: false)"); > > Vivek, > Do we even sti

Re: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Jeff Garzik
On 11/17/2009 01:59 AM, Mahajan Vivek-B08308 wrote: From: Grant Grundler [mailto:grund...@google.com] Sent: Monday, November 16, 2009 11:08 PM +static int sata_sil24_msi;/* Disable MSI */ +module_param_named(msi, sata_sil24_msi, bool, S_IRUGO); +MODULE_PARM_DESC(msi, "Enable MSI (Default: fa

RE: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-17 Thread Mahajan Vivek-B08308
> From: Jeff Garzik [mailto:j...@garzik.org] > Sent: Tuesday, November 17, 2009 1:12 PM > > In this case "msi" is supposed to be passed via insmod and not via > > kernel cmdline. If the driver is built-in the kernel, then force > > sata_sil24_msi = 1 in the driver to enable it. > > First, the o