Re: [RFC] [PATCH v2] MPC5121 TLB errata workaround

2009-03-16 Thread Kumar Gala
On Mar 16, 2009, at 5:44 AM, David Jander wrote: On Friday 13 March 2009 16:23:15 Kumar Gala wrote: [...] This errata impacts a number of cores and so we should make this a CPU feature fixup rather than #ifdef code. It should impact only MPC5121e and probably MPC5123, but according to Fr

Re: [RFC] [PATCH v2] MPC5121 TLB errata workaround

2009-03-16 Thread David Jander
On Friday 13 March 2009 16:23:15 Kumar Gala wrote: >[...] > >> This errata impacts a number of cores and so we should make this a > >> CPU > >> feature fixup rather than #ifdef code. > > > > It should impact only MPC5121e and probably MPC5123, but according to > > Freescale no other processors that

Re: [RFC] [PATCH v2] MPC5121 TLB errata workaround

2009-03-13 Thread Kumar Gala
On Mar 13, 2009, at 9:24 AM, David Jander wrote: On Friday 13 March 2009 14:21:57 Kumar Gala wrote: What does cat /proc/cpuinfo show on this board? # cat /proc/cpuinfo processor : 0 cpu : e300c4 clock : 400.00MHz revision: 1.0 (pvr 8086 2010) bogomi

Re: [RFC] [PATCH v2] MPC5121 TLB errata workaround

2009-03-13 Thread David Jander
On Friday 13 March 2009 14:21:57 Kumar Gala wrote: > > > > What does cat /proc/cpuinfo show on this board? # cat /proc/cpuinfo processor : 0 cpu : e300c4 clock : 400.00MHz revision: 1.0 (pvr 8086 2010) bogomips: 99.84 timebase: 5000 plat

Re: [RFC] [PATCH v2] MPC5121 TLB errata workaround

2009-03-13 Thread David Jander
On Friday 13 March 2009 14:22:22 Kumar Gala wrote: > > On Mar 13, 2009, at 5:26 AM, David Jander wrote: > > > > > Forgot to mention: The patch is based on denx git tree head > > 'ads5121', but > > it should apply without problem (some offset at most) to mainline. > > > > Best regards, > > > >

Re: [RFC] [PATCH v2] MPC5121 TLB errata workaround

2009-03-13 Thread Kumar Gala
On Mar 13, 2009, at 5:26 AM, David Jander wrote: Forgot to mention: The patch is based on denx git tree head 'ads5121', but it should apply without problem (some offset at most) to mainline. Best regards, Out of interest did this version produce better performance on the benchmarks th

Re: [RFC] [PATCH v2] MPC5121 TLB errata workaround

2009-03-13 Thread Kumar Gala
What does cat /proc/cpuinfo show on this board? +#ifdef CONFIG_PPC_MPC512x +/* MPC512x: workaround for errata in die M36P and earlier: + * Implement LRW for TLB way. + */ This errata impacts a number of cores and so we should make this a CPU feature fixup rather than #ifdef code. +

Re: [RFC] [PATCH v2] MPC5121 TLB errata workaround

2009-03-13 Thread David Jander
Forgot to mention: The patch is based on denx git tree head 'ads5121', but it should apply without problem (some offset at most) to mainline. Best regards, -- David Jander Protonic Holland. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https: