Re: [Skiboot] [v2, 1/3] powerpc/powernv: convert codes returned by OPAL calls

2015-03-27 Thread Cedric Le Goater
On 03/27/2015 11:36 AM, Benjamin Herrenschmidt wrote: On Fri, 2015-03-27 at 20:59 +1100, Michael Ellerman wrote: Can you put it in opal.h and give it a better name, maybe opal_error_code() ? Do we want it to be inlined all the time ? Feels more like something we should have in opal.c

Re: [Skiboot] [v2, 1/3] powerpc/powernv: convert codes returned by OPAL calls

2015-03-27 Thread Benjamin Herrenschmidt
On Fri, 2015-03-27 at 20:59 +1100, Michael Ellerman wrote: Can you put it in opal.h and give it a better name, maybe opal_error_code() ? Do we want it to be inlined all the time ? Feels more like something we should have in opal.c Also we only want to call it when we forward the error code