Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-28 Thread Christian Brauner
On Mon, Nov 27, 2023 at 09:10:54AM -0800, Linus Torvalds wrote: > On Mon, 27 Nov 2023 at 02:27, Christian Brauner wrote: > > > > So I've picked up your patch (vfs.misc). It's clever alright so thanks > > for the comments in there otherwise I would've stared at this for far > > too long. > > Note

Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-27 Thread Linus Torvalds
On Mon, 27 Nov 2023 at 02:27, Christian Brauner wrote: > > So I've picked up your patch (vfs.misc). It's clever alright so thanks > for the comments in there otherwise I would've stared at this for far > too long. Note that I should probably have commented on one other thing: that whole "just

Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-27 Thread Christian Brauner
> So that nobody else would waste any time on this, attached is a new > attempt. This time actually tested *after* the changes. So I've picked up your patch (vfs.misc). It's clever alright so thanks for the comments in there otherwise I would've stared at this for far too long. It's a little

Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-27 Thread Christian Brauner
> I took a look at the code generation, and honestly, I think we're > better off just making __fget_files_rcu() have special logic for this > all, and not use __get_file_rcu(). My initial massaging of the patch did that btw. Then I sat there wondering whether it would matter if we just made it

Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-26 Thread Oliver Sang
hi, Linus, On Sun, Nov 26, 2023 at 03:20:58PM -0800, Linus Torvalds wrote: > On Sun, 26 Nov 2023 at 12:23, Linus Torvalds > wrote: > > > > IOW, I might have messed up some "trivial cleanup" when prepping for > > sending it out... > > Bah. Famous last words. One of the "trivial cleanups" made

Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-26 Thread Linus Torvalds
On Sun, 26 Nov 2023 at 12:23, Linus Torvalds wrote: > > IOW, I might have messed up some "trivial cleanup" when prepping for > sending it out... Bah. Famous last words. One of the "trivial cleanups" made the code more "obvious" by renaming the nospec mask as just "mask". And that trivial rename

Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-26 Thread Linus Torvalds
On Sun, 19 Nov 2023 at 23:11, kernel test robot wrote: > > kernel test robot noticed a -2.9% regression of will-it-scale.per_thread_ops > on: > > commit: 0ede61d8589cc2d93aa78230d74ac58b5b8d0244 ("file: convert to > SLAB_TYPESAFE_BY_RCU") Ok, so __fget_light() is one of our more

Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

2023-11-19 Thread Mateusz Guzik
On Mon, Nov 20, 2023 at 03:11:31PM +0800, kernel test robot wrote: > > > Hello, > > kernel test robot noticed a -2.9% regression of will-it-scale.per_thread_ops > on: > > > commit: 0ede61d8589cc2d93aa78230d74ac58b5b8d0244 ("file: convert to > SLAB_TYPESAFE_BY_RCU") >