Re: [patch 1/5] powerpc: Sky CPU: redundant or incorrect tests on unsigned

2009-12-17 Thread Benjamin Herrenschmidt
On Fri, 2009-12-18 at 14:40 +1100, Benjamin Herrenschmidt wrote: > On Thu, 2009-12-17 at 16:44 -0800, a...@linux-foundation.org wrote: > > From: Roel Kluin > > > > count is unsigned and cannot be less than 0. > > Is this really a powerpc thing ? > > This driver is only build with CONFIG_HDPU_FE

Re: [patch 1/5] powerpc: Sky CPU: redundant or incorrect tests on unsigned

2009-12-17 Thread Benjamin Herrenschmidt
On Thu, 2009-12-17 at 16:44 -0800, a...@linux-foundation.org wrote: > From: Roel Kluin > > count is unsigned and cannot be less than 0. Is this really a powerpc thing ? This driver is only build with CONFIG_HDPU_FEATURES and a git grep HDPU_FEATURES returns no Kconfig that defines it :-) I'm h