On Wed, 2018-12-05 at 19:50:25 UTC, Rob Herring wrote:
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
>
> Cc: "David S. Miller"
> Cc: Benjamin Herrenschmidt
> Cc: Paul Mackerras
> Cc: Michael Ellerman
> C
On Tue, 2017-07-18 at 21:43:07 UTC, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring
> Cc: "David S. Miller"
> Cc
On Fri, 20 Mar 2009 12:40:29 +0100
Bartlomiej Zolnierkiewicz wrote:
> Moreover the underlying issue is non-PMAC specific and asks for generic
> resolution, please see:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=12734#c13
>
> for previous discussion.
>
> In the very least case it shou
On Thu, 2009-03-19 at 22:30 +0900, TOMARI Hisanobu wrote:
> Thanks for helpful advices.
> This patch adds an option to drivers/ide/Kconfig and adds
> some lines to drivers/ide/pmac.c . Now the driver checks
> if the model is prefixed with "PowerBook" and the entire hack
> can be toggled in the Kco
On Thu, 2009-03-19 at 16:41 +0300, Anton Vorontsov wrote:
>
> The other option is to enable BLK_DEV_IDE_PMAC_SHORTCABLE by default,
> but I'm not sure if it's safe thing to do (most probably not).
It should be allright for powerbooks. If the firmware says 80 pin cable,
then it probably is, and in
On Thu, Mar 19, 2009 at 10:30:01PM +0900, TOMARI Hisanobu wrote:
> Thanks for helpful advices.
> This patch adds an option to drivers/ide/Kconfig and adds
> some lines to drivers/ide/pmac.c .
I think it would be better to make it a kernel command line option
instead of Kconfig knob.
The reason i
Thanks for helpful advices.
This patch adds an option to drivers/ide/Kconfig and adds
some lines to drivers/ide/pmac.c . Now the driver checks
if the model is prefixed with "PowerBook" and the entire hack
can be toggled in the Kconfig.
Again, the patch is against linux 2.6.28.8.
Best regards,
TO
On Thu, 2009-03-19 at 17:07 +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2009-03-18 at 22:47 +0900, TOMARI Hisanobu wrote:
> > I thought the short-40pin assumption would cause no problem
> > considering all models beginning with "PowerBook5" are laptops.
> > Do you mean an option to toggle this h
On Wed, 2009-03-18 at 22:47 +0900, TOMARI Hisanobu wrote:
> I thought the short-40pin assumption would cause no problem
> considering all models beginning with "PowerBook5" are laptops.
> Do you mean an option to toggle this hack on/off should be present
> in Kconfig?
Actually, it makes -some- am
I thought the short-40pin assumption would cause no problem
considering all models beginning with "PowerBook5" are laptops.
Do you mean an option to toggle this hack on/off should be present
in Kconfig?
Thanks,
TOMARI Hisanobu
On Wed, 18 Mar 2009 18:58:17 +1100
Benjamin Herrenschmidt wrote:
>
On Wed, 2009-03-18 at 14:06 +0900, TOMARI Hisanobu wrote:
> Hello,
>
> I'm using an OCZ PATA SSD on Apple PowerBook5,4 computer.
> The IDE drive fails to recognize 80-conductor cable that
> connects the drive to motherboard to fall back to UDMA33.
>
> This patch fixes this behavior by assuming th
Hello.
Sébastien Chrétien wrote:
I saw pata_of_platform source. And when is called pata_of_platform_probe ?
Look at the very end of arch/powerpc/boot/dts/mpc8349emitx.dts;
probably there are more examples in that directory...
MBR, Sergei
___
I saw pata_of_platform source. And when is called pata_of_platform_probe ?
2008/9/11, Sébastien Chrétien <[EMAIL PROTECTED]>:
>
> Where can I find a pata_of_platform node example ?
>
> Sergei Shtylyov a écrit :
>
>> Arnd Bergmann wrote:
>>
>> Most probably you can use the existing platform drive
Where can I find a pata_of_platform node example ?
Sergei Shtylyov a écrit :
Arnd Bergmann wrote:
Most probably you can use the existing platform drivers:
drivers/ide/egacy/ide_platform.c or drivers/ata/pata_platform.c.
Create/register a platform device named "pata_platform" with 2
memory a
ok I will use the flat device tree.
Do you utils in order to use ata and check ata link ?
For example, to read some information of my compact flash
2008/9/10, Sergei Shtylyov <[EMAIL PROTECTED]>:
>
> Arnd Bergmann wrote:
>
> Most probably you can use the existing platform drivers:
>>> drivers/id
Arnd Bergmann wrote:
Most probably you can use the existing platform drivers:
drivers/ide/egacy/ide_platform.c or drivers/ata/pata_platform.c.
Create/register a platform device named "pata_platform" with 2 memory
and 1 IRQ resource, and enable one of those drivers.
For new boards using a f
On Wednesday 10 September 2008, Sébastien Chrétien wrote:
> I looked falconide.c, it uses hw_regs_t hw; and ide_hwif_t *hwif.
> Is it a good way ?
>
No, that uses the legacy IDE drivers, not the current ATA drivers,
and it is not based on the device tree information.
Just use drivers/ata/pat
I looked falconide.c, it uses hw_regs_t hw; and ide_hwif_t *hwif.
Is it a good way ?
2008/9/10, Arnd Bergmann <[EMAIL PROTECTED]>:
>
> On Wednesday 10 September 2008, Sergei Shtylyov wrote:
> >Most probably you can use the existing platform drivers:
> > drivers/ide/egacy/ide_platform.c or
On Wednesday 10 September 2008, Sergei Shtylyov wrote:
> Most probably you can use the existing platform drivers:
> drivers/ide/egacy/ide_platform.c or drivers/ata/pata_platform.c.
> Create/register a platform device named "pata_platform" with 2 memory
> and 1 IRQ resource, and enable one of t
Hello.
Sébastien Chrétien wrote:
Have I to rewrite a IDE driver ?
Most probably you can use the existing platform drivers:
drivers/ide/egacy/ide_platform.c or drivers/ata/pata_platform.c.
Create/register a platform device named "pata_platform" with 2 memory
and 1 IRQ resource, and enable
It is a common ide controller :
offset 0x0 Data
offset 0x1 error
offset 0x2 Sector count
offset 0x3 sector No
offset 0x4 Cylinder low
offset 0x5 Cylinder High
offset 0x6 Head
offset 0x7 status
2008/9/10, Sergei Shtylyov <[EMAIL PROTECTED]>:
>
> Hello.
>
> Sébastien Chrétien wrote:
>
> I would lik
Have I to rewrite a IDE driver ?
2008/9/10, Sergei Shtylyov <[EMAIL PROTECTED]>:
>
> Hello.
>
> Sébastien Chrétien wrote:
>
> I would like to setup my IDE controller. It uses a generic mapping. And he
>> is located at the adress 0x20003000.
>>
>
> What kin of controller, and what do you mean by
Hello.
Sébastien Chrétien wrote:
I would like to setup my IDE controller. It uses a generic mapping.
And he is located at the adress 0x20003000.
What kin of controller, and what do you mean by generic mapping?
How can I specifie this adress to the ide driver ?
The usual ways is via th
On Fri, 2008-08-01 at 12:54 +0200, Bartlomiej Zolnierkiewicz wrote:
> On Thursday 31 July 2008, Bartlomiej Zolnierkiewicz wrote:
>
> [...]
>
> Sorry if my mails were a bit harsh but nobody likes to be pushed around.
>
> [ It is not like I don't want to add proper hot-plugging support or do test
On Thursday 31 July 2008, Bartlomiej Zolnierkiewicz wrote:
[...]
Sorry if my mails were a bit harsh but nobody likes to be pushed around.
[ It is not like I don't want to add proper hot-plugging support or do test
on more hardware but my time schedule is already tight enough and there are
s
On Thursday 31 July 2008, Benjamin Herrenschmidt wrote:
>
> > Is it actually caused by additional reference counting on drive->gendev?
> > IOW if you reverse the patch below instead of applying the previous fix
> > do things work OK again?
> >
> > > Note that there shouldn't be anything fundament
On Thu, 2008-07-31 at 10:13 +0100, Alan Cox wrote:
> > I could make the media-bay look like a controller hotplug if it was
> > going to make things easier...
>
> I'm not sure it will. It may do nowdays, but the older IDE code
> historically was fairly broken for both cases except in 2.4. Also faki
> I could make the media-bay look like a controller hotplug if it was
> going to make things easier...
I'm not sure it will. It may do nowdays, but the older IDE code
historically was fairly broken for both cases except in 2.4. Also faking
it as controller hotplug is the wrong path for libata whic
On Thu, 2008-07-31 at 09:49 +0100, Alan Cox wrote:
> > There seems to be some confusion between warm-plugging of IDE devices
> > and hot-plugging of IDE devices.
> >
> > > not a single piece of HW to exercise those code path ? I don't ask you
> > > to get a powermac with a media-bay, but ide_cs se
> There seems to be some confusion between warm-plugging of IDE devices
> and hot-plugging of IDE devices.
>
> > not a single piece of HW to exercise those code path ? I don't ask you
> > to get a powermac with a media-bay, but ide_cs seems to be a pretty
> > important one that's part of what the
> Is it actually caused by additional reference counting on drive->gendev?
> IOW if you reverse the patch below instead of applying the previous fix
> do things work OK again?
>
> > Note that there shouldn't be anything fundamentally different from
> > ide-pmac here vs. something like pcmcia IDE
On Thursday 31 July 2008, Benjamin Herrenschmidt wrote:
> On Thu, 2008-07-31 at 02:48 +0200, Bartlomiej Zolnierkiewicz wrote:
> > There seems to be some confusion between warm-plugging of IDE devices
> > and hot-plugging of IDE devices.
> >
> > > not a single piece of HW to exercise those code pat
On Thu, 2008-07-31 at 02:48 +0200, Bartlomiej Zolnierkiewicz wrote:
> There seems to be some confusion between warm-plugging of IDE devices
> and hot-plugging of IDE devices.
>
> > not a single piece of HW to exercise those code path ? I don't ask you
> > to get a powermac with a media-bay, but id
On Thursday 31 July 2008, Benjamin Herrenschmidt wrote:
> On Wed, 2008-07-30 at 21:11 +0200, Bartlomiej Zolnierkiewicz wrote:
> >
> > > Note that there shouldn't be anything fundamentally different from
> > > ide-pmac here vs. something like pcmcia IDE cards... do you have one
> > of
> > > these t
On Wed, 2008-07-30 at 21:11 +0200, Bartlomiej Zolnierkiewicz wrote:
>
> > Note that there shouldn't be anything fundamentally different from
> > ide-pmac here vs. something like pcmcia IDE cards... do you have one
> of
> > these to test with ?
>
> Nope and I really don't intend to have one. I co
On Wednesday 30 July 2008, Benjamin Herrenschmidt wrote:
> On Tue, 2008-07-29 at 21:26 +0200, Bartlomiej Zolnierkiewicz wrote:
>
> > I WON!!!
>
> Only half...
Heh, I wasn't talking about fixing the issue...
(hint: look up the author of the bad commit).
> It goes further and then blows up again.
On Tue, 2008-07-29 at 21:26 +0200, Bartlomiej Zolnierkiewicz wrote:
> I WON!!!
Only half...
It goes further and then blows up again. First problem is, this
unregister interface doesn't quite convey the fact that the HW is gone
and the IDE code seems to take it's sweet time figuring it out after
On Tue, 29 Jul 2008 21:26:11 +0200
Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote:
> On Tuesday 29 July 2008, Bartlomiej Zolnierkiewicz wrote:
> > On Tuesday 29 July 2008, Bartlomiej Zolnierkiewicz wrote:
> > > On Tuesday 29 July 2008, Benjamin Herrenschmidt wrote:
> > > > On Tue, 2008-07-29
> I WON!!!
Heh, great :-)
I'll give you patch a try, thanks !
Cheers,
Ben.
> From: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
> Subject: [PATCH] ide: fix regression caused by ide_device_{get,put}() addition
>
> On Monday 28 July 2008, Benjamin Herrenschmidt wrote:
>
> [...]
>
> > Vector:
On Tuesday 29 July 2008, Bartlomiej Zolnierkiewicz wrote:
> On Tuesday 29 July 2008, Bartlomiej Zolnierkiewicz wrote:
> > On Tuesday 29 July 2008, Benjamin Herrenschmidt wrote:
> > > On Tue, 2008-07-29 at 13:41 +0200, Bartlomiej Zolnierkiewicz wrote:
> > > > > Well, all I do is call into Bart's new
On Tuesday 29 July 2008, Bartlomiej Zolnierkiewicz wrote:
> On Tuesday 29 July 2008, Benjamin Herrenschmidt wrote:
> > On Tue, 2008-07-29 at 13:41 +0200, Bartlomiej Zolnierkiewicz wrote:
> > > > Well, all I do is call into Bart's new helpers to scan for or
> > > unregister
> > > > devices ...
> > >
On Tuesday 29 July 2008, Benjamin Herrenschmidt wrote:
> On Tue, 2008-07-29 at 13:41 +0200, Bartlomiej Zolnierkiewicz wrote:
> > > Well, all I do is call into Bart's new helpers to scan for or
> > unregister
> > > devices ...
> >
> > The switch to these helpers happened _before_ 2.6.26 and it shou
On Tue, 2008-07-29 at 13:41 +0200, Bartlomiej Zolnierkiewicz wrote:
> > Well, all I do is call into Bart's new helpers to scan for or
> unregister
> > devices ...
>
> The switch to these helpers happened _before_ 2.6.26 and it shouldn't
> bring
> such behavior change (ditto for new IDE host additi
On Tuesday 29 July 2008, Benjamin Herrenschmidt wrote:
> On Tue, 2008-07-29 at 14:17 +0900, FUJITA Tomonori wrote:
> > If q->elevator is NULL, the media-bay code might mess up the ref
> > counting of the request queue...
>
> Well, all I do is call into Bart's new helpers to scan for or unregister
On Mon, 28 Jul 2008 16:31:56 +0200
Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote:
> > > However, the machine crashes when removing the media-bay CD-ROM drive.
> > >
> > > Crash appears to be a NULL deref, possibly in elv_may_queue() though
> > > I don't have a clean backtrace yet, working o
On Tue, 2008-07-29 at 14:17 +0900, FUJITA Tomonori wrote:
> If q->elevator is NULL, the media-bay code might mess up the ref
> counting of the request queue...
Well, all I do is call into Bart's new helpers to scan for or unregister
devices ...
Ben.
_
On Monday 28 July 2008, Benjamin Herrenschmidt wrote:
> On Mon, 2008-07-28 at 11:29 +1000, Benjamin Herrenschmidt wrote:
> > The current ide-pmac upstream is broken. It calls
> > media_bay_set_ide_infos() with an uninitialized "hwif" argument.
> >
> > It's not a trivial mistake, there's a chicken-
On Mon, 2008-07-28 at 11:29 +1000, Benjamin Herrenschmidt wrote:
> The current ide-pmac upstream is broken. It calls
> media_bay_set_ide_infos() with an uninitialized "hwif" argument.
>
> It's not a trivial mistake, there's a chicken-and-egg problem in the
> init code in there.
>
> I've locally f
48 matches
Mail list logo
