On Thu, Apr 17, 2008 at 01:26:23PM -0400, Sean MacLennan wrote:
> On Thu, 17 Apr 2008 09:08:04 -0700
> "Dale Farnsworth" <[EMAIL PROTECTED]> wrote:
>
> > I didn't suggest splitting the patches or further modification of the
> > patches themselves. What I found lacking were the patch descriptions.
On Thu, 17 Apr 2008 09:08:04 -0700
"Dale Farnsworth" <[EMAIL PROTECTED]> wrote:
> I didn't suggest splitting the patches or further modification of the
> patches themselves. What I found lacking were the patch descriptions.
> You need to describe in each patch (commit) commentary exactly what
> t
On Thu, Apr 17, 2008 at 11:50:45AM -0400, Sean MacLennan wrote:
> On Sat, 12 Apr 2008 20:13:16 -0700
> "Dale Farnsworth" <[EMAIL PROTECTED]> wrote:
>
> > Each patch needs to be standalone. you need to add a header
> > describing what the patch is intended to accomplish. Being more
> > descriptiv
On Sat, 12 Apr 2008 20:13:16 -0700
"Dale Farnsworth" <[EMAIL PROTECTED]> wrote:
> Each patch needs to be standalone. you need to add a header
> describing what the patch is intended to accomplish. Being more
> descriptive is better than less. Also, as Stephen said, make sure
> that the subject
In article <[EMAIL PROTECTED]> you write:
>
> > A changelog of "updates a bunch of stuff" is pretty much irrelevant in
> > all situations I can think of.
>
> Ok, I hope I got everything:
>
> Changes to match new FPGA/HW functionality.
> * Switched from 64M NOR/64M NAND to 4M NOR/256M NAND.
> *
Sean MacLennan writes:
> I was going to hold off until the warp was officially released, but we
> might miss the merge window. So here they are. A lot of work has been
> done since 2.6.25 and I haven't been submitting patches to keep down on
> the churn.
Your patches don't have any description a
> A changelog of "updates a bunch of stuff" is pretty much irrelevant in
> all situations I can think of.
Ok, I hope I got everything:
Changes to match new FPGA/HW functionality.
* Switched from 64M NOR/64M NAND to 4M NOR/256M NAND.
* Moved/resized partitions to match the flash changes.
* Fixup
On Sat, 2008-04-12 at 13:48 -0400, Sean MacLennan wrote:
> I was going to hold off until the warp was officially released, but we
> might miss the merge window. So here they are. A lot of work has been
> done since 2.6.25 and I haven't been submitting patches to keep down on
> the churn.
That's fa
On Sat, Apr 12, 2008 at 7:55 PM, Sean MacLennan <[EMAIL PROTECTED]> wrote:
> On Sun, 13 Apr 2008 10:44:30 +1000
> "Stephen Rothwell" <[EMAIL PROTECTED]> wrote:
>
> > Hi Sean,
> >
> > First comment is that you need reasonable changelogs i.e. explain why
> > you are making changes as well as wha
On Sun, 13 Apr 2008 10:44:30 +1000
"Stephen Rothwell" <[EMAIL PROTECTED]> wrote:
> Hi Sean,
>
> First comment is that you need reasonable changelogs i.e. explain why
> you are making changes as well as what they do. Also the first line
> of each changelog (which becomes the subject of any mail g
On Sun, 2008-04-13 at 10:44 +1000, Stephen Rothwell wrote:
> Hi Sean,
>
> First comment is that you need reasonable changelogs i.e. explain why you
> are making changes as well as what they do. Also the first line of each
> changelog (which becomes the subject of any mail generated from git)
> sh
Hi Sean,
First comment is that you need reasonable changelogs i.e. explain why you
are making changes as well as what they do. Also the first line of each
changelog (which becomes the subject of any mail generated from git)
should be a useful and relatively unique summary.
--
Cheers,
Stephen Ro
12 matches
Mail list logo
