Re: warnings from drivers/tty/ehv_bytechan.c

2012-02-20 Thread Tabi Timur-B04825
Stephen Rothwell wrote: > console_initcall() is not defined for modules. Hmmm... the patch you posted is a good short-term fix, but I wonder if makes sense for the driver to support modules at all. I have this in the driver: #include ... module_init(ehv_bc_init); module_exit(ehv_bc_exit); al

Re: warnings from drivers/tty/ehv_bytechan.c

2012-02-24 Thread gre...@linuxfoundation.org
On Mon, Feb 20, 2012 at 01:24:22PM +, Tabi Timur-B04825 wrote: > Stephen Rothwell wrote: > > console_initcall() is not defined for modules. > > Hmmm... the patch you posted is a good short-term fix, but I wonder if > makes sense for the driver to support modules at all. I have this in the >

Re: warnings from drivers/tty/ehv_bytechan.c

2012-02-24 Thread Timur Tabi
gre...@linuxfoundation.org wrote: > Sure, something like that is fine, but if the code really can't be a > module, why not just fix the Kconfig file to enforce this properly > instead? That's the simplest approach, for use. The TTY portion of the driver can be used as a module. Is there any real

Re: warnings from drivers/tty/ehv_bytechan.c

2012-02-24 Thread gre...@linuxfoundation.org
On Fri, Feb 24, 2012 at 04:00:12PM -0600, Timur Tabi wrote: > gre...@linuxfoundation.org wrote: > > Sure, something like that is fine, but if the code really can't be a > > module, why not just fix the Kconfig file to enforce this properly > > instead? > > That's the simplest approach, for use. T

Re: warnings from drivers/tty/ehv_bytechan.c

2012-02-24 Thread Timur Tabi
gre...@linuxfoundation.org wrote: >> > That's the simplest approach, for use. The TTY portion of the driver can >> > be used as a module. Is there any real value in loading a TTY driver as a >> > module? > Depends on the hardware it supports :) > >> > In this case, the console support for byte

Re: warnings from drivers/tty/ehv_bytechan.c

2012-02-24 Thread gre...@linuxfoundation.org
On Fri, Feb 24, 2012 at 04:15:04PM -0600, Timur Tabi wrote: > gre...@linuxfoundation.org wrote: > >> > That's the simplest approach, for use. The TTY portion of the driver can > >> > be used as a module. Is there any real value in loading a TTY driver as > >> > a > >> > module? > > > Depends on

Re: warnings from drivers/tty/ehv_bytechan.c

2012-02-24 Thread Scott Wood
On 02/24/2012 04:15 PM, Timur Tabi wrote: > gre...@linuxfoundation.org wrote: That's the simplest approach, for use. The TTY portion of the driver can be used as a module. Is there any real value in loading a TTY driver as a module? > >> Depends on the hardware it supports :) >> >