Re: Re[2]: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-10 Thread Benjamin Herrenschmidt
On Wed, 2008-12-10 at 14:21 +0300, Yuri Tikhonov wrote: > > > I'm not sure about the above & PMD_MASK. Shouldn't we instead make it > > not build if (PKMAP_BASE & PMD_MASK) != 0 ? > > We separated the !4K_PAGES case here exactly because (PKMAP_BASE & > PMD_MASK) != 0 [see the comment to this

Re[2]: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-10 Thread Yuri Tikhonov
Hello Ben, On Wednesday, December 10, 2008 you wrote: > Hi Ilya ! > Looks good overall. A few minor comments. >> +config PPC_4K_PAGES >> + bool "4k page size" >> + >> +config PPC_16K_PAGES >> + bool "16k page size" if 44x >> + >> +config PPC_64K_PAGES >> + bool "64k page size" if 4