Re: i2c_powermac: Kernel access of bad area

2010-01-06 Thread Jean Delvare
Hi Christian, hi Ben, On Tue, 29 Dec 2009 20:34:15 +1100, Benjamin Herrenschmidt wrote: > On Mon, 2009-12-28 at 20:40 -0800, Christian Kujau wrote: > > Hi there, > > > > I was trying to find out if I still need i2c_powermac to get details off > > /sys/devices/temperatures, since lm-sensors isn't

Re: i2c_powermac: Kernel access of bad area

2010-01-06 Thread Christian Kujau
On Wed, 6 Jan 2010 at 17:37, Jean Delvare wrote: > Christian, did you happen to try removing the i2c-powermac driver > before? Well, I definitely removed the driver before, but I'm not sure if I ever read the /sys files after doing this :-\ > I am curious if this is a recent problem, possibly ca

Re: i2c_powermac: Kernel access of bad area

2010-01-06 Thread Christian Kujau
Hi Jean, On Wed, 6 Jan 2010 at 17:37, Jean Delvare wrote: > I think that sysfs files creation should be moved to the end of > probe_thermostat() and sysfs files removal should be moved to the > beginning of remove_thermostat(). Something like the totally untested > patch below (no ppc machine at h

Re: i2c_powermac: Kernel access of bad area

2010-01-29 Thread Jean Delvare
Ben, Christian, On Thu, 7 Jan 2010 17:17:38 +0100, Jean Delvare wrote: > On Wed, 6 Jan 2010 19:41:05 -0800 (PST), Christian Kujau wrote: > > Hi Jean, > > > > On Wed, 6 Jan 2010 at 17:37, Jean Delvare wrote: > > > I think that sysfs files creation should be moved to the end of > > > probe_thermost

Re: i2c_powermac: Kernel access of bad area

2010-01-29 Thread Benjamin Herrenschmidt
> Ben, what about applying this patch of mine, as Christian reported it > fixed his oops? Sure. I never quite know with i2c which ones you will apply directly and which ones you want to go through my tree :-) Hopefully they should still be referened on patchwork, I'll dig there and pick them up.

Re: i2c_powermac: Kernel access of bad area

2010-01-29 Thread Christian Kujau
On Fri, 29 Jan 2010 at 09:18, Jean Delvare wrote: > Christian, did you ever test this second patch of mine? If you did, > what was the outcome? Sorry, I must've missed that 2nd patch of yours. I'll test this now and report back. Thanks, Christian. -- BOFH excuse #112: The monitor is plugged in

Re: i2c_powermac: Kernel access of bad area

2010-01-30 Thread Jean Delvare
On Sat, 30 Jan 2010 08:34:55 +1100, Benjamin Herrenschmidt wrote: > > > Ben, what about applying this patch of mine, as Christian reported it > > fixed his oops? > > Sure. I never quite know with i2c which ones you will apply directly and > which ones you want to go through my tree :-) > > Hopef

Re: i2c_powermac: Kernel access of bad area

2010-01-30 Thread Christian Kujau
On Fri, 29 Jan 2010 at 22:03, Christian Kujau wrote: > On Fri, 29 Jan 2010 at 09:18, Jean Delvare wrote: > > Christian, did you ever test this second patch of mine? If you did, > > what was the outcome? OK, I've now applied both the drivers/hwmon/ams/ patches and your earlier one for drivers/maci

Re: i2c_powermac: Kernel access of bad area

2010-01-31 Thread Jean Delvare
On Sat, 30 Jan 2010 22:05:26 -0800 (PST), Christian Kujau wrote: > OK, I've now applied both the drivers/hwmon/ams/ patches and your earlier > one for drivers/macintosh/therm_adt746x.c [0] to a current -git checkout > and now I can unload i2c_powermac, list and read the remaining files in > /sys/