Re: powerpc/32: Avoid miscompilation w/GCC 4.6.3 - don't inline copy_to/from_user()

2017-06-26 Thread Michael Ellerman
On Mon, 2017-06-26 at 13:34:15 UTC, Michael Ellerman wrote: > Larry Finger reported that his Powerbook G4 was no longer booting with > v4.12-rc, > userspace was up but giving weird errors such as: > > udevd[64]: starting version 175 > udevd[64]: Unable to receive ctrl message: Bad address. >

RE: [PATCH] powerpc/32: Avoid miscompilation w/GCC 4.6.3 - don't inline copy_to/from_user()

2017-06-26 Thread David Laight
From: Michael Ellerman > Sent: 26 June 2017 14:34 .. > Al also pointed out that inlining copy_to/from_user() is probably of little or > no benefit, which is correct ... I was a bit horrified at the x86-64 versions of copy_to/from_user() as well. With code that (tries to) error kernel pointers that

[PATCH] powerpc/32: Avoid miscompilation w/GCC 4.6.3 - don't inline copy_to/from_user()

2017-06-26 Thread Michael Ellerman
Larry Finger reported that his Powerbook G4 was no longer booting with v4.12-rc, userspace was up but giving weird errors such as: udevd[64]: starting version 175 udevd[64]: Unable to receive ctrl message: Bad address. modprobe: chdir(4.12-rc1): No such file or directory He bisected the pro