Re: serial driver cleanups v2

2019-03-15 Thread Enrico Weigelt, metux IT consult
On 15.03.19 19:11, Andy Shevchenko wrote: >> The actual goal is generalizing the whole iomem handling, so individual >> usually just need to call some helpers that do most of the things. >> Finally, I also wanted to have all io region information consolidated >> in struct resource. > > That's

Re: serial driver cleanups v2

2019-03-15 Thread Andy Shevchenko
On Fri, Mar 15, 2019 at 8:44 PM Enrico Weigelt, metux IT consult wrote: > On 15.03.19 19:11, Andy Shevchenko wrote: > OTOH, the name, IMHO, is a bit misleading. Any chance of ever changing > it to a more clear name (eg. devm_request_and_ioremap_resource()) ? Compare iomap vs. ioREmap. --

Re: serial driver cleanups v2

2019-03-15 Thread Andy Shevchenko
On Fri, Mar 15, 2019 at 11:36:04AM +0100, Enrico Weigelt, metux IT consult wrote: > On 15.03.19 10:12, Andy Shevchenko wrote: > > >> Part II will be about moving the mmio range from mapbase and > >> mapsize (which are used quite inconsistently) to a struct resource > >> and using helpers for

Re: serial driver cleanups v2

2019-03-15 Thread Enrico Weigelt, metux IT consult
On 15.03.19 10:12, Andy Shevchenko wrote: >> Part II will be about moving the mmio range from mapbase and >> mapsize (which are used quite inconsistently) to a struct resource >> and using helpers for that. But this one isn't finished yet. >> (if somebody likes to have a look at it, I can send

Re: serial driver cleanups v2

2019-03-15 Thread Andy Shevchenko
On Fri, Mar 15, 2019 at 11:12 AM Andy Shevchenko wrote: > On Fri, Mar 15, 2019 at 12:40 AM Enrico Weigelt, metux IT consult > wrote: > > > here's v2 of my serial cleanups queue - part I: > > > > essentially using helpers to code more compact and switching to > > devm_*() functions for mmio

Re: serial driver cleanups v2

2019-03-15 Thread Andy Shevchenko
On Fri, Mar 15, 2019 at 12:40 AM Enrico Weigelt, metux IT consult wrote: > here's v2 of my serial cleanups queue - part I: > > essentially using helpers to code more compact and switching to > devm_*() functions for mmio management. > > Part II will be about moving the mmio range from mapbase

serial driver cleanups v2

2019-03-14 Thread Enrico Weigelt, metux IT consult
Hello folks, here's v2 of my serial cleanups queue - part I: essentially using helpers to code more compact and switching to devm_*() functions for mmio management. Part II will be about moving the mmio range from mapbase and mapsize (which are used quite inconsistently) to a struct resource