out_8(>i2c_reg->i2mod, 0x00);
- out_8(>i2c_reg->i2com, I2COM_MASTER);/* Master mode */
+ out_8(>i2c_reg->i2com, I2COM_MASTER);/* Host mode */
I2COM_MASTER might be coming from the datasheet.
Maybe we can just drop the comment? The value we write is pretty
> > > out_8(>i2c_reg->i2mod, 0x00);
> > > - out_8(>i2c_reg->i2com, I2COM_MASTER); /* Master mode */
> > > + out_8(>i2c_reg->i2com, I2COM_MASTER); /* Host mode */
> >
> > I2COM_MASTER might be coming from the datasheet.
>
> Maybe we can just drop the comment? The value we write is
> > out_8(>i2c_reg->i2mod, 0x00);
> > - out_8(>i2c_reg->i2com, I2COM_MASTER); /* Master mode */
> > + out_8(>i2c_reg->i2com, I2COM_MASTER); /* Host mode */
>
> I2COM_MASTER might be coming from the datasheet.
Maybe we can just drop the comment? The value we write is pretty
Hi Wolfram,
...
> @@ -570,7 +570,7 @@ static int cpm_i2c_setup(struct cpm_i2c *cpm)
> out_8(>i2c_reg->i2brg, brg);
>
> out_8(>i2c_reg->i2mod, 0x00);
> - out_8(>i2c_reg->i2com, I2COM_MASTER); /* Master mode */
> + out_8(>i2c_reg->i2com, I2COM_MASTER); /* Host mode
Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C
specifications and replace "master/slave" with more appropriate terms.
They are also more specific because we distinguish now between a remote
entity ("client") and a local one ("target").
Signed-off-by: Wolfram Sang
---