Re: [PATCH 14/64] i2c: cpm: reword according to newest specification

2024-04-12 Thread Jochen Friedrich
out_8(>i2c_reg->i2mod, 0x00); - out_8(>i2c_reg->i2com, I2COM_MASTER);/* Master mode */ + out_8(>i2c_reg->i2com, I2COM_MASTER);/* Host mode */ I2COM_MASTER might be coming from the datasheet. Maybe we can just drop the comment? The value we write is pretty

Re: [PATCH 14/64] i2c: cpm: reword according to newest specification

2024-04-10 Thread Andi Shyti
> > > out_8(>i2c_reg->i2mod, 0x00); > > > - out_8(>i2c_reg->i2com, I2COM_MASTER); /* Master mode */ > > > + out_8(>i2c_reg->i2com, I2COM_MASTER); /* Host mode */ > > > > I2COM_MASTER might be coming from the datasheet. > > Maybe we can just drop the comment? The value we write is

Re: [PATCH 14/64] i2c: cpm: reword according to newest specification

2024-04-08 Thread Wolfram Sang
> > out_8(>i2c_reg->i2mod, 0x00); > > - out_8(>i2c_reg->i2com, I2COM_MASTER); /* Master mode */ > > + out_8(>i2c_reg->i2com, I2COM_MASTER); /* Host mode */ > > I2COM_MASTER might be coming from the datasheet. Maybe we can just drop the comment? The value we write is pretty

Re: [PATCH 14/64] i2c: cpm: reword according to newest specification

2024-03-26 Thread Andi Shyti
Hi Wolfram, ... > @@ -570,7 +570,7 @@ static int cpm_i2c_setup(struct cpm_i2c *cpm) > out_8(>i2c_reg->i2brg, brg); > > out_8(>i2c_reg->i2mod, 0x00); > - out_8(>i2c_reg->i2com, I2COM_MASTER); /* Master mode */ > + out_8(>i2c_reg->i2com, I2COM_MASTER); /* Host mode

[PATCH 14/64] i2c: cpm: reword according to newest specification

2024-03-22 Thread Wolfram Sang
Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C specifications and replace "master/slave" with more appropriate terms. They are also more specific because we distinguish now between a remote entity ("client") and a local one ("target"). Signed-off-by: Wolfram Sang ---