Re: [PATCH 6/6] i2c: Make remove callback return void

2022-07-17 Thread Pavel Machek
Hi! > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This > way driver authors

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-07-06 Thread Uwe Kleine-König
On Wed, Jul 06, 2022 at 12:13:15PM +0300, Vladimir Oltean wrote: > On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote: > > From: Uwe Kleine-König > > > > The value returned by an i2c driver's remove function is mostly ignored. > > (Only an error message is printed if the value is

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-07-06 Thread Vladimir Oltean
On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-07-05 Thread Uwe Kleine-König
On Tue, Jul 05, 2022 at 12:08:52PM +0200, Jean Delvare wrote: > On Tue, 28 Jun 2022 16:03:12 +0200, Uwe Kleine-König wrote: > > From: Uwe Kleine-König > > > > The value returned by an i2c driver's remove function is mostly ignored. > > (Only an error message is printed if the value is non-zero

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-07-05 Thread Jean Delvare
On Tue, 28 Jun 2022 16:03:12 +0200, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Miguel Ojeda
n...@kernel.org>, Robert Jones , George Joseph , Vincent Knecht , Robin van der Gracht , Randy Dunlap , linux-st...@st-md-mailman.stormreply.com, Michael Tretter , Geert Uytterhoeven , Phong LE , Daniel Beer , Krzysztof Opasiak , Bjorn Andersson , Linux Crypto Mailing List , Pengutronix

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Maximilian Luz
_Roh=c3=a1r?= , "David S. Miller" Errors-To: linuxppc-dev-bounces+archive=mail-archive@lists.ozlabs.org Sender: "Linuxppc-dev" On 6/28/22 16:03, Uwe Kleine-König wrote: From: Uwe Kleine-König The value returned by an i2c driver's remove function is mostly ignored. (Only an error

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Luca Ceresoli
Hi, [keeping only individuals and lists in Cc to avoid bounces] On 28/06/22 16:03, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Uwe Kleine-König
[Dropped most people from Cc, keeping only lists] On Wed, Jun 29, 2022 at 04:11:26PM +0300, Andrey Ryabinin wrote: > On 6/28/22 17:03, Uwe Kleine-König wrote: > > From: Uwe Kleine-König > > > > The value returned by an i2c driver's remove function is mostly ignored. > > (Only an error message is

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Andy Shevchenko
On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Marek Behún
rg>, Robert Jones , George Joseph , Vincent Knecht , Robin van der Gracht , Randy Dunlap , linux-st...@st-md-mailman.stormreply.com, Michael Tretter , Geert Uytterhoeven , Phong LE , Daniel Beer , Krzysztof Opasiak , Bjorn Andersson , linux-cry...@vger.kernel.org, Pengutronix Kernel Team ,

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Greg Kroah-Hartman
.org>, Robert Jones , George Joseph , Vincent Knecht , Robin van der Gracht , Randy Dunlap , linux-st...@st-md-mailman.stormreply.com, Michael Tretter , Geert Uytterhoeven , Phong LE , Daniel Beer , Krzysztof Opasiak , Bjorn Andersson , linux-cry...@vger.kernel.org, Pengutronix Kernel Team

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Uwe Kleine-König
Hello, On Wed, Jun 29, 2022 at 09:24:55AM +0200, Crt Mori wrote: > On Tue, 28 Jun 2022 at 16:04, Uwe Kleine-König > wrote: > > static const struct i2c_device_id mlx90614_id[] = { > > diff --git a/drivers/iio/temperature/mlx90632.c > > b/drivers/iio/temperature/mlx90632.c > > index

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Heikki Krogerus
On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote: > diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c > index cd47c3597e19..2a58185fb14c 100644 > --- a/drivers/usb/typec/hd3ss3220.c > +++ b/drivers/usb/typec/hd3ss3220.c > @@ -245,14 +245,12 @@ static int

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Jeremy Kerr
.org>, Robert Jones , George Joseph , Vincent Knecht , Robin van der Gracht , Randy Dunlap , linux-st...@st-md-mailman.stormreply.com, Michael Tretter , Geert Uytterhoeven , Phong LE , Daniel Beer , Krzysztof Opasiak , Bjorn Andersson , linux-cry...@vger.kernel.org, Pengutronix Kernel Team

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Javier Martinez Canillas
On 6/29/22 09:55, Christophe Leroy wrote: > > > Le 29/06/2022 à 09:23, Uwe Kleine-König a écrit : >> Hello, >> >> [I dropped nearly all individuals from the Cc: list because various >> bounces reported to be unhappy about the long (logical) line.] > > Good idea, even patchwork made a mess of

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Christophe Leroy
Le 29/06/2022 à 09:23, Uwe Kleine-König a écrit : > Hello, > > [I dropped nearly all individuals from the Cc: list because various > bounces reported to be unhappy about the long (logical) line.] Good idea, even patchwork made a mess of it, see

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Javier Martinez Canillas
On 6/29/22 09:23, Uwe Kleine-König wrote: > Hello, > > [I dropped nearly all individuals from the Cc: list because various > bounces reported to be unhappy about the long (logical) line.] > Yes, it also bounced for me when I tried to reply earlier today. > diff --git

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Uwe Kleine-König
Hello, [I dropped nearly all individuals from the Cc: list because various bounces reported to be unhappy about the long (logical) line.] On Wed, Jun 29, 2022 at 03:03:54PM +0800, Jeremy Kerr wrote: > Looks good - just one minor change for the mctp-i2c driver, but only > worthwhile if you end up