How much is this like ethernet? does it still do ARP?
Can it do promiscious receive?
> +LIST_HEAD(rionet_peers);
Does this have to be global?
Not sure about the locking of this stuff, are you
relying on the RTNL?
> +
> +static int rionet_change_mtu(struct net_device *ndev, int new_mtu)
> +{
> +
On Wed, 1 Jun 2005 15:45:26 -0500
Andy Fleming wrote:
>
> On May 31, 2005, at 12:59, Stephen Hemminger wrote:
>
> > Here are some patches:
> > * allow phy's to be modules
> > * use driver owner for ref count
> > * make local functions static
Andy Fleming wrote:
>
> On May 31, 2005, at 12:59, Stephen Hemminger wrote:
>
>> Here are some patches:
>> * allow phy's to be modules
>> * use driver owner for ref count
>> * make local functions static where ever possible
>
>
> I agree
Here are some patches:
* allow phy's to be modules
* use driver owner for ref count
* make local functions static where ever possible
* get rid of bus read may sleep implication in comment.
since you are holding phy spin lock it better not!!
Untested sinc
I finally got around to looking at this for the new skge driver.
The Marvell phy code has several issues:
* hard coded hex values rather than constants
* doesn't handle restricted autonegotiation
* it doesn't really help the driver that much there are too
many othe
