Re: [PATCH] Linux Device Driver for Xilinx LL TEMAC 10/100/1000 Ethernet NIC

2008-09-13 Thread Jeff Garzik
Patch looks good -- ACK -- but I cannot apply since I do not have include/linux/xilinx_devices.h ___ Linuxppc-embedded mailing list Linuxppc-embedded@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-embedded

Re: [PATCH] Linux Device Driver for Xilinx LL TEMAC 10/100/1000 Ethernet NIC

2008-08-22 Thread Sergey Temerkhanov
On Tuesday 19 August 2008 13:34:04 David H. Lynch Jr. wrote: > +   switch (ip->protocol) { > +   case IPPROTO_TCP: > +   start = sizeof(struct iphdr) + ETH_HLEN; > +   insert = sizeof(struct iphdr) + ETH_HLEN + 16; > + 

Re: [PATCH] Linux Device Driver for Xilinx LL TEMAC 10/100/1000 Ethernet NIC

2008-08-22 Thread Sergey Temerkhanov
On Tuesday 19 August 2008 13:34:04 David H. Lynch Jr. wrote: > Pass II > + cur_p->phys = (unsigned char *)pci_map_single(NULL, > + skb->data, skb->len, > + PCI_DMA_TODEVICE); > + cur_p->app4 = (unsigned long)skb; > + > + for (ii = 0; ii

Re: [PATCH] Linux Device Driver for Xilinx LL TEMAC 10/100/1000 Ethernet NIC

2008-08-18 Thread Ben Hutchings
I wrote: > > +static struct net_device_stats * > > +temac_get_stats(struct net_device *ndev) > > +{ > > +return netdev_priv(ndev); > > Not even the right type. Do you read your compiler warnings? Sorry, I now see that this is correct, though it's very fragile - it will silently break if stru

Re: [PATCH] Linux Device Driver for Xilinx LL TEMAC 10/100/1000 Ethernet NIC

2008-08-18 Thread Ben Hutchings
David H. Lynch Jr. wrote: [...] > drivers/net/Kconfig|5 > drivers/net/Makefile |1 > drivers/net/xps_lltemac.c | 1283 > You need to disable line-wrapping for posted patches. If your mailer always wraps the body of a mes

[PATCH] Linux Device Driver for Xilinx LL TEMAC 10/100/1000 Ethernet NIC

2008-08-16 Thread David H. Lynch Jr.
Please bear with me. This is my first patch submission. Grant Likely of Secret Labs has kindly done a prelimary view. Hopefully I have correct the issues he raised. Ethernet driver for Xilinx LL TEMAC Original Author Yoshio Kashiwagi Updated and Maintained by David Lynch Signed-off-by: David H