Re: [Linuxptp-devel] [PATCH v2 10/27] Custom management TLV PORT_ENUMERATION_NP

2014-04-07 Thread Jiri Benc
On Sat, 5 Apr 2014 13:02:14 +0200, Richard Cochran wrote: +struct port_enumeration_np { + UInteger16 numberPorts; + UInteger16 portNumber[0]; +} PACKED; + I don't like this variable sized message. We should stick to fixed sized items. Why do we need this at all? The idea was to

Re: [Linuxptp-devel] [PATCH v2 10/27] Custom management TLV PORT_ENUMERATION_NP

2014-04-07 Thread Richard Cochran
On Mon, Apr 07, 2014 at 06:02:13PM +0200, Jiri Benc wrote: On Sat, 5 Apr 2014 13:02:14 +0200, Richard Cochran wrote: +struct port_enumeration_np { + UInteger16 numberPorts; + UInteger16 portNumber[0]; +} PACKED; + I don't like this variable sized message. We should stick to