On Fri, 23 May 2014 10:32:28 +0200, Miroslav Lichvar wrote: > On Wed, May 14, 2014 at 03:39:40PM +0200, Jiri Benc wrote: > > For now, only CLOCK_REALTIME can be UTC. This may stay this way forever but > > now we have a clean separation between codepaths where CLOCK_REALTIME is > > required and codepaths any UTC clock should take. > > > > The main motiviation behind this change is removal of sync_offset_direction. > > It has to be computed on the fly based on the source and destination when we > > have multiple clocks supported and automatic following of ptp4l state > > changes implemented. > > I've noticed that the UTC-TAI offset is applied in the wrong > direction, I'm seeing 70s offset to UTC with this patch.
Hmm, I see the error, 'offset' is slave - master, not master - slave. The strange thing is I remember testing this in various combinations of master/slave UTC/PTP time scale and offsets :-/ I'll fix this. Also, the second parameter to get_sync_offset is better named 'dst'. Thanks for the review, Jiri -- Jiri Benc ------------------------------------------------------------------------------ Time is money. Stop wasting it! Get your web API in 5 minutes. www.restlet.com/download http://p.sf.net/sfu/restlet _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
