Re: [Linuxptp-devel] [PATCH RFC 7/7] Let the clock code figure the PHC index.

2016-04-15 Thread Keller, Jacob E
On Fri, 2016-04-15 at 18:50 +0200, Richard Cochran wrote: > On Mon, Apr 11, 2016 at 05:31:49PM +, Keller, Jacob E wrote: > > > > Would this make more logical sense as a separate function here? > Yes, it might look cleaner in a helper function, but that would be a > follow on patch.  I prefer n

Re: [Linuxptp-devel] [PATCH RFC 7/7] Let the clock code figure the PHC index.

2016-04-15 Thread Richard Cochran
On Mon, Apr 11, 2016 at 05:31:49PM +, Keller, Jacob E wrote: > Would this make more logical sense as a separate function here? Yes, it might look cleaner in a helper function, but that would be a follow on patch. I prefer not to change blocks of code when moving them, since it makes harder to