Re: [Linuxptp-devel] [PATCH RFC 0/3] Fix UTC offset issue

2017-07-26 Thread Richard Cochran
On Wed, Jul 26, 2017 at 01:13:43PM +0200, Miroslav Lichvar wrote: > An unrelated issue I noticed is that restarting ptp4l which is > compiled/configured with an incorrect offset when phc2sys was already > running and its pmc update happens before ptp4l gets the correct > offset from its master caus

Re: [Linuxptp-devel] [PATCH RFC 2/3] Latch the UTC offset.

2017-07-26 Thread Richard Cochran
On Thu, Jul 27, 2017 at 10:17:51AM +0800, Phil Reid wrote: > On 27/07/2017 05:02, Richard Cochran wrote: > > On Wed, Jul 26, 2017 at 10:23:05AM +0200, Miroslav Lichvar wrote: > > > On Mon, Jul 24, 2017 at 06:38:19PM +0200, Richard Cochran wrote: > > > > + if ((c->tds.flags & UTC_OFF_VALID &&

Re: [Linuxptp-devel] [PATCH RFC 2/3] Latch the UTC offset.

2017-07-26 Thread Phil Reid
On 27/07/2017 05:02, Richard Cochran wrote: On Wed, Jul 26, 2017 at 10:23:05AM +0200, Miroslav Lichvar wrote: On Mon, Jul 24, 2017 at 06:38:19PM +0200, Richard Cochran wrote: + if ((c->tds.flags & UTC_OFF_VALID && c->tds.flags & TIME_TRACEABLE) || + (c->tds.currentUtcOffset > c-

Re: [Linuxptp-devel] [PATCH RFC 2/3] Latch the UTC offset.

2017-07-26 Thread Richard Cochran
On Wed, Jul 26, 2017 at 10:23:05AM +0200, Miroslav Lichvar wrote: > On Mon, Jul 24, 2017 at 06:38:19PM +0200, Richard Cochran wrote: > > + if ((c->tds.flags & UTC_OFF_VALID && c->tds.flags & TIME_TRACEABLE) || > > + (c->tds.currentUtcOffset > c->utc_offset)) { > > + pr_info("updat

Re: [Linuxptp-devel] [PATCH RFC 0/3] Fix UTC offset issue

2017-07-26 Thread Miroslav Lichvar
On Mon, Jul 24, 2017 at 06:38:17PM +0200, Richard Cochran wrote: > This patch series addresses the jumping UTC offset issue that occurs > when the default TAI-UTC offset is out of date, but a then GM master > appears providing the correct offset, only to disappear again. > > Review and comments ar

Re: [Linuxptp-devel] [PATCH RFC 2/3] Latch the UTC offset.

2017-07-26 Thread Miroslav Lichvar
On Mon, Jul 24, 2017 at 06:38:19PM +0200, Richard Cochran wrote: > This patch fixes the issue by remembering the UTC offset when assuming > the slave role. > @@ -658,6 +658,11 @@ static void clock_update_slave(struct clock *c) > if (c->tds.currentUtcOffset < c->utc_offset) { >

Re: [Linuxptp-devel] [PATCHv2 0/9] Add linuxptp bond failover support

2017-07-26 Thread Hangbin Liu
Hi Richard, Any other comments? Thanks Hangbin On Sat, Jul 15, 2017 at 09:33:02PM +0800, Hangbin Liu wrote: > This patch set is to add linuxptp bond fail over support. > > The main idea is get bond's active slave interface via rtnl socket and store > it in struct interface. > > When active inte