Re: [Linuxptp-devel] [PATCH] Added TAILQ for sent delay_req

2018-03-14 Thread Richard Cochran
On Wed, Mar 14, 2018 at 09:17:35PM +, Keller, Jacob E wrote: > This seems like a reasonable thing to want... However, a bit more > explanation on how the storage helps solve this problem, and > possibly how you prevent the list from growing too large in the > worst case might be good. +1 >

Re: [Linuxptp-devel] [PATCH] Added TAILQ for sent delay_req

2018-03-14 Thread Keller, Jacob E
> -Original Message- > From: Anders Selhammer [mailto:anders.selham...@est.tech] > Sent: Tuesday, March 13, 2018 6:14 AM > To: linuxptp-devel@lists.sourceforge.net > Subject: [Linuxptp-devel] [PATCH] Added TAILQ for sent delay_req > > In a ptp unaware network (like the telecom profile for

Re: [Linuxptp-devel] TAILQ for delay request

2018-03-14 Thread Richard Cochran
On Wed, Mar 14, 2018 at 10:12:14AM +, Anders Selhammer wrote: > I send this mail to verify that you noticed that there was a correct patch > sent right after the incorrect set of patches. Yes, we see it on the list. Thanks, Richard

[Linuxptp-devel] [PATCH 4/4] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Peter Schneider
diff --git a/phc2sys.8 b/phc2sys.8 index 4fc4fa3..fa2dbc9 100644 --- a/phc2sys.8 +++ b/phc2sys.8 @@ -8,10 +8,16 @@ phc2sys \- synchronize two or more clocks .B \-r ] [ .B \-r -] [ options ] +] [ +.BI \-f " config-file" +] [ options ] [ +.I long-options +] .br .B phc2sys [ +.BI \-f "

[Linuxptp-devel] [PATCH 3/4] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Peter Schneider
diff --git a/phc2sys.c b/phc2sys.c index 278ab56..c6ab788 100644 --- a/phc2sys.c +++ b/phc2sys.c @@ -877,7 +877,8 @@ static int init_pmc(struct config *cfg, struct node *node, int domain_number) snprintf(uds_local, sizeof(uds_local), "/var/run/phc2sys.%d", getpid()); -

[Linuxptp-devel] [PATCH 2/4] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Peter Schneider
diff --git a/phc2sys.c b/phc2sys.c index c2f0d8e..278ab56 100644 --- a/phc2sys.c +++ b/phc2sys.c @@ -1317,11 +1317,13 @@ int main(int argc, char *argv[]) char *src_name = NULL, *dst_name = NULL; struct clock *src, *dst; struct config *cfg; + struct option *opts;

[Linuxptp-devel] [PATCH 1/4] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Peter Schneider
diff --git a/phc2sys.c b/phc2sys.c index 5c54055..c2f0d8e 100644 --- a/phc2sys.c +++ b/phc2sys.c @@ -1286,6 +1286,7 @@ static void usage(char *progname) " -O [offset]slave-master time offset (0)\n" " -w wait for ptp4l\n" " common

[Linuxptp-devel] [PATCH 0/4] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Peter Schneider
As promised, this is a set of patches to enable long options, specifying a configuration file, and specifying the transportSpecific value. Patch 1:Enable configuration file on command line Patch 2:Enable long options Patch 3:Add transportSpecific functionality Patch 4:

Re: [Linuxptp-devel] [PATCH 0/5] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Keller, Jacob E
> -Original Message- > From: Peter Schneider [mailto:pe...@psch.de] > Sent: Wednesday, March 14, 2018 5:33 AM > To: linuxptp-devel@lists.sourceforge.net > Subject: [Linuxptp-devel] [PATCH 0/5] phc2sys: long options / cfg file / > transportSpecific > > As promised, this is a set of

Re: [Linuxptp-devel] [PATCH 4/5] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Peter Schneider
Am 14.03.2018 um 14:25 schrieb Anders Selhammer: > ... > Why not get transportSpecific from cfg inside init_pmc() instead. Then you do > not need to declare transport_specific in main and no need to add extra in > parameter to init_pmc() Yes, you're right. This would completely void Patch 1/5

[Linuxptp-devel] [PATCH 5/5] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Peter Schneider
diff --git a/phc2sys.8 b/phc2sys.8 index 4fc4fa3..fa2dbc9 100644 --- a/phc2sys.8 +++ b/phc2sys.8 @@ -8,10 +8,16 @@ phc2sys \- synchronize two or more clocks .B \-r ] [ .B \-r -] [ options ] +] [ +.BI \-f " config-file" +] [ options ] [ +.I long-options +] .br .B phc2sys [ +.BI \-f "

[Linuxptp-devel] [PATCH 4/5] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Peter Schneider
diff --git a/phc2sys.c b/phc2sys.c index 666ec0b..a9a72ff 100644 --- a/phc2sys.c +++ b/phc2sys.c @@ -1526,6 +1526,8 @@ int main(int argc, char *argv[]) print_set_syslog(use_syslog); print_set_level(print_level); + transport_specific = config_get_int(cfg, NULL,

[Linuxptp-devel] [PATCH 3/5] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Peter Schneider
diff --git a/phc2sys.c b/phc2sys.c index a62d177..666ec0b 100644 --- a/phc2sys.c +++ b/phc2sys.c @@ -1319,12 +1319,14 @@ int main(int argc, char *argv[]) char *src_name = NULL, *dst_name = NULL; struct clock *src, *dst; struct config *cfg; + struct option *opts;

[Linuxptp-devel] [PATCH 2/5] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Peter Schneider
diff --git a/phc2sys.c b/phc2sys.c index 61ae7b0..a62d177 100644 --- a/phc2sys.c +++ b/phc2sys.c @@ -1288,6 +1288,7 @@ static void usage(char *progname) " -O [offset]slave-master time offset (0)\n" " -w wait for ptp4l\n" " common

[Linuxptp-devel] [PATCH 1/5] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Peter Schneider
diff --git a/phc2sys.c b/phc2sys.c index 5c54055..61ae7b0 100644 --- a/phc2sys.c +++ b/phc2sys.c @@ -871,13 +871,15 @@ static void send_subscription(struct node *node) pmc_send_set_action(node->pmc, TLV_SUBSCRIBE_EVENTS_NP, , sizeof(sen)); } -static int init_pmc(struct config *cfg,

[Linuxptp-devel] [PATCH 0/5] phc2sys: long options / cfg file / transportSpecific

2018-03-14 Thread Peter Schneider
As promised, this is a set of patches to enable long options, a specifying a configuration filele, and specifying the transportSpecific value. Patch 1:Add transportSpecific as parameter to init_pmc() Patch 2:Enable configuration file on command line Patch 3:Enable long

[Linuxptp-devel] TAILQ for delay request

2018-03-14 Thread Anders Selhammer
Hi Sorry for yesterdays mistake when I did push from wrong branch. Had problem with authorization in my git-email and when I solved it, I was to quick on the send button so I forgot that I switched branch earlier. I send this mail to verify that you noticed that there was a correct patch sent