Re: [Linuxptp-devel] [Linuxptp-users] ptp4l and SyncE

> -Original Message- > From: Cliff Spradlin [mailto:csprad...@waymo.com] > Sent: Monday, April 23, 2018 1:26 PM > To: Keller, Jacob E > Subject: Re: [Linuxptp-users] ptp4l and SyncE > > Good point. Like you said, it should only need one correction. My >

Re: [Linuxptp-devel] [PATCH V2 6/6] telecom: Introduce the G.8275.masterOnly option.

On Mon, Apr 23, 2018 at 10:28:50AM +, Anders Selhammer wrote: > masterOnly will be included in v2.1 so it will not be a profile specific > attribute. > Should this be changed when updated for v2.1? Good point. I think it best to simply drop the prefix. Thanks, Richard

Re: [Linuxptp-devel] [PATCH V2 2/6] telecom: Add the data set comparison algorithm from the Telecom Profiles.

On Mon, Apr 23, 2018 at 09:00:46AM +, Anders Selhammer wrote: > This function introduces a lot of "if" without braces. Yes, and I explained the reason for it. Thanks, Richard -- Check out the vibrant tech community

Re: [Linuxptp-devel] [PATCH V2 6/6] telecom: Introduce the G.8275.masterOnly option.

Friday, April 20, 2018 6:09 PM > + PORT_ITEM_INT("G.8275.masterOnly", 0, 0, 1), masterOnly will be included in v2.1 so it will not be a profile specific attribute. Should this be changed when updated for v2.1? /Anders

Re: [Linuxptp-devel] [PATCH V2 5/6] telecom: Add a configuration option to use the alternate BMCA.

Friday, April 20, 2018 6:09 PM - p->dscmp = dscmp; + if (config_get_int(cfg, NULL, "dataset_comparison") == DS_CMP_G8275) { + p->dscmp = telecom_dscmp; + } else { + p->dscmp = dscmp; + } This should not be needed if port get the comparation

Re: [Linuxptp-devel] [PATCH V2 2/6] telecom: Add the data set comparison algorithm from the Telecom Profiles.

Friday, April 20, 2018 6:09 PM > +int telecom_dscmp(struct dataset *a, struct dataset *b) This function introduces a lot of "if" without braces. /Anders -- Check out the vibrant tech community on one of the world's

[Linuxptp-devel] [PATCH v2 3/7] clock: Renamed get function for clock dataset

Signed-off-by: Anders Selhammer --- bmc.c | 2 +- clock.c | 6 +++--- clock.h | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/bmc.c b/bmc.c index 198a574..605183e 100644 --- a/bmc.c +++ b/bmc.c @@ -145,7 +145,7 @@ enum port_state

[Linuxptp-devel] [PATCH v2 4/7] bmc: Renamed dscmp to dscmp_ieee1588

Signed-off-by: Anders Selhammer --- bmc.c | 2 +- bmc.h | 2 +- clock.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bmc.c b/bmc.c index 605183e..fd80f99 100644 --- a/bmc.c +++ b/bmc.c @@ -80,7 +80,7 @@ int dscmp2(struct dataset *a, struct

[Linuxptp-devel] [PATCH v2 7/7] Add a configuration file option for dscmp and local priority

Signed-off-by: Anders Selhammer --- bmc.h | 5 + clock.c | 15 --- config.c| 12 +++- default.cfg | 3 +++ gPTP.cfg| 3 +++ port.c | 2 ++ ptp4l.8 | 33 + 7 files changed, 69

[Linuxptp-devel] [PATCH v2 6/7] bmc: Added dscmp_G8275

Signed-off-by: Anders Selhammer --- bmc.c | 63 +++ bmc.h | 10 ++ 2 files changed, 73 insertions(+) diff --git a/bmc.c b/bmc.c index fd80f99..7a8bca1 100644 --- a/bmc.c +++ b/bmc.c @@ -139,6 +139,69

[Linuxptp-devel] [PATCH v2 0/7] Adding option to select alternate bmca defined in ITU-T G.8275.1

In profile ITU-T G.8275.1 an Alternate Best Master Clock Algorithm is defined. This includes the new attribute local priority for both the clock and the port. This set of patches makes it possible to configure local priority and select the G8275 BCMA instead of default IEEE1588 BCMA. Anders

[Linuxptp-devel] [PATCH v2 5/7] ds: Added localPriority attribute

Signed-off-by: Anders Selhammer --- clock.c| 7 +++ clock.h| 7 +++ ds.h | 1 + port.c | 20 +--- port.h | 9 - port_private.h | 1 + 6 files changed, 37 insertions(+), 8 deletions(-) diff

[Linuxptp-devel] [PATCH v2 2/7] clock: Added getter for dscmp configured for the clock

Signed-off-by: Anders Selhammer --- bmc.c | 3 ++- bmc.h | 9 ++--- clock.c| 7 ++- clock.h| 8 port.c | 5 +++-- port_private.h | 1 - 6 files changed, 25 insertions(+), 8 deletions(-) diff --git a/bmc.c